[Bug libstdc++/21770] New: rebinding allocator::value type vs. container::value_type

[Bug libstdc++/21770] New: rebinding allocator::value type vs. container::value_type

[bkoz at gcc dot gnu dot org]

Ami pointed this out to me a while ago. It seems as if we need to be able to
support  things like:

std::vector<int, std::allocator<char> > 

which was news to me. The current implementation is ... not so good about this.

This is a QoI issue, where Dinkumware and RW do this.

So, implement, figure out a way to test this, and apply consistently for all
containers.

-- 
           Summary: rebinding allocator::value type vs.
                    container::value_type
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bkoz at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-26 17:43 -------
This is news to me too: what about 23.1/8? It says:

 "All other constructors for these container types take an Allocator& argument
 (20.1.5), an allocator whose value type is the same as the container's value
 type"

Allocator is the template argument of the vector class, of course. Missing a
clarification of the above, or a DR?!?, I consider this as an extension, lower
priority than other new issues.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pcarlini at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-26 18:17 -------
... that said, if we agree about the substance of the issue, I volunteer to
work on it: have already some experience with rebind-related issues in 
basic_string. Ah, yes, this extension makes certainly sense, because, for
basic_string doesn't exist an equivalent of 23.1/8, rebinding is necessary
in any case. Matter of consistency, in other terms: already noticed in
comment #23 of 19495, by the way ;)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[bkoz at redhat dot com]

------- Additional Comments From bkoz at redhat dot com  2005-05-26 20:12 -------
Subject: Re:  rebinding allocator::value type vs.
 container::value_type


Yo P, just trying to get through the deluge. I've not looked into
specifics, so sorry for such a vague marker in bugzilla.

I'm not quite sure of where the standard stands on this. I think it's QoI, not required. However, it seems like a good idea.

-benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-26 20:15 -------
Hmm, maybe there should be a way in debug mode to diagnose this at runtime since this seems like a 
violation of the standard.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-26 20:19 -------
Agreed. Then, I'm going to look into it. Testcases are easy to find: actually,
your example, std::vector<int, std::allocator<char> > , doesn't even compile,
currently.

To Andrew: maybe, in pedantic mode. But notice that the problem should be
detected at *compile* time: indeed seems doable using a bit of template
tricks: is_same<allocator::value_type, container::value_type> ...

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pcarlini at suse dot de
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-26 20:19:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-26 20:50 -------
Actually, we already have the machinery, in concept-checks ;) Would be:

  __glibcxx_class_requires2(_Tp, typename _Alloc::value_type, _SameTypeConcept)

on top of each container.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-03 17:07 -------
Subject: Bug 21770

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2005-06-03 17:07:48

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: basic_string.h deque.tcc list.tcc 
	                           stl_deque.h stl_list.h stl_map.h 
	                           stl_multimap.h stl_multiset.h 
	                           stl_set.h stl_vector.h vector.tcc 
Added files:
	libstdc++-v3/testsuite/21_strings/basic_string: 1.cc 
	libstdc++-v3/testsuite/23_containers/deque/explicit_instantiation: 
	                                                                   1.cc 
	                                                                   3.cc 
	libstdc++-v3/testsuite/23_containers/list/explicit_instantiation: 
	                                                                  1.cc 
	                                                                  3.cc 
	libstdc++-v3/testsuite/23_containers/map/explicit_instantiation: 
	                                                                 1.cc 
	                                                                 3.cc 
	libstdc++-v3/testsuite/23_containers/multimap/explicit_instantiation: 
	                                                                      1.cc 
	                                                                      3.cc 
	libstdc++-v3/testsuite/23_containers/multiset/explicit_instantiation: 
	                                                                      1.cc 
	                                                                      3.cc 
	libstdc++-v3/testsuite/23_containers/set/explicit_instantiation: 
	                                                                 1.cc 
	                                                                 3.cc 
	libstdc++-v3/testsuite/23_containers/vector/explicit_instantiation: 
	                                                                    1.cc 
	                                                                    3.cc 
Removed files:
	libstdc++-v3/testsuite/23_containers/deque: 
	                                            explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/list: 
	                                           explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/map: 
	                                          explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/multimap: 
	                                               explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/multiset: 
	                                               explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/set: 
	                                          explicit_instantiation.cc 
	libstdc++-v3/testsuite/23_containers/vector: 
	                                             explicit_instantiation.cc 

Log message:
	2005-06-03  Paolo Carlini  <pcarlini@suse.de>
	
	PR libstdc++/21770
	* include/bits/stl_deque.h: Add concept-check. In class _Deque_base
	rebind _Alloc to  _Tp_alloc_type, change _Deque_impl to inherit from
	the latter and add _M_get_Tp_allocator() which returns it. Use
	everywhere _M_get_Tp_allocator() instead of get_allocator().
	* include/bits/deque.tcc: Likewise, use _M_get_Tp_allocator().
	* include/bits/stl_list.h: Add concept-check. In class _List_base
	rebind _Alloc to _Tp_alloc_type and add _M_get_Tp_allocator(), which
	returns the allocator (of type _Node_alloc_type) converted to
	_Tp_alloc_type. Use everywhere _M_get_Tp_allocator() instead of
	get_allocator().
	* include/bits/list.tcc: Likewise, use _M_get_Tp_allocator().
	* include/bits/stl_vector.h: Add concept-check. In class _Vector_base
	rebind _Alloc to _Tp_alloc_type, change _Vector_impl to inherit from
	the latter and add _M_get_Tp_allocator() which returns it. Use
	everywhere _M_get_Tp_allocator() instead of get_allocator().
	* include/bits/vector.tcc: Likewise, use _M_get_Tp_allocator().
	* include/bits/stl_map.h: Add concept-check. Rebind _Alloc to
	_Pair_alloc_type and use it for _Rb_tree.
	* include/bits/stl_multimap.h: Likewise.
	* include/bits/stl_multiset.h: Add concept-check. Rebind _Alloc to
	_Key_alloc_type and use it for _Rb_tree.
	* include/bits/stl_set.h: Likewise.
	* include/bits/basic_string.h: Rebind _Alloc to _CharT_alloc_type and
	use it for the allocator typedefs.
	* testsuite/21_strings/basic_string/1.cc: New.
	* testsuite/23_containers/deque/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/deque/explicit_instantiation/1.cc: ... here.
	* testsuite/23_containers/deque/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/list/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/list/explicit_instantiation/1.cc: ... here.
	* testsuite/23_containers/list/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/map/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/map/explicit_instantiation/1.cc: ... here.
	* testsuite/23_containers/map/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/multimap/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/multimap/explicit_instantiation/1.cc: .. here.
	* testsuite/23_containers/multimap/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/multiset/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/multiset/explicit_instantiation/1.cc: .. here.
	* testsuite/23_containers/multiset/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/set/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/set/explicit_instantiation/1.cc: .. here.
	* testsuite/23_containers/set/explicit_instantiation/3.cc: New.
	* testsuite/23_containers/vector/explicit_instantiation.cc: Move to...
	* testsuite/23_containers/vector/explicit_instantiation/1.cc: ... here.
	* testsuite/23_containers/vector/explicit_instantiation/3.cc: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3027&r2=1.3028
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/21_strings/basic_string/1.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/basic_string.h.diff?cvsroot=gcc&r1=1.79&r2=1.80
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/deque.tcc.diff?cvsroot=gcc&r1=1.21&r2=1.22
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/list.tcc.diff?cvsroot=gcc&r1=1.18&r2=1.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_deque.h.diff?cvsroot=gcc&r1=1.57&r2=1.58
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_list.h.diff?cvsroot=gcc&r1=1.48&r2=1.49
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_map.h.diff?cvsroot=gcc&r1=1.26&r2=1.27
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_multimap.h.diff?cvsroot=gcc&r1=1.25&r2=1.26
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_multiset.h.diff?cvsroot=gcc&r1=1.25&r2=1.26
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_set.h.diff?cvsroot=gcc&r1=1.24&r2=1.25
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_vector.h.diff?cvsroot=gcc&r1=1.54&r2=1.55
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/vector.tcc.diff?cvsroot=gcc&r1=1.23&r2=1.24
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/deque/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/deque/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/deque/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/list/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/list/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/list/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/map/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/map/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/map/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multimap/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multimap/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multimap/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multiset/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multiset/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/multiset/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/set/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/set/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/set/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/vector/explicit_instantiation.cc.diff?cvsroot=gcc&r1=1.1&r2=NONE
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/vector/explicit_instantiation/1.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/23_containers/vector/explicit_instantiation/3.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-03 17:12 -------
Done.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2005-06-07 00:06 -------

Paolo Note that the new testcases (explicit_instantiation/3.cc) fail in debug mode.

To test this, use -D_GLIBCXX_DEBUG in scripts/testsuite_flags

-benjamin

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-07 00:10 -------
Well, of course they do. They also fail with concept-checks enabled. Do we really
want to allow for this extension in debug-mode too? If we agree about that, I
can work on it, lower priority, really, however ;)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-07 00:51 -------
Actually, we can fix that elegantly, removing some inconsistencies in the typedefs
of the debug-mode code ;) I'm on it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-07 02:23 -------
Subject: Bug 21770

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2005-06-07 02:23:44

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/debug: deque list map.h multimap.h 
	                            multiset.h set.h vector 

Log message:
	2005-06-06  Paolo Carlini  <pcarlini@suse.de>
	
	PR libstdc++/21770 (cont: debug-mode)
	* include/debug/deque: Use _Base typedefs for pointer, const_pointer,
	reference, const_reference.
	* include/debug/list: Likewise.
	* include/debug/map.h: Likewise.
	* include/debug/multimap.h: Likewise.
	* include/debug/multiset.h: Likewise.
	* include/debug/set.h: Likewise.
	* include/debug/vector: Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3032&r2=1.3033
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/deque.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/list.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/map.h.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/multimap.h.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/multiset.h.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/set.h.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/vector.diff?cvsroot=gcc&r1=1.5&r2=1.6



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770

[Bug libstdc++/21770] rebinding allocator::value type vs. container::value_type

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-07 02:55 -------
Subject: Bug 21770

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2005-06-07 02:55:06

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/debug: string 
Added files:
	libstdc++-v3/testsuite/21_strings/basic_string: 2.cc 

Log message:
	2005-06-06  Paolo Carlini  <pcarlini@suse.de>
	
	PR libstdc++/21770 (cont: __gnu_debug::string)
	* include/debug/string: Use _Base typedefs for pointer, const_pointer,
	reference, const_reference, size_type, difference_type.
	* testsuite/21_strings/basic_string/2.cc: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3033&r2=1.3034
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/debug/string.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/21_strings/basic_string/2.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21770