public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata
@ 2005-05-25 21:16 pcarlini at suse dot de
2005-05-25 22:30 ` [Bug target/21760] [4.1 Regression] " pinskia at gcc dot gnu dot org
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: pcarlini at suse dot de @ 2005-05-25 21:16 UTC (permalink / raw)
To: gcc-bugs
In libstdc++-v3, atomicity.h for powerpc used to include:
#ifdef __PPC405__
#define _STWCX "sync \n\tstwcx. "
#else
#define _STWCX "stwcx. "
#endif
This work around is still missing from the powerpc implementation of the
builtins for atomic memory operations.
--
Summary: Powerpc atomic builtins missing PPC405 errata
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: critical
Priority: P2
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: pcarlini at suse dot de
CC: dje at watson dot ibm dot com,gcc-bugs at gcc dot gnu
dot org
GCC target triplet: powerpc-*
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
@ 2005-05-25 22:30 ` pinskia at gcc dot gnu dot org
2005-05-28 5:12 ` geoffk at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-05-25 22:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-05-25 22:28 -------
Confirmed, Adding Geoff to the CC since he was the one who implemented the builtins for PPC.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |geoffk at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-05-25 22:28:08
date| |
Summary|Powerpc atomic builtins |[4.1 Regression] Powerpc
|missing PPC405 errata |atomic builtins missing
| |PPC405 errata
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
2005-05-25 22:30 ` [Bug target/21760] [4.1 Regression] " pinskia at gcc dot gnu dot org
@ 2005-05-28 5:12 ` geoffk at gcc dot gnu dot org
2005-05-28 7:47 ` [Bug target/21760] " geoffk at gcc dot gnu dot org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: geoffk at gcc dot gnu dot org @ 2005-05-28 5:12 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From geoffk at gcc dot gnu dot org 2005-05-28 05:10 -------
I'll look at this, but the obvious solution is to not use the builtins on a 405.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |geoffk at gcc dot gnu dot
|dot org |org
Severity|critical |enhancement
Status|NEW |ASSIGNED
Last reconfirmed|2005-05-25 22:28:08 |2005-05-28 05:10:32
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
2005-05-25 22:30 ` [Bug target/21760] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-05-28 5:12 ` geoffk at gcc dot gnu dot org
@ 2005-05-28 7:47 ` geoffk at gcc dot gnu dot org
2005-05-28 8:08 ` pcarlini at suse dot de
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: geoffk at gcc dot gnu dot org @ 2005-05-28 7:47 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From geoffk at gcc dot gnu dot org 2005-05-28 05:11 -------
Not a regression, the builtins didn't exist in 4.0.
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.1 Regression] Powerpc |Powerpc atomic builtins
|atomic builtins missing |missing PPC405 errata
|PPC405 errata |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (2 preceding siblings ...)
2005-05-28 7:47 ` [Bug target/21760] " geoffk at gcc dot gnu dot org
@ 2005-05-28 8:08 ` pcarlini at suse dot de
2005-05-30 2:01 ` [Bug target/21760] [4.1 Regression] " dje at gcc dot gnu dot org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pcarlini at suse dot de @ 2005-05-28 8:08 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2005-05-28 07:59 -------
Please, consider encapsulating the errata in the implementation of the builtins.
During the next years these facilities will be used more and more, in the C++
runtime and elsewhere, of course: if people have to provide macros and keep
around open coded inline assembly implementations for PPC405, we are not making
such a big progress, IMHO.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (3 preceding siblings ...)
2005-05-28 8:08 ` pcarlini at suse dot de
@ 2005-05-30 2:01 ` dje at gcc dot gnu dot org
2005-05-30 16:19 ` geoffk at geoffk dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu dot org @ 2005-05-30 2:01 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From dje at gcc dot gnu dot org 2005-05-30 01:40 -------
This is a regression because libstdc++ previously worked correctly on PPC405 and
now it does not.
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|Powerpc atomic builtins |[4.1 Regression] Powerpc
|missing PPC405 errata |atomic builtins missing
| |PPC405 errata
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (4 preceding siblings ...)
2005-05-30 2:01 ` [Bug target/21760] [4.1 Regression] " dje at gcc dot gnu dot org
@ 2005-05-30 16:19 ` geoffk at geoffk dot org
2005-05-30 16:47 ` dje at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: geoffk at geoffk dot org @ 2005-05-30 16:19 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From geoffk at geoffk dot org 2005-05-30 15:37 -------
Subject: Re: [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
On 29/05/2005, at 6:40 PM, dje at gcc dot gnu dot org wrote:
> This is a regression because libstdc++ previously worked correctly
> on PPC405 and
> now it does not.
That would be due to this patch:
2005-05-25 Paolo Carlini <pcarlini@suse.de>
* config/cpu/alpha/atomicity.h: Use the builtins for
atomic memory operations.
* config/cpu/powerpc/atomicity.h: Likewise.
* config/cpu/ia64/atomicity.h: Do not include ia64intrin.h.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (5 preceding siblings ...)
2005-05-30 16:19 ` geoffk at geoffk dot org
@ 2005-05-30 16:47 ` dje at gcc dot gnu dot org
2005-06-21 14:57 ` dje at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu dot org @ 2005-05-30 16:47 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From dje at gcc dot gnu dot org 2005-05-30 16:41 -------
See the thread related to
http://gcc.gnu.org/ml/gcc-patches/2005-05/msg02424.html .
The problem is that the new builtin atomic functionality does not support all of
the special cases that the inlined assembly supported. libstdc++ now is using
builtins. Paolo apparently cannot fix the breakage that he caused and is
dropping the problem on the port maintainers.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (6 preceding siblings ...)
2005-05-30 16:47 ` dje at gcc dot gnu dot org
@ 2005-06-21 14:57 ` dje at gcc dot gnu dot org
2005-06-23 13:24 ` cvs-commit at gcc dot gnu dot org
2005-06-24 14:12 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu dot org @ 2005-06-21 14:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From dje at gcc dot gnu dot org 2005-06-21 14:57 -------
This is a bug introduced by the sync patch, not an enhancement request.
I have created a patch to restore the functionality.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|geoffk at gcc dot gnu dot |dje at gcc dot gnu dot org
|org |
Severity|enhancement |critical
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (7 preceding siblings ...)
2005-06-21 14:57 ` dje at gcc dot gnu dot org
@ 2005-06-23 13:24 ` cvs-commit at gcc dot gnu dot org
2005-06-24 14:12 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-23 13:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-23 13:24 -------
Subject: Bug 21760
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: dje@gcc.gnu.org 2005-06-23 13:24:14
Modified files:
gcc : ChangeLog
gcc/config/rs6000: rs6000.h rs6000.md
Added files:
gcc/config/rs6000: sync.md
Log message:
PR target/21760
* config/rs6000/rs6000.h (PPC405_ERRATUM77): New.
* config/rs6000/rs6000.md: Move atomic instructions to ...
* config/rs6000/sync.md: Here.
Change sync_compare_and_swap<mode> to define_expand. All stwcx
patterns test PPC405_ERRATUM77.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9210&r2=2.9211
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/rs6000/sync.md.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/rs6000/rs6000.h.diff?cvsroot=gcc&r1=1.370&r2=1.371
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/rs6000/rs6000.md.diff?cvsroot=gcc&r1=1.381&r2=1.382
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug target/21760] [4.1 Regression] Powerpc atomic builtins missing PPC405 errata
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
` (8 preceding siblings ...)
2005-06-23 13:24 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-24 14:12 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-24 14:12 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-06-24 14:12 -------
Fixed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21760
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2005-06-24 14:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-25 21:16 [Bug target/21760] New: Powerpc atomic builtins missing PPC405 errata pcarlini at suse dot de
2005-05-25 22:30 ` [Bug target/21760] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-05-28 5:12 ` geoffk at gcc dot gnu dot org
2005-05-28 7:47 ` [Bug target/21760] " geoffk at gcc dot gnu dot org
2005-05-28 8:08 ` pcarlini at suse dot de
2005-05-30 2:01 ` [Bug target/21760] [4.1 Regression] " dje at gcc dot gnu dot org
2005-05-30 16:19 ` geoffk at geoffk dot org
2005-05-30 16:47 ` dje at gcc dot gnu dot org
2005-06-21 14:57 ` dje at gcc dot gnu dot org
2005-06-23 13:24 ` cvs-commit at gcc dot gnu dot org
2005-06-24 14:12 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).