public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures
@ 2005-05-01 22:22 tkoenig at gcc dot gnu dot org
  2005-05-02 11:59 ` [Bug libfortran/21324] " tkoenig at gcc dot gnu dot org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-01 22:22 UTC (permalink / raw)
  To: gcc-bugs

It would be better for performance if allocated memory
wouldn't need to be cleared.  Doing this for array temporaries
can cost a lot.

Not #defining GFC_CLEAR_MEMORY in memory.c leads to failures,
however:

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /home/ig25/gcc-4.1/gcc/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /home/ig25/gcc-4.1/gcc/testsuite/gfortran.dg/dg.exp ...
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O0  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O1  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O2  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O3 -fomit-frame-pointer  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O3 -fomit-frame-pointer -funroll-loops  executiontest
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -O3 -g  execution test
WARNING: program timed out.
FAIL: gfortran.dg/PR19872.f  -Os  execution test
FAIL: gfortran.dg/backspace.f  -O0  execution test
FAIL: gfortran.dg/backspace.f  -O1  execution test
FAIL: gfortran.dg/backspace.f  -O2  execution test
FAIL: gfortran.dg/backspace.f  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/backspace.f  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/backspace.f  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
FAIL: gfortran.dg/backspace.f  -O3 -g  execution test
FAIL: gfortran.dg/backspace.f  -Os  execution test
FAIL: gfortran.dg/endfile.f90  -O0  execution test
FAIL: gfortran.dg/endfile.f90  -O1  execution test
FAIL: gfortran.dg/endfile.f90  -O2  execution test
FAIL: gfortran.dg/endfile.f90  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/endfile.f90  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/endfile.f90  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
FAIL: gfortran.dg/endfile.f90  -O3 -g  execution test
FAIL: gfortran.dg/endfile.f90  -Os  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O0  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O1  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O2  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O3 -fomit-frame-pointer
-funroll-all-loops -finline-functions  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -O3 -g  execution test
FAIL: gfortran.dg/eor_handling_4.f90  -Os  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O0  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O1  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O2  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O3 -fomit-frame-pointer  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O3 -fomit-frame-pointer -funroll-loops 
execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
WARNING: program timed out.
FAIL: gfortran.dg/inquire_5.f90  -O3 -g  execution test

(plus maybe a few more, the testsuite hasn't finished yet),
so some parts of the library seem to depend on zeroed memory.

I'll try to isolate these failures and open individual PRs for
them.

Thomas

-- 
           Summary: #undef GFC_CLEAR_MEMORY causes testsuite failures
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
@ 2005-05-02 11:59 ` tkoenig at gcc dot gnu dot org
  2005-05-02 14:30 ` tkoenig at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-02 11:59 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-02 11:58 -------
Filling allocated memory with garbage is even more fun,
this causes around 3000 testsuite failures.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
  2005-05-02 11:59 ` [Bug libfortran/21324] " tkoenig at gcc dot gnu dot org
@ 2005-05-02 14:30 ` tkoenig at gcc dot gnu dot org
  2005-05-03  6:52 ` tkoenig at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-02 14:30 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-02 14:29 -------
Created an attachment (id=8801)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8801&action=view)
Proposed patch


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tkoenig at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
  2005-05-02 11:59 ` [Bug libfortran/21324] " tkoenig at gcc dot gnu dot org
  2005-05-02 14:30 ` tkoenig at gcc dot gnu dot org
@ 2005-05-03  6:52 ` tkoenig at gcc dot gnu dot org
  2005-05-12 17:51 ` cvs-commit at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-03  6:52 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-03 06:52 -------
Patch here:

http://gcc.gnu.org/ml/fortran/2005-05/msg00016.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2005-05-03  6:52 ` tkoenig at gcc dot gnu dot org
@ 2005-05-12 17:51 ` cvs-commit at gcc dot gnu dot org
  2005-05-12 19:11 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-12 17:51 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-12 17:50 -------
Subject: Bug 21324

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tkoenig@gcc.gnu.org	2005-05-12 17:50:35

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/io : open.c unit.c unix.c 
	libgfortran/runtime: memory.c 

Log message:
	2005-05-12  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21324
	* runtime/memory.c:  Don't define GFC_CLEAR_MEMORY (it's a
	performance hog).
	* io/open.c (new_unit): Zero freshly allocated memory for
	unit structure.
	* io/unit.c (init_units):  Zero freshly allocated memory for
	STDIN, STDOUT and STDERR.
	* io/unix.c (open_internal):  Zero freshly allocated memory
	for unix_stream.
	(fd_to_stream):  Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.214&r2=1.215
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/open.c.diff?cvsroot=gcc&r1=1.13&r2=1.14
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unit.c.diff?cvsroot=gcc&r1=1.8&r2=1.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unix.c.diff?cvsroot=gcc&r1=1.24&r2=1.25
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/memory.c.diff?cvsroot=gcc&r1=1.6&r2=1.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2005-05-12 17:51 ` cvs-commit at gcc dot gnu dot org
@ 2005-05-12 19:11 ` cvs-commit at gcc dot gnu dot org
  2005-05-12 19:12 ` tkoenig at gcc dot gnu dot org
  2005-06-05  7:49 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-12 19:11 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-12 19:11 -------
Subject: Bug 21324

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tkoenig@gcc.gnu.org	2005-05-12 19:10:59

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/io : open.c unit.c unix.c 
	libgfortran/runtime: memory.c 

Log message:
	2005-05-12  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21324
	* runtime/memory.c:  Don't define GFC_CLEAR_MEMORY (it's a
	performance hog).
	* io/open.c (new_unit): Zero freshly allocated memory for
	unit structure.
	* io/unit.c (init_units):  Zero freshly allocated memory for
	STDIN, STDOUT and STDERR.
	* io/unix.c (open_internal):  Zero freshly allocated memory
	for unix_stream.
	(fd_to_stream):  Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.28&r2=1.163.2.29
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/open.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.10.10.3&r2=1.10.10.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unit.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unix.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.21.10.3&r2=1.21.10.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/memory.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.6&r2=1.6.12.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2005-05-12 19:11 ` cvs-commit at gcc dot gnu dot org
@ 2005-05-12 19:12 ` tkoenig at gcc dot gnu dot org
  2005-06-05  7:49 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-12 19:12 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-12 19:12 -------
Fixed in mainline and 4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/21324] #undef GFC_CLEAR_MEMORY causes testsuite failures
  2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2005-05-12 19:12 ` tkoenig at gcc dot gnu dot org
@ 2005-06-05  7:49 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-05  7:49 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21324


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2005-06-05  7:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-01 22:22 [Bug libfortran/21324] New: #undef GFC_CLEAR_MEMORY causes testsuite failures tkoenig at gcc dot gnu dot org
2005-05-02 11:59 ` [Bug libfortran/21324] " tkoenig at gcc dot gnu dot org
2005-05-02 14:30 ` tkoenig at gcc dot gnu dot org
2005-05-03  6:52 ` tkoenig at gcc dot gnu dot org
2005-05-12 17:51 ` cvs-commit at gcc dot gnu dot org
2005-05-12 19:11 ` cvs-commit at gcc dot gnu dot org
2005-05-12 19:12 ` tkoenig at gcc dot gnu dot org
2005-06-05  7:49 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).