public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/21926] New: matmul does not deal with non-packed result
@ 2005-06-05 20:53 tkoenig at gcc dot gnu dot org
  2005-06-06 19:14 ` [Bug libfortran/21926] " tkoenig at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-06-05 20:53 UTC (permalink / raw)
  To: gcc-bugs

$ cat matmul.f90
program main
  real, dimension(2,2) :: a
  real, dimension(4,2) :: c
  a = reshape((/ 1.0, 1.0, 0.0, 1.0/), shape(a))
  c = 42.
  c(1:2,1:2) = matmul(a, transpose(a))
  print *,c(1:2,1:2)
  print *,matmul(a, transpose(a))
  print *,c(3:4,1:2)
end
$ gfortran matmul.f90
$ ./a.out
   1.000000       1.000000       43.00000       44.00000
   1.000000       1.000000       1.000000       2.000000
   0.000000       0.000000       42.00000       42.00000
$ gfortran -v
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../gcc-4.1/configure --prefix=/home/ig25 --enable-languages=c,f95
Thread model: posix
gcc version 4.1.0 20050603 (experimental)

The problem is in the zeroing of the result, which assumes
a packed return array.

-- 
           Summary: matmul does not deal with non-packed result
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/21926] matmul does not deal with non-packed result
  2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
@ 2005-06-06 19:14 ` tkoenig at gcc dot gnu dot org
  2005-06-07 20:46 ` cvs-commit at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-06-06 19:14 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tkoenig at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-06-06 19:13:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/21926] matmul does not deal with non-packed result
  2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
  2005-06-06 19:14 ` [Bug libfortran/21926] " tkoenig at gcc dot gnu dot org
@ 2005-06-07 20:46 ` cvs-commit at gcc dot gnu dot org
  2005-06-07 20:53 ` [Bug libfortran/21926] [4.0 only] " tkoenig at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-07 20:46 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-07 20:46 -------
Subject: Bug 21926

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tkoenig@gcc.gnu.org	2005-06-07 20:46:17

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/m4 : matmul.m4 
	libgfortran/generated: matmul_c4.c matmul_c8.c matmul_i4.c 
	                       matmul_i8.c matmul_r4.c matmul_r8.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/gfortran.fortran-torture/execute: 
	                                                intrinsic_matmul.f90 

Log message:
	2005-06-07  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21926
	* m4/matmul.m4:  Correct zeroing of result for non-packed
	arrays with lowest stride is one.
	* generated/matmul_c4.c:  Regenerated.
	* generated/matmul_c8.c:  Regenerated.
	* generated/matmul_i4.c:  Regenerated.
	* generated/matmul_i8.c:  Regenerated.
	* generated/matmul_r4.c:  Regenerated.
	* generated/matmul_r8.c:  Regenerated.
	
	2005-06-07  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21926
	* gfortran.fortran-torture/execute/intrinsic_matmul.f90:
	Test case where the return array has lowest stride one,
	but isn't packed.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.233&r2=1.234
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/matmul.m4.diff?cvsroot=gcc&r1=1.12&r2=1.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_c4.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_c8.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_i4.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_i8.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_r4.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_r8.c.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5607&r2=1.5608
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_matmul.f90.diff?cvsroot=gcc&r1=1.2&r2=1.3



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/21926] [4.0 only] matmul does not deal with non-packed result
  2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
  2005-06-06 19:14 ` [Bug libfortran/21926] " tkoenig at gcc dot gnu dot org
  2005-06-07 20:46 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-07 20:53 ` tkoenig at gcc dot gnu dot org
  2005-07-15 20:47 ` cvs-commit at gcc dot gnu dot org
  2005-07-15 20:49 ` tkoenig at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-06-07 20:53 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-06-07 20:53 -------
Fixed in 4.1, waiting for 4.0 to reopen.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|matmul does not deal with   |[4.0 only] matmul does not
                   |non-packed result           |deal with non-packed result
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/21926] [4.0 only] matmul does not deal with non-packed result
  2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2005-06-07 20:53 ` [Bug libfortran/21926] [4.0 only] " tkoenig at gcc dot gnu dot org
@ 2005-07-15 20:47 ` cvs-commit at gcc dot gnu dot org
  2005-07-15 20:49 ` tkoenig at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-15 20:47 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-15 20:47 -------
Subject: Bug 21926

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tkoenig@gcc.gnu.org	2005-07-15 20:47:40

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/m4 : matmul.m4 
	libgfortran/generated: matmul_c4.c matmul_c8.c matmul_i4.c 
	                       matmul_i8.c matmul_r4.c matmul_r8.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/gfortran.fortran-torture/execute: 
	                                                intrinsic_matmul.f90 
Added files:
	gcc/testsuite/gfortran.dg: matmul_1.f90 

Log message:
	2005-07-15  Thomas Koenig  <Thomas.Koenig@online.de>
	
	Backport from mainline.
	PR libfortran/21926
	PR libfortran/18857
	* m4/matmul.m4:  Correct zeroing of result for non-packed
	arrays with lowest stride is one.
	Remove incorrect assertions (original patch by pault@gcc.gnu.org).
	* generated/matmul_c4.c:  Regenerated.
	* generated/matmul_c8.c:  Regenerated.
	* generated/matmul_i4.c:  Regenerated.
	* generated/matmul_i8.c:  Regenerated.
	* generated/matmul_r4.c:  Regenerated.
	* generated/matmul_r8.c:  Regenerated.
	
	2005-07-15  Thomas Koenig  <Thomas.Koenig@online.de>
	
	Backport from mainline.
	PR libfortran/21926
	PR libfortran/18857
	* gfortran.fortran-torture/execute/intrinsic_matmul.f90:
	Test case where the return array has lowest stride one,
	but isn't packed.
	* gfortran.dg/matmul_1.f90: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.62&r2=1.163.2.63
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/matmul.m4.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_c4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_c8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_i4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_i8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_r4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/matmul_r8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8&r2=1.8.12.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.279&r2=1.5084.2.280
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/matmul_1.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_matmul.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2&r2=1.2.46.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/21926] [4.0 only] matmul does not deal with non-packed result
  2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2005-07-15 20:47 ` cvs-commit at gcc dot gnu dot org
@ 2005-07-15 20:49 ` tkoenig at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-07-15 20:49 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-07-15 20:48 -------
Fixed in 4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21926


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-07-15 20:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-05 20:53 [Bug libfortran/21926] New: matmul does not deal with non-packed result tkoenig at gcc dot gnu dot org
2005-06-06 19:14 ` [Bug libfortran/21926] " tkoenig at gcc dot gnu dot org
2005-06-07 20:46 ` cvs-commit at gcc dot gnu dot org
2005-06-07 20:53 ` [Bug libfortran/21926] [4.0 only] " tkoenig at gcc dot gnu dot org
2005-07-15 20:47 ` cvs-commit at gcc dot gnu dot org
2005-07-15 20:49 ` tkoenig at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).