[Bug middle-end/20297] New: #pragma GCC visibility isn't properly handled for builtin functions

[Bug middle-end/20297] New: #pragma GCC visibility isn't properly handled for builtin functions

[hjl at lucon dot org]

When "#pragma GCC visibility push" is used on builtin functions, it may
not be properly handled if "#pragma GCC visibility pop" is missing.

-- 
           Summary: #pragma GCC visibility isn't properly handled for
                    builtin functions
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2005-03-03 00:05 -------
Created an attachment (id=8315)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8315&action=view)
A testcase

/export/build/gnu/gcc-4.0/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-4.0/build-x86_64-linux/gcc/ -O2 -fPIC	-c -o foo.o
foo.c
/export/build/gnu/gcc-4.0/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-4.0/build-x86_64-linux/gcc/ -o libfoo.so -shared foo.o
foo.o: In function `foo':
foo.c:(.text+0x5): undefined reference to `memcpy'
/usr/local/bin/ld: foo.o: relocation R_X86_64_PC32 against `memcpy' can not be
used when making a shared object; recompile with -fPIC
/usr/local/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status
make: *** [libfoo.so] Error 1

The problem is gcc mishandles

#pragma GCC visibility push(hidden)
#pragma GCC visibility push(default)
typedef long unsigned int size_t;
extern void *memcpy (void *, const void *, size_t);
#pragma GCC visibility pop

and thinks memcpy is hidden. It only happens to builtin functions. When
memcpy is renamed to bar, gcc is OK.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[bugzilla at mdaniel dot scdi dot com]

------- Additional Comments From bugzilla at mdaniel dot scdi dot com  2005-03-03 19:03 -------
In case anyone is curious, this causes the Mozilla HEAD build to fail [at least
with gcc 3.4.3 20050124 and GNU ld 2.15.95 20050302 on x86_64] during link on
two separate occasions, once with nsprpub and once with libmozjs.so. Removing
the use of "#pragma GCC visibility" statements causes the source to build and
link as expected.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-03 19:06 -------
(In reply to comment #2)
> In case anyone is curious, this causes the Mozilla HEAD build to fail [at least
> with gcc 3.4.3 20050124 and GNU ld 2.15.95 20050302 on x86_64] during link on
> two separate occasions, once with nsprpub and once with libmozjs.so. Removing
> the use of "#pragma GCC visibility" statements causes the source to build and
> link as expected.
It cannot be causing a non modified gcc 3.4.3 to fail as 3.4.3 does not include this pragma at all, it is 
only included with 4.0.0 and above.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at mdaniel dot scdi
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2005-03-03 19:11 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2005-03/msg00248.html

FYI, gcc 3.4 from RH does include this pragma.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[bugzilla at mdaniel dot scdi dot com]

------- Additional Comments From bugzilla at mdaniel dot scdi dot com  2005-03-03 19:19 -------
$ gcc --version
gcc (GCC) 3.4.3 20050124 (Red Hat 3.4.3-17)

I stand corrected, Fedora Core 3 must be back-porting some of that
functionality. Should I open a bug with them pointing to this, or is it just
water under the bridge now?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2005-03-03 19:25 -------
RH bug is at

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=150157

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[matz at suse dot de]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[pluto at agmk dot net]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pluto at agmk dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[pluto at agmk dot net]

------- Additional Comments From pluto at agmk dot net  2005-05-26 14:40 -------
(In reply to comment #4) 
> A patch is posted at 
>  
> http://gcc.gnu.org/ml/gcc-patches/2005-03/msg00248.html 
>  
> FYI, gcc 3.4 from RH does include this pragma. 
 
this patch ices gcc-4.1-20050522 bootstrap. 
 
../../gcc/libgcc2.c: In function '__absvsi2':  
../../gcc/libgcc2.c:215: internal compiler error: tree check: expected class 
'declaration', have 'expression' (call_expr) in expand_builtin, at  
builtins.c:6260  
 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[matz at suse dot de]

------- Additional Comments From matz at suse dot de  2005-06-06 07:48 -------
Created an attachment (id=9035)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9035&action=view)
New patch

This fixes a problem in HJs patch (which doesn't look at the fndecl
of the builtin, but at the call_expr).

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[benjamin at smedbergs dot us]

------- Additional Comments From benjamin at smedbergs dot us  2005-09-09 20:51 -------
I can confirm that attachment 9035 fixes the mozilla compile issues with GCC
4.0/4.0.1/trunk.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin at smedbergs dot us


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[benjamin at smedbergs dot us]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #9720 is|1                           |0
              patch|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[benjamin at smedbergs dot us]

------- Additional Comments From benjamin at smedbergs dot us  2005-09-13 16:34 -------
Created an attachment (id=9720)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9720&action=view)
Failure even with the latest patch

I'm wrong. attachment 9035 fixes the compile errors in the main mozilla tree,
but does not fix the errors in NSPR. Attached is the preprocessed source that's
failing. This was compiled with

 -pipe -ansi -Wall -pthread -g -fno-inline -fPIC

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[simon dot strandman at telia dot com]

------- Comment #11 from simon dot strandman at telia dot com  2005-10-18 12:21 -------
I'm using gcc 4.0.2 with patches for gcc pr19664, pr20297 and pr19520. The
testcase from this bug passes without problems. Still firefox beta2 and current
CVS fails to build. I talked to the mozilla guys and they asked me to report it
here. Any ideas what might be wrong?

x86_64-pc-linux-gnu-gcc -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\"   -W
-Wno-unused
-Wpointer-arith -Wcast-align -Wno-long-long -march=athlon64 -pipe -fPIC
-Wno-return-type -w -pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -Os
-fPIC -shared -Wl,-h -Wl,libmozjs.so -Wl,-R/usr/lib64/mozilla-firefox -o
libmozjs.so  jsapi.o jsarena.o jsarray.o jsatom.o jsbool.o jscntxt.o jsdate.o
jsdbgapi.o jsdhash.o jsdtoa.o jsemit.o jsexn.o jsfun.o jsgc.o jshash.o
jsinterp.o jslock.o jslog2.o jslong.o jsmath.o jsnum.o jsobj.o jsopcode.o
jsparse.o jsprf.o jsregexp.o jsscan.o jsscope.o jsscript.o jsstr.o jsutil.o
jsxdrapi.o jsxml.o prmjtime.o    -Wl,-O1  -Wl,-R/usr/lib64/mozilla-firefox  
-lm
-ldl -L../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -ldl -lm
/usr/lib/gcc/x86_64-pc-linux-gnu/4.0.2/../../../../x86_64-pc-linux-gnu/bin/ld:
warning: creating a DT_TEXTREL in object.
/usr/lib/gcc/x86_64-pc-linux-gnu/4.0.2/../../../../x86_64-pc-linux-gnu/bin/ld:
jsapi.o: relocation R_X86_64_PC32 against `memcpy@@GLIBC_2.2.5' can not be used
when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-pc-linux-gnu/4.0.2/../../../../x86_64-pc-linux-gnu/bin/ld:
final link failed: Bad value
collect2: ld returned 1 exit status
gmake[3]: *** [libmozjs.so] Error 1
gmake[3]: Leaving directory
`/var/tmp/portage/mozilla-firefox-9999/work/mozilla/js/src'
gmake[2]: *** [libs] Error 2
gmake[2]: Leaving directory
`/var/tmp/portage/mozilla-firefox-9999/work/mozilla/js'
gmake[1]: *** [tier_2] Error 2
gmake[1]: Leaving directory
`/var/tmp/portage/mozilla-firefox-9999/work/mozilla'
make: *** [default] Error 2

The 9999 version means that it's a CVS build in gentoo.

Binutils is version 2.16.1 and glibc is 2.3.5.


-- 

simon dot strandman at telia dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon dot strandman at telia
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[zac at zacbowling dot com]

------- Comment #12 from zac at zacbowling dot com  2005-12-05 05:38 -------
I'm not sure, but I'm getting this bug as well, but it maybe out of date. 

On the last part about the mozilla bail out, if you add this to your mozconfig
it might get it to build correctly.

ac_cv_visibility_pragma=no


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[bero at arklinux dot org]

------- Comment #13 from bero at arklinux dot org  2006-01-27 12:24 -------
Still seeing this problem w/ current 4.1 branch


-- 

bero at arklinux dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bero at arklinux dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jason at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-03-22 03:33:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #14 from jason at gcc dot gnu dot org  2006-03-22 04:20 -------
Subject: Bug 20297

Author: jason
Date: Wed Mar 22 04:20:52 2006
New Revision: 112270

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112270
Log:
        PR middle-end/20297
        * expr.c (init_block_move_fn): Force default visibility.
        (init_block_clear_fn): Likewise.
        * builtins.c (expand_builtin_fork_or_exec): Likewise.
        * targhooks.c (default_external_stack_protect_fail): Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/visibility-11.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c
    trunk/gcc/expr.c
    trunk/gcc/targhooks.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #15 from jason at gcc dot gnu dot org  2006-03-22 04:22 -------
Subject: Bug 20297

Author: jason
Date: Wed Mar 22 04:22:40 2006
New Revision: 112271

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112271
Log:
        PR middle-end/20297
        * expr.c (init_block_move_fn): Force default visibility.
        (init_block_clear_fn): Likewise.
        * builtins.c (expand_builtin_fork_or_exec): Likewise.
        * targhooks.c (default_external_stack_protect_fail): Likewise.

Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/builtins.c
    branches/gcc-4_1-branch/gcc/expr.c
    branches/gcc-4_1-branch/gcc/targhooks.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #16 from jason at gcc dot gnu dot org  2006-03-22 04:23 -------
Subject: Bug 20297

Author: jason
Date: Wed Mar 22 04:23:10 2006
New Revision: 112272

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112272
Log:
        PR middle-end/20297
        * expr.c (init_block_move_fn): Force default visibility.
        (init_block_clear_fn): Likewise.
        * builtins.c (expand_builtin_fork_or_exec): Likewise.
        * targhooks.c (default_external_stack_protect_fail): Likewise.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/visibility-11.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #17 from jason at gcc dot gnu dot org  2006-03-22 04:50 -------
Subject: Bug 20297

Author: jason
Date: Wed Mar 22 04:50:31 2006
New Revision: 112273

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112273
Log:
        PR middle-end/20297
        * expr.c (init_block_move_fn): Force default visibility.
        (init_block_clear_fn): Likewise.
        * builtins.c (expand_builtin_fork_or_exec): Likewise.

Modified:
    branches/gcc-4_0-branch/gcc/ChangeLog
    branches/gcc-4_0-branch/gcc/builtins.c
    branches/gcc-4_0-branch/gcc/expr.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #18 from jason at gcc dot gnu dot org  2006-03-22 04:55 -------
Subject: Bug 20297

Author: jason
Date: Wed Mar 22 04:55:18 2006
New Revision: 112274

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112274
Log:
        PR middle-end/20297
        * expr.c (init_block_move_fn): Force default visibility.
        (init_block_clear_fn): Likewise.

Modified:
    branches/redhat/gcc-3_4-branch/gcc/ChangeLog
    branches/redhat/gcc-3_4-branch/gcc/expr.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297

[Bug middle-end/20297] #pragma GCC visibility isn't properly handled for builtin functions

[jason at gcc dot gnu dot org]

------- Comment #19 from jason at gcc dot gnu dot org  2006-06-23 01:05 -------
fixed a while back


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20297