public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/22038] New: Forall with mask broken
@ 2005-06-12 15:40 tobi at gcc dot gnu dot org
2005-06-12 15:43 ` [Bug fortran/22038] " tobi at gcc dot gnu dot org
` (5 more replies)
0 siblings, 6 replies; 14+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-06-12 15:40 UTC (permalink / raw)
To: gcc-bugs
This is why gfortran.dg/forall_1.f90 is XFAILed.
--
Summary: Forall with mask broken
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P2
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tobi at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org,jakub at redhat dot
com,pbrook at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
@ 2005-06-12 15:43 ` tobi at gcc dot gnu dot org
2005-06-12 15:50 ` tobi at gcc dot gnu dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-06-12 15:43 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-06-12 15:43 -------
Discussed in this thread: http://gcc.gnu.org/ml/fortran/2005-06/msg00101.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
2005-06-12 15:43 ` [Bug fortran/22038] " tobi at gcc dot gnu dot org
@ 2005-06-12 15:50 ` tobi at gcc dot gnu dot org
2005-06-12 15:51 ` pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-06-12 15:50 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-06-12 15:50 -------
A patch which fixes the testcase is here:
http://gcc.gnu.org/ml/fortran/2005-06/msg00138.html
Further fixes to FORALL here:
http://gcc.gnu.org/ml/fortran/2005-06/msg00166.html
--
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/fortra
| |n/2005-06/msg00138.html
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
2005-06-12 15:43 ` [Bug fortran/22038] " tobi at gcc dot gnu dot org
2005-06-12 15:50 ` tobi at gcc dot gnu dot org
@ 2005-06-12 15:51 ` pinskia at gcc dot gnu dot org
2005-06-13 18:24 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-12 15:51 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-06-12 15:51:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
` (2 preceding siblings ...)
2005-06-12 15:51 ` pinskia at gcc dot gnu dot org
@ 2005-06-13 18:24 ` cvs-commit at gcc dot gnu dot org
2005-06-13 18:30 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:02 ` tobi at gcc dot gnu dot org
5 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-13 18:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-13 18:23 -------
Subject: Bug 22038
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: tobi@gcc.gnu.org 2005-06-13 18:23:46
Modified files:
gcc/fortran : ChangeLog trans-stmt.c
gcc/testsuite : ChangeLog
gcc/testsuite/gfortran.dg: forall_1.f90
Log message:
fortran/
2005-06-13 Jakub Jelinek <jakub@redhat.com>
PR fortran/22038
* trans-stmt.c (gfc_trans_forall_loop): Only increment maskindex
in the innermost loop.
testsuite/
2005-06-13 Tobias Schl"uter <tobias.schlueter@physik.uni-muenchen.de>
PR fortran/22038
* gfortran.dg/forall_1.f90: Un-XFAIL.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.462&r2=1.463
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-stmt.c.diff?cvsroot=gcc&r1=1.34&r2=1.35
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5632&r2=1.5633
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/forall_1.f90.diff?cvsroot=gcc&r1=1.3&r2=1.4
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
` (3 preceding siblings ...)
2005-06-13 18:24 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-13 18:30 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:02 ` tobi at gcc dot gnu dot org
5 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-13 18:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-13 18:30 -------
Subject: Bug 22038
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: tobi@gcc.gnu.org 2005-06-13 18:30:15
Modified files:
gcc/fortran : ChangeLog trans-stmt.c
Log message:
2005-06-13 Jakub Jelinek <jakub@redhat.com>
PR fortran/22038
* trans-stmt.c (gfc_trans_forall_loop): Only increment maskindex
in the innermost loop.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.335.2.71&r2=1.335.2.72
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-stmt.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.24.6.4&r2=1.24.6.5
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
` (4 preceding siblings ...)
2005-06-13 18:30 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-13 19:02 ` tobi at gcc dot gnu dot org
5 siblings, 0 replies; 14+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-06-13 19:02 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-06-13 19:02 -------
The commit fixes only a small part of the issues, namely those which made
gfortran.dg/forall_1.f90 fail. There remain several issues as explained here
together with a patch for some of them:
http://gcc.gnu.org/ml/fortran/2005-06/msg00166.html
--
What |Removed |Added
----------------------------------------------------------------------------
URL|http://gcc.gnu.org/ml/fortra|
|n/2005-06/msg00138.html |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2006-06-25 18:13 ` pault at gcc dot gnu dot org
@ 2006-06-29 21:42 ` patchapp at dberlin dot org
6 siblings, 0 replies; 14+ messages in thread
From: patchapp at dberlin dot org @ 2006-06-29 21:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from patchapp at dberlin dot org 2006-06-29 21:41 -------
Subject: Bug number PR22038
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-06/msg01238.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2006-06-25 18:10 ` pault at gcc dot gnu dot org
@ 2006-06-25 18:13 ` pault at gcc dot gnu dot org
2006-06-29 21:42 ` patchapp at dberlin dot org
6 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-06-25 18:13 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pault at gcc dot gnu dot org 2006-06-25 18:12 -------
Fixed on trunk and 4.1
Paul
--
pault at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2006-06-25 15:12 ` pault at gcc dot gnu dot org
@ 2006-06-25 18:10 ` pault at gcc dot gnu dot org
2006-06-25 18:13 ` pault at gcc dot gnu dot org
2006-06-29 21:42 ` patchapp at dberlin dot org
6 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-06-25 18:10 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from pault at gcc dot gnu dot org 2006-06-25 18:08 -------
Subject: Bug 22038
Author: pault
Date: Sun Jun 25 18:08:13 2006
New Revision: 114994
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114994
Log:
2006-06-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/25056
* interface.c (compare_actual_formal): Signal an error if the formal
argument is a pure procedure and the actual is not pure.
PR fortran/27554
* resolve.c (resolve_actual_arglist): If the type of procedure
passed as an actual argument is not already declared, see if it is
an intrinsic.
PR fortran/25073
* resolve.c (resolve_select): Use bits 1 and 2 of a new int to
keep track of the appearance of constant logical case expressions.
Signal an error is either value appears more than once.
PR fortran/20874
* resolve.c (resolve_fl_procedure): Signal an error if an elemental
function is not scalar valued.
PR fortran/20867
* match.c (recursive_stmt_fcn): Perform implicit typing of variables.
PR fortran/22038
* match.c (match_forall_iterator): Mark new variables as
FL_UNKNOWN if the match fails.
PR fortran/28119
* match.c (gfc_match_forall): Remove extraneous call to
gfc_match_eos.
PR fortran/25072
* resolve.c (resolve_code, resolve_function): Rework
forall_flag scheme so that it is set and has a value of
2, when the code->expr (ie. the forall mask) is resolved.
This is used to change "block" to "mask" in the non-PURE
error message.
2006-06-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/20867
* gfortran.dg/stfunc_3.f90: New test.
PR fortran/25056
* gfortran.dg/impure_actual_1.f90: New test.
PR fortran/20874
* gfortran.dg/elemental_result_1.f90: New test.
PR fortran/25073
* gfortran.dg/select_7.f90: New test.
PR fortran/27554
* intrinsic_actual_1.f: New test.
PR fortran/22038
PR fortran/28119
* gfortran.dg/forall_4.f90: New test.
PR fortran/25072
* gfortran.dg/forall_5.f90: New test.
Added:
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/elemental_result_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/forall_4.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/forall_5.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/impure_actual_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/intrinsic_actual_1.f
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/select_7.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/stfunc_3.f90
Modified:
branches/gcc-4_1-branch/gcc/fortran/ChangeLog
branches/gcc-4_1-branch/gcc/fortran/interface.c
branches/gcc-4_1-branch/gcc/fortran/match.c
branches/gcc-4_1-branch/gcc/fortran/resolve.c
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2006-03-09 0:34 ` pinskia at gcc dot gnu dot org
@ 2006-06-25 15:12 ` pault at gcc dot gnu dot org
2006-06-25 18:10 ` pault at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-06-25 15:12 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pault at gcc dot gnu dot org 2006-06-25 15:11 -------
Subject: Bug 22038
Author: pault
Date: Sun Jun 25 15:11:02 2006
New Revision: 114987
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114987
Log:
2006-06-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/25056
* interface.c (compare_actual_formal): Signal an error if the formal
argument is a pure procedure and the actual is not pure.
PR fortran/27554
* resolve.c (resolve_actual_arglist): If the type of procedure
passed as an actual argument is not already declared, see if it is
an intrinsic.
PR fortran/25073
* resolve.c (resolve_select): Use bits 1 and 2 of a new int to
keep track of the appearance of constant logical case expressions.
Signal an error is either value appears more than once.
PR fortran/20874
* resolve.c (resolve_fl_procedure): Signal an error if an elemental
function is not scalar valued.
PR fortran/20867
* match.c (recursive_stmt_fcn): Perform implicit typing of variables.
PR fortran/22038
* match.c (match_forall_iterator): Mark new variables as
FL_UNKNOWN if the match fails.
PR fortran/28119
* match.c (gfc_match_forall): Remove extraneous call to
gfc_match_eos.
PR fortran/25072
* resolve.c (resolve_code, resolve_function): Rework
forall_flag scheme so that it is set and has a value of
2, when the code->expr (ie. the forall mask) is resolved.
This is used to change "block" to "mask" in the non-PURE
error message.
2006-06-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/20867
* gfortran.dg/stfunc_3.f90: New test.
PR fortran/25056
* gfortran.dg/impure_actual_1.f90: New test.
PR fortran/20874
* gfortran.dg/elemental_result_1.f90: New test.
PR fortran/25073
* gfortran.dg/select_7.f90: New test.
PR fortran/27554
* intrinsic_actual_1.f: New test.
PR fortran/22038
PR fortran/28119
* gfortran.dg/forall_4.f90: New test.
PR fortran/25072
* gfortran.dg/forall_5.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/elemental_result_1.f90
trunk/gcc/testsuite/gfortran.dg/forall_4.f90
trunk/gcc/testsuite/gfortran.dg/forall_5.f90
trunk/gcc/testsuite/gfortran.dg/impure_actual_1.f90
trunk/gcc/testsuite/gfortran.dg/intrinsic_actual_1.f
trunk/gcc/testsuite/gfortran.dg/select_7.f90
trunk/gcc/testsuite/gfortran.dg/stfunc_3.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/interface.c
trunk/gcc/fortran/match.c
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
2006-03-06 20:33 ` pault at gcc dot gnu dot org
2006-03-06 20:44 ` jakub at gcc dot gnu dot org
@ 2006-03-09 0:34 ` pinskia at gcc dot gnu dot org
2006-06-25 15:12 ` pault at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-09 0:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pinskia at gcc dot gnu dot org 2006-03-09 00:34 -------
Reopening since the testcase has been xfailed IIRC.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Keywords| |xfail
Resolution|FIXED |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
2006-03-06 20:33 ` pault at gcc dot gnu dot org
@ 2006-03-06 20:44 ` jakub at gcc dot gnu dot org
2006-03-09 0:34 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-03-06 20:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from jakub at gcc dot gnu dot org 2006-03-06 20:44 -------
Are you sure? forall_8.f90 testcase still fails for me with gfortran
as of a few days ago.
If the problem is fixed and the testcases aren't invalid, they should be
added to the testsuite, otherwise this needs to be reopened.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/22038] Forall with mask broken
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
@ 2006-03-06 20:33 ` pault at gcc dot gnu dot org
2006-03-06 20:44 ` jakub at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-03-06 20:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from pault at gcc dot gnu dot org 2006-03-06 20:33 -------
This one was fixed a long time since but does not seem to have been cleared.
The recent flurry of activity on the dependency checking has made keeping it
open unnecessary IMHO.
Paul
--
pault at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22038
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2006-06-29 21:41 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-12 15:40 [Bug fortran/22038] New: Forall with mask broken tobi at gcc dot gnu dot org
2005-06-12 15:43 ` [Bug fortran/22038] " tobi at gcc dot gnu dot org
2005-06-12 15:50 ` tobi at gcc dot gnu dot org
2005-06-12 15:51 ` pinskia at gcc dot gnu dot org
2005-06-13 18:24 ` cvs-commit at gcc dot gnu dot org
2005-06-13 18:30 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:02 ` tobi at gcc dot gnu dot org
[not found] <bug-22038-8513@http.gcc.gnu.org/bugzilla/>
2006-03-06 20:33 ` pault at gcc dot gnu dot org
2006-03-06 20:44 ` jakub at gcc dot gnu dot org
2006-03-09 0:34 ` pinskia at gcc dot gnu dot org
2006-06-25 15:12 ` pault at gcc dot gnu dot org
2006-06-25 18:10 ` pault at gcc dot gnu dot org
2006-06-25 18:13 ` pault at gcc dot gnu dot org
2006-06-29 21:42 ` patchapp at dberlin dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).