public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/21333] New: in_pack / in_unpack alignment issues
@ 2005-05-02 11:28 tkoenig at gcc dot gnu dot org
  2005-05-11 21:32 ` [Bug libfortran/21333] " tobi at gcc dot gnu dot org
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-02 11:28 UTC (permalink / raw)
  To: gcc-bugs

I don't have the machines to test this on, but I think
there is a chance of an alignment issue with in_pack / in_unpack.

Look at the following program:

program main
  complex a(5),b(5)
  equivalence(a(1),r(1)),(b(1),r(12))
  real r(100)
  a = (1.0, -1.0)
  b = (2.0, -2.0)
  call foo(a(5:1:-1),5)
  call foo(b(5:1:-1),5)
end program main

subroutine foo(arr,n)
  complex, dimension(n) :: a
end subroutine foo

The equivalence makes sure that a and b cannot both be
aligned on an 8-byte-boundary.

The array reference gets repacked for both calls to foo:

    parm.2.dtype = 545;
    parm.2.dim[0].lbound = 1;
    parm.2.dim[0].ubound = 5;
    parm.2.dim[0].stride = -1;
    parm.2.data = (complex4[0:] *) (complex4[0:] *) &equiv.0.a[4];
    parm.2.offset = 0;
    D.529 = _gfortran_internal_pack (&parm.2);
    foo (D.529, &C.530);
    if (D.529 != parm.2.data)
      {
        _gfortran_internal_unpack (&parm.2, D.529);
        _gfortran_internal_free (D.529);
      }

internal_pack_generic has the following code:

  size = GFC_DESCRIPTOR_SIZE (source);
  switch (size)
    {
    case 4:
      return internal_pack_4 ((gfc_array_i4 *)source);

    case 8:
      return internal_pack_8 ((gfc_array_i8 *)source);
    }

so internal_pack_8 is called.

This operates on a gfc_array_i8.

On machines where you can only align an i8 on an eight-byte-boundary,
this will fail.

I'd appreciate if somebody could run the test program on such a
machine, to see wehter I got this right :-)

Thomas

-- 
           Summary: in_pack / in_unpack alignment issues
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
@ 2005-05-11 21:32 ` tobi at gcc dot gnu dot org
  2005-05-11 21:58 ` tobi at gcc dot gnu dot org
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-05-11 21:32 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tobi at gcc dot gnu dot org  2005-05-11 21:32 -------
You're a nasty person. Very intriguing. Unfortunately, I can't test this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
  2005-05-11 21:32 ` [Bug libfortran/21333] " tobi at gcc dot gnu dot org
@ 2005-05-11 21:58 ` tobi at gcc dot gnu dot org
  2005-05-11 22:40 ` steven at gcc dot gnu dot org
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-05-11 21:58 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tobi at gcc dot gnu dot org  2005-05-11 21:58 -------
This is a real bug, but I can't confirm it since I can't test it.  In other
words, EQUIVALENCE means that we always have to assume the smaller alignment for
complex types (unless we can prove they're correctly aligned).  How sad.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
  2005-05-11 21:32 ` [Bug libfortran/21333] " tobi at gcc dot gnu dot org
  2005-05-11 21:58 ` tobi at gcc dot gnu dot org
@ 2005-05-11 22:40 ` steven at gcc dot gnu dot org
  2005-05-17 13:25 ` tkoenig at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-05-11 22:40 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From steven at gcc dot gnu dot org  2005-05-11 22:40 -------
Output on ia64: 
a.out(31029): unaligned access to 0x60000fffffffafbc, ip=0x400000000000aaa0 
a.out(31029): unaligned access to 0x60000fffffffafb4, ip=0x400000000000aaa0 
a.out(31029): unaligned access to 0x60000fffffffafac, ip=0x400000000000aaa0 
a.out(31029): unaligned access to 0x60000fffffffafa4, ip=0x400000000000aaa0 
 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-11 22:40:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2005-05-11 22:40 ` steven at gcc dot gnu dot org
@ 2005-05-17 13:25 ` tkoenig at gcc dot gnu dot org
  2005-05-24 22:46 ` tkoenig at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-17 13:25 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-17 13:25 -------
For ia-64, this can be exposed with prctl:

$ gfortran packtest.f90
$ prctl --unaligned=signal gdb ./a.out
GNU gdb Red Hat Linux (6.1post-1.20040607.52rh)
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "ia64-redhat-linux-gnu"...Using host libthread_db 
library "/lib/tls/libthread_db.so.1".

(gdb) r
Starting program: /home/zfkts/Krempel/a.out

Program received signal SIGBUS, Bus error.
*_gfortrani_internal_pack_8 (source=Variable "source" is not available.
)
    at ../../../gcc-4.1-20050515/libgfortran/generated/in_pack_i8.c:94
94            *(dest++) = *src;

Any way to include prctl in the test suite machinery if it can be found?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2005-05-17 13:25 ` tkoenig at gcc dot gnu dot org
@ 2005-05-24 22:46 ` tkoenig at gcc dot gnu dot org
  2005-06-02 15:49 ` tkoenig at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-24 22:46 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-05-24 22:40 -------
For 4-byte complex, an option is to check the alignment at runtime.
If the complex is aligned on an 8-byte boundary, it should be
perfectly OK to call the 8-byte-integer routines.

The check could be done with a macro like this:

#define GFC_ALIGNMENT_I8(a) (((size_t) (a)) & 7 == 0)
#define GFC_ALIGNMENT_I4(a) (((size_t) (a)) & 3 == 0)

and the code look like

if (size == 8)
{
    if (GFC_ALIGNMENT_I8(ptr))
        return internal_pack_8(whatever)
    else if (GFC_ALIGNMENT_I4(ptr))
        return internal_pack_c4(whatever)

    /* Fall through to generic routine */
}

OK in principle?  Too horrible to contemplate?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2005-05-24 22:46 ` tkoenig at gcc dot gnu dot org
@ 2005-06-02 15:49 ` tkoenig at gcc dot gnu dot org
  2005-06-11 19:39 ` cvs-commit at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-06-02 15:49 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-06-02 15:49 -------
Created an attachment (id=9014)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9014&action=view)
Proposed patch


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tkoenig at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2005-06-02 15:49 ` tkoenig at gcc dot gnu dot org
@ 2005-06-11 19:39 ` cvs-commit at gcc dot gnu dot org
  2005-06-11 20:19 ` [Bug libfortran/21333] [4.0 only] " tkoenig at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-11 19:39 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-11 19:39 -------
Subject: Bug 21333

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tkoenig@gcc.gnu.org	2005-06-11 19:39:13

Modified files:
	libgfortran    : Makefile.in Makefile.am libgfortran.h 
	libgfortran/m4 : in_pack.m4 in_unpack.m4 
	libgfortran/runtime: in_pack_generic.c in_unpack_generic.c 
	libgfortran/generated: in_pack_i4.c in_pack_i8.c in_unpack_i4.c 
	                       in_unpack_i8.c 
	gcc/testsuite  : ChangeLog 
Added files:
	libgfortran/generated: in_pack_c4.c in_pack_c8.c in_unpack_c4.c 
	                       in_unpack_c8.c 
	gcc/testsuite/gfortran.fortran-torture/execute: in-pack.f90 

Log message:
	2005-06-11  Thomas Koenig  <Thomas.Koenig@onlinde.de>
	
	PR libfortran/21333
	* Makefile.am: Add in_pack_c4.c, in_pack_c8.c, in_unpack_c4.c
	and in_unpack_c8.c.
	* Makefile.in: Regenerate.
	* libgfortran.h:  Declare internal_pack_c4, internal_pack_c8,
	internal_unpack_c4 and internal_unpack_c8.
	* m4/in_pack.m4: Use rtype_ccode insteald of rtype_kind
	in function name.
	Use sizeof (rtype_name) as size for memory allocation.
	* m4/in_unpack.m4: Use rtype_ccode insteald of rtype_kind
	in function name.
	Use sizeof (rtype_name) for calculation of sizes for memcpy.
	* runtime/in_pack_generic.c:  For real, integer and logical
	call internal_pack_4 if size==4 and internal_pack_8 if
	size==8.
	For complex, call internal_pack_c4 if size==8 and
	internal_pack_c8 if size==16.
	* runtime/in_unpack_generic.c: For real, integer and logical
	call internal_unpack_4 if size==4 and internal_unpack_8 if
	size==8.
	For complex, call internal_unpack_c4 if size==8 and
	internal_unpack_c8 if size==16.
	* generated/in_pack_i4.c:  Regenerated.
	* generated/in_pack_i8.c:  Regenerated.
	* generated/in_unpack_i4.c:  Regenerated.
	* generated/in_unpack_i8.c:  Regenerated.
	* generated/in_pack_c4.c:  New file.
	* generated/in_pack_c8.c:  New file.
	* generated/in_unpack_c4.c:  New file.
	* generated/in_unpack_c8.c:  New file.
	
	2005-05-11  Thomas Koenig  <Thomas.Koenig@online.de>
	
	* gfortran.fortran-torture/execute/in-pack.f90:  New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.in.diff?cvsroot=gcc&r1=1.36&r2=1.37
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.am.diff?cvsroot=gcc&r1=1.35&r2=1.36
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/libgfortran.h.diff?cvsroot=gcc&r1=1.24&r2=1.25
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/in_pack.m4.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/in_unpack.m4.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/in_pack_generic.c.diff?cvsroot=gcc&r1=1.6&r2=1.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/in_unpack_generic.c.diff?cvsroot=gcc&r1=1.6&r2=1.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_c4.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_c8.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_c4.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_c8.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_i4.c.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_i8.c.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_i4.c.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_i8.c.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5621&r2=1.5622
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/in-pack.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] [4.0 only] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2005-06-11 19:39 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-11 20:19 ` tkoenig at gcc dot gnu dot org
  2005-06-12 20:28 ` cvs-commit at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-06-11 20:19 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-06-11 20:19 -------
Fixed in 4.1, waiting for 4.0 to reopen.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.0.1
      Known to work|                            |4.1.0
            Summary|in_pack / in_unpack         |[4.0 only] in_pack /
                   |alignment issues            |in_unpack alignment issues
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] [4.0 only] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2005-06-11 20:19 ` [Bug libfortran/21333] [4.0 only] " tkoenig at gcc dot gnu dot org
@ 2005-06-12 20:28 ` cvs-commit at gcc dot gnu dot org
  2005-07-18 17:41 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-12 20:28 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-12 20:28 -------
Subject: Bug 21333

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tkoenig@gcc.gnu.org	2005-06-12 20:27:59

Modified files:
	libgfortran    : ChangeLog 

Log message:
	2005-06-12  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21333
	* Changelog: Really update.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.236&r2=1.237



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] [4.0 only] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2005-06-12 20:28 ` cvs-commit at gcc dot gnu dot org
@ 2005-07-18 17:41 ` cvs-commit at gcc dot gnu dot org
  2005-07-18 18:03 ` tkoenig at gcc dot gnu dot org
  2005-07-19 17:49 ` cvs-commit at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-18 17:41 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-18 17:41 -------
Subject: Bug 21333

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tkoenig@gcc.gnu.org	2005-07-18 17:40:51

Modified files:
	libgfortran    : Makefile.in Makefile.am libgfortran.h 
	libgfortran/m4 : in_pack.m4 in_unpack.m4 
	libgfortran/runtime: in_pack_generic.c in_unpack_generic.c 
	libgfortran/generated: in_pack_i4.c in_pack_i8.c in_unpack_i4.c 
	                       in_unpack_i8.c 
	gcc/testsuite  : ChangeLog 
Added files:
	libgfortran/generated: in_pack_c4.c in_pack_c8.c in_unpack_c4.c 
	                       in_unpack_c8.c 
	gcc/testsuite/gfortran.fortran-torture/execute: in-pack.f90 

Log message:
	2005-07-18  Thomas Koenig  <Thomas.Koenig@onlinde.de>
	
	Backport from mainline.
	PR libfortran/21333
	* Makefile.am: Add in_pack_c4.c, in_pack_c8.c, in_unpack_c4.c
	and in_unpack_c8.c.
	* Makefile.in: Regenerate.
	* libgfortran.h:  Declare internal_pack_c4, internal_pack_c8,
	internal_unpack_c4 and internal_unpack_c8.
	* m4/in_pack.m4: Use rtype_ccode insteald of rtype_kind
	in function name.
	Use sizeof (rtype_name) as size for memory allocation.
	* m4/in_unpack.m4: Use rtype_ccode insteald of rtype_kind
	in function name.
	Use sizeof (rtype_name) for calculation of sizes for memcpy.
	* runtime/in_pack_generic.c:  For real, integer and logical
	call internal_pack_4 if size==4 and internal_pack_8 if
	size==8.
	For complex, call internal_pack_c4 if size==8 and
	internal_pack_c8 if size==16.
	* runtime/in_unpack_generic.c: For real, integer and logical
	call internal_unpack_4 if size==4 and internal_unpack_8 if
	size==8.
	For complex, call internal_unpack_c4 if size==8 and
	internal_unpack_c8 if size==16.
	* generated/in_pack_i4.c:  Regenerated.
	* generated/in_pack_i8.c:  Regenerated.
	* generated/in_unpack_i4.c:  Regenerated.
	* generated/in_unpack_i8.c:  Regenerated.
	* generated/in_pack_c4.c:  New file.
	* generated/in_pack_c8.c:  New file.
	* generated/in_unpack_c4.c:  New file.
	* generated/in_unpack_c8.c:  New file.
	
	2005-07-18  Thomas Koenig  <Thomas.Koenig@online.de>
	
	Backport from mainline.
	PR libfortran/21333
	* gfortran.fortran-torture/execute/in-pack.f90:  New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.in.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.30.10.5&r2=1.30.10.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.am.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.29.10.5&r2=1.29.10.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/libgfortran.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.23.8.1&r2=1.23.8.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/in_pack.m4.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4.12.1&r2=1.4.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/m4/in_unpack.m4.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4.12.1&r2=1.4.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/in_pack_generic.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5.12.1&r2=1.5.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/in_unpack_generic.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5.12.1&r2=1.5.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_c4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_c8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_c4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_c8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_i4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4.12.1&r2=1.4.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_pack_i8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4.12.1&r2=1.4.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_i4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3.12.1&r2=1.3.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/generated/in_unpack_i8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3.12.1&r2=1.3.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.286&r2=1.5084.2.287
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/in-pack.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.8.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] [4.0 only] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2005-07-18 17:41 ` cvs-commit at gcc dot gnu dot org
@ 2005-07-18 18:03 ` tkoenig at gcc dot gnu dot org
  2005-07-19 17:49 ` cvs-commit at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-07-18 18:03 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-07-18 17:41 -------
Fixed in 4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug libfortran/21333] [4.0 only] in_pack / in_unpack alignment issues
  2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
                   ` (10 preceding siblings ...)
  2005-07-18 18:03 ` tkoenig at gcc dot gnu dot org
@ 2005-07-19 17:49 ` cvs-commit at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-19 17:49 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-19 17:47 -------
Subject: Bug 21333

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tkoenig@gcc.gnu.org	2005-07-19 17:47:32

Modified files:
	libgfortran    : ChangeLog 

Log message:
	2005-07-19  Thomas Koenig  <Thomas.Koenig@online.de>
	
	PR libfortran/21333
	Add forgotten commit to ChangeLog.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.65&r2=1.163.2.66



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21333


^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2005-07-19 17:47 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-02 11:28 [Bug libfortran/21333] New: in_pack / in_unpack alignment issues tkoenig at gcc dot gnu dot org
2005-05-11 21:32 ` [Bug libfortran/21333] " tobi at gcc dot gnu dot org
2005-05-11 21:58 ` tobi at gcc dot gnu dot org
2005-05-11 22:40 ` steven at gcc dot gnu dot org
2005-05-17 13:25 ` tkoenig at gcc dot gnu dot org
2005-05-24 22:46 ` tkoenig at gcc dot gnu dot org
2005-06-02 15:49 ` tkoenig at gcc dot gnu dot org
2005-06-11 19:39 ` cvs-commit at gcc dot gnu dot org
2005-06-11 20:19 ` [Bug libfortran/21333] [4.0 only] " tkoenig at gcc dot gnu dot org
2005-06-12 20:28 ` cvs-commit at gcc dot gnu dot org
2005-07-18 17:41 ` cvs-commit at gcc dot gnu dot org
2005-07-18 18:03 ` tkoenig at gcc dot gnu dot org
2005-07-19 17:49 ` cvs-commit at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).