[Bug libstdc++/22205] New: extra testsuite errors with -fno-weak vs. debug mode

[Bug libstdc++/22205] New: extra testsuite errors with -fno-weak vs. debug mode

[bkoz at gcc dot gnu dot org]

On systems without weak, debug mode tests will fail. This causes some
unpleasantness on AIX, for instance.

This can be verified on x86/linux using -fno-weak.

What needs to happen is that the debug mode tests should be smart enough to tell
if the underlying system doesn't support weak, so that the test case cannot be
run. There are several other things that work like this ("C" locale, etc) so
adding one more shouldn't be a big deal.

-- 
           Summary: extra testsuite errors with -fno-weak vs. debug mode
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bkoz at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] extra testsuite errors with -fno-weak vs. debug mode

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2005-06-27 19:47 -------
Created an attachment (id=9162)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9162&action=view)
libstdc++.log for AIX, demonstrating issue


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors with -fno-weak vs. debug mode

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-06-27 21:59 -------
This is a regression in that you no longer can use the debug mode with -fno-weak.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-06-27 21:59:14
               date|                            |
            Summary|extra testsuite errors with |[4.1 Regression] errors with
                   |-fno-weak vs. debug mode    |-fno-weak vs. debug mode
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors with -fno-weak vs. debug mode

[dje at gcc dot gnu dot org]

------- Additional Comments From dje at gcc dot gnu dot org  2005-06-27 22:01 -------
AIX 5.2 does support weak, so I believe that there is something wrong with the
analysis.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-06-27 22:03 -------
Actually if you look into the email which David sent, you would see:
# 0 "<built-in>"
#define __GXX_WEAK__

Which means there is weak support.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |powerpc-ibm-aix5.2.0.0
            Summary|[4.1 Regression] errors with|[4.1 Regression] errors
                   |-fno-weak vs. debug mode    |debug mode on aix


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-28 11:41 -------
Humm, I wonder whether the problem isn't *really* trivial :)
In include/bits/c++config we have:

#ifdef _GLIBCXX_DEBUG
# if __GXX_WEAK__
#  define _GLIBCXX_STD __gnu_norm
#  define _GLIBCXX_EXTERN_TEMPLATE 0
...
...
# else
#  warning debug mode disabled due to lack of weak symbol support
# endif

Should be, instead, 'ifdef __GXX_WEAK__' ?!?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at gcc dot gnu dot org
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-28 11:45 -------
Or, wrt Andrew's comment, AIX should really have, consistently with the docs:
#define __GXX_WEAK__ 1

??

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[dje at gcc dot gnu dot org]

------- Additional Comments From dje at gcc dot gnu dot org  2005-06-28 14:16 -------
I do not understand the comment about GCC for AIX setting GXX_WEAK consistently.
    The value is set by GCC itself, not overridden by AIX.

GXX_WEAK is defined by c-cppbuiltin.c:

      if (flag_weak && SUPPORTS_ONE_ONLY) 
        cpp_define (pfile, "__GXX_WEAK__=1");
      else
        cpp_define (pfile, "__GXX_WEAK__=0");

and depends on SUPPORTS_ONE_ONLY, not just weak support.  I will test if setting
MAKE_DECL_ONE_ONLY works on AIX.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-06-28 14:27 -------
A clarification about __GXX_WEAK__: Andrew reports that, on AIX we have:
#define __GXX_WEAK__
If that is really the case (I cannot check, sorry), then the library is not
checking correctly the macro, because uses:
# if __GXX_WEAK__
which should be changed to:
# ifdef __GXX_WEAK__
Alternately, on AIX we should have:
#define __GXX_WEAK__ 1

I'm saying everywhere "on AIX" because for sure many other "weak" targets
are ok as they are. 

Agreed?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2005-06-27 21:59:14         |2005-07-31 04:06:12
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[dje at gcc dot gnu dot org]

------- Additional Comments From dje at gcc dot gnu dot org  2005-07-31 04:25 -------
I tried overriding libstdc++'s definition of __GXX_WEAK__ and GCC's definition
of ONE_ONLY.  Both caused additional C++ testsuite failures.  AIX does support
weak, but not exactly the way that G++ is expecting.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-11 14:16 -------
A real good question is why does debug mode need link once at all?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[bkoz at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bkoz at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
  GCC build triplet|                            |powerpc-ibm-aix5.2.0.0
   GCC host triplet|                            |powerpc-ibm-aix5.2.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2005-09-13 23:21 -------

It was discovered that to use string, you have to do all this magic with the
debug mode that involves not using extern template and a bunch of the other
linkage optimizations. There were some PRs about this.

That's why systems without weak will no longer support the debug mode. That's
not going to change.

However, fixing this so that debug mode is not tested (marked unsupported)
instead of failing seems reasonable.

Working on a patch...

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-15 18:59 -------
Subject: Bug 22205

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bkoz@gcc.gnu.org	2005-09-15 18:58:04

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: c++config 
	libstdc++-v3/testsuite/21_strings/basic_string/element_access/char: 
	                                                                    21674.cc 
	libstdc++-v3/testsuite/21_strings/basic_string/element_access/wchar_t: 
	                                                                       21674.cc 
	libstdc++-v3/testsuite/lib: dg-options.exp libstdc++.exp 

Log message:
	2005-09-15  Benjamin Kosnik  <bkoz@redhat.com>
	
	PR libstdc++/21674
	PR libstdc++/22205
	PR libstdc++/22222
	* include/bits/c++config: Set _GLIBCXX_STD regardless of __GXX_WEAK__.
	Add in check for __NO_INLINE__ for warning.
	* testsuite/lib/dg-options.exp (dg-require-debug-mode): New.
	* testsuite/lib/libstdc++.exp (check_v3_target_debug_mode): New.
	* testsuite/21_strings/basic_string/element_access/char/21674.cc:
	Use it.
	* testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc:
	Use it.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3107&r2=1.3108
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/c++config.diff?cvsroot=gcc&r1=1.1408&r2=1.1409
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/21_strings/basic_string/element_access/char/21674.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/dg-options.exp.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp.diff?cvsroot=gcc&r1=1.48&r2=1.49



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205

[Bug libstdc++/22205] [4.1 Regression] errors debug mode on aix

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2005-09-22 08:16 -------

Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22205