public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/22210] New: gfc_conv_array_initializer weirdness
@ 2005-06-27 23:33 giovannibajo at libero dot it
2005-06-27 23:46 ` [Bug fortran/22210] " pinskia at gcc dot gnu dot org
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: giovannibajo at libero dot it @ 2005-06-27 23:33 UTC (permalink / raw)
To: gcc-bugs
There seems to be something weird going on in gfc_conv_array_initializer. In
the EXPR_ARRAY case, the code builds both an "index" and a "range". Then,
optionally, it adds both of them to the constructor list being built. This is
strange: I would expect either of them to be added, but not both.
A testcase which triggers this behaviour is execute/data.f90. I caught this by
adding this additional verification hunk in varasm.c (but my tree is not clean
so I am not sure this is enough):
*************** output_constructor (tree exp, unsigned H
*** 4089,4094 ****
--- 4109,4115 ----
if each element has the proper size. */
if ((field != 0 || index != 0) && pos != total_bytes)
{
+ gcc_assert (pos >= total_bytes);
assemble_zeros (pos - total_bytes);
total_bytes = pos;
}
*************** output_constructor (tree exp, unsigned H
*** 4164,4169 ****
--- 4185,4191 ----
/* If still not at proper byte, advance to there. */
if (next_offset / BITS_PER_UNIT != total_bytes)
{
+ gcc_assert (next_offset / BITS_PER_UNIT >= total_bytes);
assemble_zeros (next_offset / BITS_PER_UNIT - total_bytes);
total_bytes = next_offset / BITS_PER_UNIT;
}
Also, gfc_conv_array_initializer, in the EXPR_CONSTANT/EXPR_STRUCTURE case,
contains some code which builts a repeated initializer by hand. It looks like
it would be easier but much more memory friendly to just use a RANGE_EXPR.
Steven asked me to assign this to him. This is part of my work to make
CONSTRUCTOR use VECs (actually, it's the only issue left AFAICT).
--
Summary: gfc_conv_array_initializer weirdness
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: enhancement
Priority: P2
Component: fortran
AssignedTo: stevenb at suse dot de
ReportedBy: giovannibajo at libero dot it
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <bug-22210-253@http.gcc.gnu.org/bugzilla/>]
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
@ 2006-01-03 18:45 ` pinskia at gcc dot gnu dot org
2006-01-05 17:05 ` steven at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-01-03 18:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2006-01-03 18:45 -------
Steven, I am assigning this from your suse account (one which does exist any
more) to your @gcc.gnu.org account, if you don't have the time to look into
this again, can you assign it to me as I was looking into it and semi saw what
was wrong but I did not know if you had a patch or not to fix this.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|stevenb at suse dot de |steven at gcc dot gnu dot
| |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
2006-01-03 18:45 ` pinskia at gcc dot gnu dot org
@ 2006-01-05 17:05 ` steven at gcc dot gnu dot org
2006-06-08 7:18 ` paul dot richard dot thomas at cea dot fr
` (7 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: steven at gcc dot gnu dot org @ 2006-01-05 17:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from steven at gcc dot gnu dot org 2006-01-05 17:04 -------
Assigning to Andrew Pinski because I wont be able to work on this for a while.
--
steven at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|steven at gcc dot gnu dot |pinskia at gcc dot gnu dot
|org |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
2006-01-03 18:45 ` pinskia at gcc dot gnu dot org
2006-01-05 17:05 ` steven at gcc dot gnu dot org
@ 2006-06-08 7:18 ` paul dot richard dot thomas at cea dot fr
2006-06-13 19:09 ` pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: paul dot richard dot thomas at cea dot fr @ 2006-06-08 7:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from paul dot richard dot thomas at cea dot fr 2006-06-08 06:54 -------
Where did this one go to? Can we close it?
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2006-06-08 7:18 ` paul dot richard dot thomas at cea dot fr
@ 2006-06-13 19:09 ` pinskia at gcc dot gnu dot org
2006-09-18 6:58 ` pault at gcc dot gnu dot org
` (5 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-13 19:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pinskia at gcc dot gnu dot org 2006-06-13 18:55 -------
(In reply to comment #7)
> Where did this one go to? Can we close it?
It is still funny looking code. I might take a look this weekend or on June 27
when I am traveling to the GCC summit.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2006-06-13 19:09 ` pinskia at gcc dot gnu dot org
@ 2006-09-18 6:58 ` pault at gcc dot gnu dot org
2007-07-09 8:06 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-09-18 6:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pault at gcc dot gnu dot org 2006-09-18 06:58 -------
(In reply to comment #8)
> (In reply to comment #7)
> > Where did this one go to? Can we close it?
>
> It is still funny looking code. I might take a look this weekend or on June 27
> when I am traveling to the GCC summit.
>
...and did you? *smile*
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2006-09-18 6:58 ` pault at gcc dot gnu dot org
@ 2007-07-09 8:06 ` pinskia at gcc dot gnu dot org
2007-10-04 21:44 ` tobi at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-07-09 8:06 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from pinskia at gcc dot gnu dot org 2007-07-09 08:06 -------
Ok, I guess I blew looking at this for a year. Too busy with work really :).
Anyways maybe next weekend.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2007-07-09 8:06 ` pinskia at gcc dot gnu dot org
@ 2007-10-04 21:44 ` tobi at gcc dot gnu dot org
2008-01-03 17:48 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-04 21:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from tobi at gcc dot gnu dot org 2007-10-04 21:44 -------
(In reply to comment #10)
> Ok, I guess I blew looking at this for a year. Too busy with work really :).
> Anyways maybe next weekend.
So, did you have time? :-)
--
tobi at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tobi at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2007-10-04 21:44 ` tobi at gcc dot gnu dot org
@ 2008-01-03 17:48 ` pinskia at gcc dot gnu dot org
2009-01-03 18:07 ` dfranke at gcc dot gnu dot org
2010-02-05 3:25 ` jvdelisle at gcc dot gnu dot org
9 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-01-03 17:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from pinskia at gcc dot gnu dot org 2008-01-03 17:42 -------
(In reply to comment #11)
> So, did you have time? :-)
Maybe this weekend :). I guess I have been really behind on my FSF bugs.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2008-01-03 17:48 ` pinskia at gcc dot gnu dot org
@ 2009-01-03 18:07 ` dfranke at gcc dot gnu dot org
2010-02-05 3:25 ` jvdelisle at gcc dot gnu dot org
9 siblings, 0 replies; 18+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2009-01-03 18:07 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from dfranke at gcc dot gnu dot org 2009-01-03 18:05 -------
(In reply to comment #12)
> Maybe this weekend :). I guess I have been really behind on my FSF bugs.
Yearly reminder.
Any progress here? :)
--
dfranke at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dfranke at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug fortran/22210] gfc_conv_array_initializer weirdness
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2009-01-03 18:07 ` dfranke at gcc dot gnu dot org
@ 2010-02-05 3:25 ` jvdelisle at gcc dot gnu dot org
9 siblings, 0 replies; 18+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2010-02-05 3:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from jvdelisle at gcc dot gnu dot org 2010-02-05 03:25 -------
1 year has gone by again.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22210
^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <bug-22210-4@http.gcc.gnu.org/bugzilla/>]
end of thread, other threads:[~2013-06-15 23:18 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-27 23:33 [Bug fortran/22210] New: gfc_conv_array_initializer weirdness giovannibajo at libero dot it
2005-06-27 23:46 ` [Bug fortran/22210] " pinskia at gcc dot gnu dot org
2005-06-29 22:04 ` giovannibajo at libero dot it
2005-07-09 16:51 ` pinskia at gcc dot gnu dot org
2005-09-18 6:15 ` pinskia at gcc dot gnu dot org
[not found] <bug-22210-253@http.gcc.gnu.org/bugzilla/>
2006-01-03 18:45 ` pinskia at gcc dot gnu dot org
2006-01-05 17:05 ` steven at gcc dot gnu dot org
2006-06-08 7:18 ` paul dot richard dot thomas at cea dot fr
2006-06-13 19:09 ` pinskia at gcc dot gnu dot org
2006-09-18 6:58 ` pault at gcc dot gnu dot org
2007-07-09 8:06 ` pinskia at gcc dot gnu dot org
2007-10-04 21:44 ` tobi at gcc dot gnu dot org
2008-01-03 17:48 ` pinskia at gcc dot gnu dot org
2009-01-03 18:07 ` dfranke at gcc dot gnu dot org
2010-02-05 3:25 ` jvdelisle at gcc dot gnu dot org
[not found] <bug-22210-4@http.gcc.gnu.org/bugzilla/>
2011-01-05 17:57 ` jrt at worldlinc dot net
2012-01-13 22:23 ` pinskia at gcc dot gnu.org
2013-06-15 23:18 ` bdavis at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).