[Bug tree-optimization/22356] mis-match types in cplxlower

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-07 20:56 -------
Created an attachment (id=9225)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9225&action=view)
the patch I used to find this


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] New: mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

Take the following code:
typedef _Complex float GFC_COMPLEX_4;
void product_c4 (GFC_COMPLEX_4 *src, GFC_COMPLEX_4 *dest, int len)
{
  int n;
  GFC_COMPLEX_4 result;
  for (n = 0; n < len; n++, src += 1)
    result *= *src;
  *dest = result;
}

We get a mis-match type after cplxlower:
t.c: In function 'product_c4':
t.c:4: error: statement types mismatch
result$realD.1290_28 = REALPART_EXPR <resultD.1270_10>;

floatD.21
GFC_COMPLEX_4D.1263
t.c:4: error: statement types mismatch
result$imagD.1291_29 = IMAGPART_EXPR <resultD.1270_10>;

floatD.21
GFC_COMPLEX_4D.1263

-- 
           Summary: mis-match types in cplxlower
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-07 20:57 -------
Looks like we forgot a TREE_TYPE some where.
I will try to look into fixing this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-07 21:01 -------
Forgot to say this was reduced from product_c4.c.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-07 21:06 -------
Forgot to mention  -std=c99 -O1 is needed to reproduce the bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-07 21:12 -------
I found where the problem was.
in expand_complex_libcall when in_ssa_p we create REALPART_EXPR/IMAGPART_EXPR with the wrong 
type.

I am testing the fix.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-07 21:12:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-08 17:23 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00578.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |07/msg00578.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-08 18:05 -------
Subject: Bug 22356

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2005-07-08 18:05:12

Modified files:
	gcc            : ChangeLog tree-complex.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: pr22356-1.c 

Log message:
	2005-07-08  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR tree-opt/22356
	* testsuite/gcc.dg/pr22356-1.c: New test.
	
	2005-07-08  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR tree-opt/22356
	* tree-complex.c (expand_complex_libcall): Produce
	REALPART_EXPR/IMAGPART_EXPR with the correct type.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9383&r2=2.9384
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-complex.c.diff?cvsroot=gcc&r1=2.34&r2=2.35
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr22356-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5742&r2=1.5743



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356

[Bug tree-optimization/22356] mis-match types in cplxlower

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-08 18:05 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22356