[Bug fortran/21730] New: Character length incorrect.

[Bug fortran/21730] New: Character length incorrect.

[fengwang at gcc dot gnu dot org]

character*2 a
      character*4 b
      parameter(a="12")
      parameter (b = a)
      write (*, *) b
      end

gfortran output: "12"
correct output: "12  "

-- 
           Summary: Character length incorrect.
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: fengwang at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
OtherBugsDependingO 19276
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[fxcoudert at gcc dot gnu dot org]

------- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-05-26 08:31 -------
Confirmed. Parse tree output for slightly modified testcase:

$ cat a.f
      character*2 a
      character*4 b
      character*4 c
      parameter(a="12")
      parameter (b = a)
      c = a
      write (*, '("#",A,"#")') b
      write (*, '("#",A,"#")') c
      end
$ gfortran a.f -fdump-parse-tree

        Namespace: A-H: (REAL 4) I-N: (INTEGER 4) O-Z: (REAL 4)
        symtree: b  Ambig 0
        symbol b (CHARACTER 4)(PARAMETER UNKNOWN-INTENT UNKNOWN-ACCESS UNKNOWN-PROC)
        value: '12'

        symtree: a  Ambig 0
        symbol a (CHARACTER 2)(PARAMETER UNKNOWN-INTENT UNKNOWN-ACCESS UNKNOWN-PROC)
        value: '12'

        symtree: c  Ambig 0
        symbol c (CHARACTER 4)(VARIABLE UNKNOWN-INTENT UNKNOWN-ACCESS UNKNOWN-PROC)


      ASSIGN c '12'
      WRITE UNIT=6 FMT='("#",A,"#")'
      TRANSFER '12'
      DT_END
      WRITE UNIT=6 FMT='("#",A,"#")'
      TRANSFER c
      DT_END

$ ./a.out 
#12#
#12  #


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-26 08:31:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[dje at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dje at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-06-06 00:44:36         |2005-07-13 17:38:57
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[dje at gcc dot gnu dot org]

------- Additional Comments From dje at gcc dot gnu dot org  2005-07-13 17:39 -------
Patch here
http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00937.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-13 17:43 -------
(In reply to comment #2)
> Patch here
> http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00937.html

What about the testcase, David?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[dje at watson dot ibm dot com]

------- Additional Comments From dje at watson dot ibm dot com  2005-07-13 18:23 -------
Subject: Re:  Character length incorrect. 

> What about the testcase, David?

	I was focussing on the patch itself.  Here's a testcase:

! PR fortran/21730
! {do-do run}
        character*2 a
        character*4 b
        character*6 c
        parameter (a="12")
        parameter (b = a)
        write (c,'("#",A,"#")') b
        if (c .ne. '#12  #') call abort
        end

David


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[fengwang at gcc dot gnu dot org]

------- Additional Comments From fengwang at gcc dot gnu dot org  2005-07-14 02:49 -------
I think we have to consider character arrays. See:

        character*2 a (1)
        character*4 b
        character*6 c
        parameter (a="12")
        parameter (b = a(1))
        write (c,'("#",A,"#")') b
        if (c .ne. '#12  #') call abort
        end
Or:
        character*2 a (1)
        character*4 b (1)
        character*6 c
        parameter (a="12")
        parameter (b = a)
        write (c,'("#",A,"#")') b
        if (c .ne. '#12  #') call abort
        end

gfortran report an Internal Error.

IMHO, your patch only handles the scalar character and is not entire, though a 
different bug is revealed by the above examples.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[fengwang at gcc dot gnu dot org]

------- Additional Comments From fengwang at gcc dot gnu dot org  2005-07-14 03:30 -------
For comment #5, here is the backtrace:
#0  gfc_internal_error (
    format=0x8447620 "Initialization expression didn't reduce %C")
    at ../../gcc/gcc/fortran/error.c:662
#1  0x0805da16 in gfc_match_init_expr (result=0x0)
    at ../../gcc/gcc/fortran/expr.c:1523
#2  0x080586e8 in do_parm () at ../../gcc/gcc/fortran/decl.c:3084
#3  0x08058838 in gfc_match_parameter () at ../../gcc/gcc/fortran/decl.c:3135
#4  0x0807394b in match_word (str=0x0, subr=0x8058811 <gfc_match_parameter>,
    old_locus=0x0) at ../../gcc/gcc/fortran/parse.c:65
#5  0x080740ee in decode_statement () at ../../gcc/gcc/fortran/parse.c:248
#6  0x080745fc in next_statement () at ../../gcc/gcc/fortran/parse.c:498
#7  0x08075279 in parse_spec (st=ST_PARAMETER)
    at ../../gcc/gcc/fortran/parse.c:1589
#8  0x08075c47 in parse_progunit (st=ST_ARITHMETIC_IF)
    at ../../gcc/gcc/fortran/parse.c:2287
#9  0x080760ec in gfc_parse_file () at ../../gcc/gcc/fortran/parse.c:2612
#10 0x08087e7c in gfc_be_parse_file (set_yydebug=0)
    at ../../gcc/gcc/fortran/f95-lang.c:263
#11 0x082d9d84 in compile_file () at ../../gcc/gcc/toplev.c:975
#12 0x082db33f in do_compile () at ../../gcc/gcc/toplev.c:1941
#13 0x082db3a1 in toplev_main (argc=2, argv=0xbfffde94)
    at ../../gcc/gcc/toplev.c:1973
#14 0x080ac2e3 in main (argc=2, argv=0xbfffde94) at ../../gcc/gcc/main.c:35
#15 0x42015574 in __libc_start_main () from /lib/tls/libc.so.6


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[dje at watson dot ibm dot com]

------- Additional Comments From dje at watson dot ibm dot com  2005-07-14 03:37 -------
Subject: Re:  Character length incorrect. 

>>>>> fengwang at gcc dot gnu dot org writes:

fengwang> IMHO, your patch only handles the scalar character and is not entire, though a 
fengwang> different bug is revealed by the above examples.

	I cannot tell if your response is an objection to my patch or not.
Yes, gfortran has additional bugs in this area, but, as you mention, those
are different bugs -- they exist prior to my patch.  gfortran needs more
work in this area, but we need to start somewhere.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[fengwang at gcc dot gnu dot org]

------- Additional Comments From fengwang at gcc dot gnu dot org  2005-07-14 03:46 -------
I just hope you could work on this ;-)
Having a good start, why not fix entirely? If somebody agrees to fix step by 
step, I have no objection.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[dje at watson dot ibm dot com]

------- Additional Comments From dje at watson dot ibm dot com  2005-07-14 03:49 -------
Subject: Re:  Character length incorrect. 

>>>>> fengwang at gcc dot gnu dot org writes:

Feng> Having a good start, why not fix entirely? If somebody agrees to fix step by 
Feng> step, I have no objection.

	Because developers are volunteers.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-17 00:48 -------
Subject: Bug 21730

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	dje@gcc.gnu.org	2005-07-17 00:48:46

Modified files:
	gcc/fortran    : ChangeLog decl.c 

Log message:
	PR fortran/21730
	* decl.c (do_parm): Adjust character initializer to character length
	of symbol before assigning.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.497&r2=1.498
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/decl.c.diff?cvsroot=gcc&r1=1.37&r2=1.38



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-17 00:56 -------
Subject: Bug 21730

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	dje@gcc.gnu.org	2005-07-17 00:55:59

Modified files:
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: pr21730.f 

Log message:
	PR fortran/21730
	* gfortran.dg/pr21730.f: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5775&r2=1.5776
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/pr21730.f.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[rsandifo at gcc dot gnu dot org]

------- Additional Comments From rsandifo at gcc dot gnu dot org  2005-09-07 10:37 -------
Is this still a problem?  The other two testcases seem to work now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rsandifo at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[fxcoudert at gcc dot gnu dot org]

------- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-09-09 07:53 -------
Everything here works. Closing.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] Character length incorrect.

[tkoenig at gcc dot gnu dot org]

------- Additional Comments From tkoenig at gcc dot gnu dot org  2005-09-18 20:08 -------
Not fixed in 4.0:

$ cat pr21730.f
! PR fortran/21730
! { dg-do run }
      character*2 a
      character*4 b
      character*6 c
      parameter (a="12")
      parameter (b = a)
      write (c,'("#",A,"#")') b
      if (c .ne. '#12  #') call abort
      end

$ gfortran pr21730.f
$ ./a.out
Aborted
$ gfortran -v
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../gcc-4.0/configure --prefix=/home/ig25
--enable-languages=c,fortran
Thread model: posix
gcc version 4.0.2 20050917 (prerelease)



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
      Known to fail|                            |4.0.2
      Known to work|                            |4.1.0
         Resolution|FIXED                       |
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730

[Bug fortran/21730] [4.0 only] Character length incorrect.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-18 20:27 -------
All of these are fixed in 4.1.0. Since 4.0.2 is the last 4.0 release before a 4.1.0 release will be made, 
4.0.2 and 4.0.1 were special releases for gfrotran.  4.0.3 should be a normal release for GCC and 
gfortran in that regressions are the only changes.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.0.3                       |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21730