[Bug tree-optimization/22493] New: [4.1 Regression] with -fwrapv -INT_MIN is still not postive

[Bug tree-optimization/22493] New: [4.1 Regression] with -fwrapv -INT_MIN is still not postive

[pinskia at gcc dot gnu dot org]

Take the following code:
#include <limits.h>
void abort ();
void f(int i)
{
  if (i>0)
    abort();
  i = -i;
  if (i<0)
    return;
  abort ();
}

int main(void)
{
  f(INT_MIN);
  return 0;
}

This should not abort but does at -O2 -fwrapv and above because VRP is folding the conditional which 
is not true as -INT_MIN = INT_MIN still.  This causes us to mis compile Long.toString in libjava.

-- 
           Summary: [4.1 Regression] with -fwrapv -INT_MIN is still not
                    postive
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not postive

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not postive

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |22084
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not postive

[tromey at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[tromey at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1 Regression] with -     |[4.1 Regression] with -
                   |fwrapv -INT_MIN is still not|fwrapv -INT_MIN is still not
                   |postive                     |positive


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-16 21:33 -------
Note I should give credit to Andrew Haley who pointed me to the mis compiling of Long.toString.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-07-17 00:28 -------
Created an attachment (id=9291)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9291&action=view)
Treat flag_wrapv and min value in a special way


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[pluto at agmk dot net]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]


------- Additional Comments From pluto at agmk dot net  2005-07-17 20:35 -------
(In reply to comment #2) 
> Created an attachment (id=9291)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9291&action=view) 
> Treat flag_wrapv and min value in a special way 
>  
 
patch cointains typo-bug. 
 
--- gcc-pr22493.patch   Sun Jul 17 20:07:13 2005 
+++ gcc-pr22493.patch   Sun Jul 17 22:33:27 2005 
@@ -53,7 +53,7 @@ 
 -      max = (vr0.min == TYPE_MIN_VALUE (TREE_TYPE (expr))) 
 -          ? TYPE_MAX_VALUE (TREE_TYPE (expr)) 
 -          : fold_unary_to_constant (code, TREE_TYPE (expr), vr0.min); 
-+        type = VR_ANTI_RANGE; 
++        vr_type = VR_ANTI_RANGE; 
 +        max = fold_unary_to_constant (code, TREE_TYPE (expr), vr0.max); 
 +        max = int_const_binop (MINUS_EXPR, max, one, 0); 
 +        min = int_const_binop (PLUS_EXPR, min, one, 0); 
 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pluto at agmk dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-07-19 07:15 -------
 The attached patch, with the typo fixed and using
 int_const_binop (PLUS_EXPR, vr0.min, one, 0) fixed the optimization failures of
Divide_1 in the testsuite.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-19 13:41 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-19 13:42:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-07-23 08:25 -------
Created an attachment (id=9336)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9336&action=view)
Updated patch

 This should also fix:
/* { dg-do run } */
/* { dg-options "-O1 -ftree-vrp" } */

extern void abort ();
extern void exit (int);

int f (int a) {
	if (a != 2) {
		a = -a;
		if (a == 2)
		  return 0;
		return 1;
	}
	return 1;
}

int main (int argc, char *argv[]) {
	if (f (-2))
		abort ();
	exit (0);
}

 which fails right now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |phython at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-25 00:11 -------
Patch posted here: <http://gcc.gnu.org/ml/gcc-patches/2005-07/msg01566.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |07/msg01566.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-28 04:35 -------
Subject: Bug 22493

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	phython@gcc.gnu.org	2005-07-28 04:35:02

Modified files:
	gcc            : ChangeLog tree-vrp.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.c-torture/execute: pr22493-1.c pr22493-1.x 
	                                     vrp-1.c vrp-2.c vrp-3.c 

Log message:
	2005-07-27  James A. Morrison  <phython@gcc.gnu.org>
	
	PR tree-optimization/22493
	* tree-vrp.c (extract_range_from_unary_expr): Deal with -fwrapv and
	VR_ANTI_RANGEs properly for NEGATE_EXPRs and ABS_EXPRs.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9575&r2=2.9576
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-vrp.c.diff?cvsroot=gcc&r1=2.43&r2=2.44
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5832&r2=1.5833
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/pr22493-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/pr22493-1.x.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/vrp-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/vrp-2.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/vrp-3.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493

[Bug tree-optimization/22493] [4.1 Regression] with -fwrapv -INT_MIN is still not positive

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-07-28 04:45 -------
 Fixed in the commit above.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22493