[Bug libfortran/22570] New: Null Characters instead of blanks in text output.

[Bug libfortran/22570] New: Null Characters instead of blanks in text output.

[dir at lanl dot gov]

I down loaded and built gfortran today on Suse Linux with -

configure --prefix=/home/dir/gfortran --enable-languages=c,f95
make -j 4
make install

The first problem was that it did not find the shared libraries until I set

setenv LD_LIBRARY_PATH ~/gfortran/lib

Then when the program did run the output had null characters in the place blanks
for some of the "21x" format statements. Here is the sequence and a hex dump of
the output -


dir/tests> gfortran -o write01 write01.f
dir/tests> write01 > out
STOP 0
dir/tests> cat out
1












                   
********************************************************************************************
********************************************************************************************
**                                                                             
          **
**                                                                             
          **
**
**                                                                             
          **
**                                                                             
          **
**         aaaaaaaaaa    ddddddddd      iiiiiiiiiiii   nn        nn   
aaaaaaaaaa         **
**        aaaaaaaaaaaa   dddddddddd     iiiiiiiiiiii   nnn       nn  
aaaaaaaaaaaa        **
**        aa        aa   dd       dd         ii        nnnn      nn   aa       
aa        **
**        aa        aa   dd        dd        ii        nn nn     nn   aa       
aa        **
**        aa        aa   dd        dd        ii        nn  nn    nn   aa       
aa        **
**        aaaaaaaaaaaa   dd        dd        ii        nn   nn   nn  
aaaaaaaaaaaa        **
dir/tests> dump -i out

   File name: out   Block number: 0   Byte number: 0

0000  31 0a 0a 0a 0a 0a 0a 0a  0a 0a 0a 0a 0a 0a 00 20  1....... .......
0010  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0020  20 20 20 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a     ***** ********
0030  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
0040  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
0050  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
0060  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
0070  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 0a  ******** *******.
0080  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ........ ........
0090  00 00 00 00 00 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  .....*** ********
00a0  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
00b0  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
00c0  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
00d0  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
00e0  2a 2a 2a 2a 2a 2a 2a 2a  2a 2a 2a 2a 2a 2a 2a 2a  ******** ********
00f0  2a 0a 00 00 00 00 00 00  00 00 00 00 00 00 00 00  *....... ........


   File name: out   Block number: 1   Byte number: 256

0000  00 00 00 00 00 00 00 2a  2a 20 20 20 20 20 20 20  .......* *
0010  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0020  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0030  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0040  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0050  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0060  20 2a 2a 0a 00 00 00 00  00 00 00 00 00 00 00 00   **..... ........
0070  00 00 00 00 00 00 00 00  00 2a 2a 20 20 20 20 20  ........ .**
0080  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
0090  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
00a0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
00b0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
00c0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20
00d0  20 20 20 2a 2a 0a 00 00  00 00 00 00 00 00 00 00     **... ........
00e0  00 00 00 00 00 00 00 00  00 00 2a 2a 0a 00 00 00  ........ ..**....
00f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ........ ........
q
dir/tests> cat write01.f
      program main
      write(6,2000)
      stop
 2000 format (1h1,/////////////,21x,92(1h*),/,21x,92(1h*),/,2(21x,2h**,
     1 88x,2h**,/),
     2               20x,2h**,/,2(21x,2h**,88x,2h**,/),21x,2h**,9x,
     310(1ha),4x,9(1hd),6x,12(1hi),3x,2hnn,8x,2hnn,4x,10(1ha),9x,2h**,/,
     4 21x,2h**,8x,12(1ha),3x,10(1hd),5x,12(1hi),3x,3hnnn,7x,2hnn,3x,
     5 12(1ha),8x,2h**,/,21x,2h**,8x,2haa,8x,2haa,3x,2hdd,7x,2hdd,9x,
     6 2hii,8x,4(1hn),6x,2hnn,3x,2haa,8x,2haa,8x,2h**,/,21x,2h**,8x,
     7 2haa,8x,2haa,3x,2hdd,8x,2hdd,8x,2hii,8x,2hnn,1x,2hnn,5x,2hnn,3x,
     82haa,8x,2haa,8x,2h**,/,21x,2h**,8x,2haa,8x,2haa,3x,2hdd,8x,2hdd,
     9 8x,2hii,8x,2hnn,2x,2hnn,4x,2hnn,3x,2haa,8x,2haa,8x,2h**,/,21x,2h*
     1*,8x,12(1ha),3x,2hdd,8x,2hdd,8x,2hii,8x,2hnn,3x,2hnn,3x,2hnn,3x,
     2 12(1ha),8x,2h**)
      end

-- 
           Summary: Null Characters instead of blanks in text output.
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dir at lanl dot gov
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: Suse Linux professional 9.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-20 15:41 -------
Confirmed, I think this was caused by:
2005-07-12 Paul Thomas  <pault@gcc.gnu.org>

        PR libfortran/16435
        * transfer.c (formatted_transfer): Correct the problems
        with X- and T-editting that caused TLs followed by TRs
        to overwrite data, which caused NIST FM908.FOR to fail
        on many tests.
        (data_transfer_init): Zero X- and T-editting counters at
        the start of formatted IO.
        * write.c (write_x): Write specified number of skips with
        specified number of spaces at the end.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-20 15:41:58
               date|                            |
            Version|4.0.0                       |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-20 16:35 -------
(In reply to comment #1)
> Confirmed, I think this was caused by:
> 2005-07-12 Paul Thomas  <pault@gcc.gnu.org>

It sure as heck looks like me.

I'm on to it!

Paul

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-20 19:07 -------
Subject: Re:  Null Characters instead of blanks in text
 output.

pinskia at gcc dot gnu dot org wrote:

>------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-20 15:41 -------
>Confirmed, I think this was caused by:
>2005-07-12 Paul Thomas  <pault@gcc.gnu.org>
>
Guilty, as charged.

Please find attached, ChangeLog entries, patch, the output that was 
incorrect and now looks the same as ifc, plus a testcase.

I just never checked what slash editing did to the position counters. 
 duuuh!

Regtests OK on RH9.

OK for mainline and 4.0?

Paul T

PS Steven, it's not so much a one spacer but a one liner...

2005-07-19 Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/22570
    * transfer.c (formatted_transfer): Correct the problem
    with X- editting due to slashes not zeroing the space
    and maximum position counters.
.
    PR fortran/22570
    * gfortran.dg/x_slash.f: New Test.


Index: gcc/libgfortran/io/transfer.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/transfer.c,v
retrieving revision 1.48
diff -c -3 -p -r1.48 transfer.c
*** gcc/libgfortran/io/transfer.c    14 Jul 2005 06:21:58 -0000    1.48
--- gcc/libgfortran/io/transfer.c    20 Jul 2005 17:57:48 -0000
*************** formatted_transfer (bt type, void *p, in
*** 776,781 ****
--- 776,782 ----
 
      case FMT_SLASH:
        consume_data_flag = 0 ;
+       max_pos = skips = pending_spaces = 0;
        next_record (0);
        break;
 

Now results in......

1












                     
********************************************************************************************
                     
********************************************************************************************
                     
**                                                                                        
**
                     
**                                                                                        
**
                    **
                     
**                                                                                        
**
                     
**                                                                                        
**
                     **         aaaaaaaaaa    ddddddddd      
iiiiiiiiiiii   nn        nn    aaaaaaaaaa         **
                     **        aaaaaaaaaaaa   dddddddddd     
iiiiiiiiiiii   nnn       nn   aaaaaaaaaaaa        **
                     **        aa        aa   dd       dd         
ii        nnnn      nn   aa        aa        **
                     **        aa        aa   dd        dd        
ii        nn nn     nn   aa        aa        **
                     **        aa        aa   dd        dd        
ii        nn  nn    nn   aa        aa        **
                     **        aaaaaaaaaaaa   dd        dd        
ii        nn   nn   nn   aaaaaaaaaaaa        **



Test case


c { dg-do run }
c This program tests the fix to PR22570.
c
c provided by Paul Thomas - pault@gcc.gnu.org
c
       program x_slash
       character*60 a

       open (10, status="scratch")
       write (10, 100)

 100   format (1h1,59x,1h*,/,60x,/,58x,1h*,/)

       rewind (10)

       read (10, 200) a
       read (10, 200) a
       read (10, 200) a

 200   format (a60)

       close (10)

       if (ichar(a(10:10)).ne.32) call abort ()

       end







-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-20 20:03 -------
Subject: Re:  Null Characters instead of blanks in text output.

On Wednesday 20 July 2005 21:07, Paul Thomas wrote:
> pinskia at gcc dot gnu dot org wrote:
> >------- Additional Comments From pinskia at gcc dot gnu dot org 
> > 2005-07-20 15:41 ------- Confirmed, I think this was caused by:
> >2005-07-12 Paul Thomas  <pault@gcc.gnu.org>
>
> Guilty, as charged.
>
> Please find attached, ChangeLog entries, patch, the output that was
> incorrect and now looks the same as ifc, plus a testcase.

This still doesn't fix mgrid either.

Gr.
Steven


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-20 20:17 -------
Subject: Re:  Null Characters instead of blanks in text output.

On Wednesday 20 July 2005 22:03, Steven Bosscher wrote:
> On Wednesday 20 July 2005 21:07, Paul Thomas wrote:
> > pinskia at gcc dot gnu dot org wrote:
> > >------- Additional Comments From pinskia at gcc dot gnu dot org
> > > 2005-07-20 15:41 ------- Confirmed, I think this was caused by:
> > >2005-07-12 Paul Thomas  <pault@gcc.gnu.org>
> >
> > Guilty, as charged.
> >
> > Please find attached, ChangeLog entries, patch, the output that was
> > incorrect and now looks the same as ifc, plus a testcase.
>
> This still doesn't fix mgrid either.

FWIW I get the feeling that the sixtrack and mgrid problems are
the same bug.  For mgrid we have spurious '\0' characters in the
output, and for sixtrack a read of an internal file with a format
with an 'X' specifier in it ("READ(5,'(18X,I4)') NNO") fails...
I still haven't been able to reduce this to a useful testcase :-(

Gr.
Steven



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-20 20:46 -------
Subject: Re:  Null Characters instead of blanks in text output.

On Wednesday 20 July 2005 22:16, Steven Bosscher wrote:
> On Wednesday 20 July 2005 22:03, Steven Bosscher wrote:
> > On Wednesday 20 July 2005 21:07, Paul Thomas wrote:
> > > pinskia at gcc dot gnu dot org wrote:
> > > >------- Additional Comments From pinskia at gcc dot gnu dot org
> > > > 2005-07-20 15:41 ------- Confirmed, I think this was caused by:
> > > >2005-07-12 Paul Thomas  <pault@gcc.gnu.org>
> > >
> > > Guilty, as charged.
> > >
> > > Please find attached, ChangeLog entries, patch, the output that was
> > > incorrect and now looks the same as ifc, plus a testcase.
> >
> > This still doesn't fix mgrid either.
>
> FWIW I get the feeling that the sixtrack and mgrid problems are
> the same bug.  For mgrid we have spurious '\0' characters in the
> output, and for sixtrack a read of an internal file with a format
> with an 'X' specifier in it ("READ(5,'(18X,I4)') NNO") fails...
> I still haven't been able to reduce this to a useful testcase :-(

Here is a test case that shows how fubar libgfortran is at the moment:

      IMPLICIT NONE
      INTEGER IOUT,IOA, III
      REAL CC
      INTEGER J(18),K(18)
      CHARACTER C10*10

      DO IOA=1,18
         J(IOA) = IOA**2
      END DO
      OPEN(UNIT=18, FORM='FORMATTED', STATUS='UNKNOWN')
      WRITE(18,'(I6,4X,18(2X,I4))') IOA,(J(III),III=1,18)
      REWIND(18)
      READ(18,'(A10,18(2X,I4))') C10, K
      PRINT *,C10
      DO IOA=1,18
        PRINT *,K(IOA)
      END DO
      CLOSE(UNIT=18,STATUS='DELETE')
      END

Output of libgfortran from 2005-07-09:

     19
           1
           4
           9
          16
          25
          36
          49
          64
          81
         100
         121
         144
         169
         196
         225
         256
         289
         324

aka good.


Output of libgfortran from 2005-07-20 (today)

     19
           1
           4
           9
          16
           2
           0
           6
          49
          64
          81
          10
           1
           1
          44
         169
         196
          22
           2

aka Very Wrong (tm).


Output of libgfortran from 2005-07-20 with the patches from
Jerry[1] and Paul[2] applied:

     19
           1
           4
           9
          16
           2
           0
           6
          49
          64
          81
          10
           1
           1
          44
         169
         196
          22
           2

aka Still Very Wrong.


Guys, it seems we don't cover all the possibile output modes well for
libgfortran in our test suite :-(

Gr.
Steven




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-20 20:49 -------
Subject: Re:  Null Characters instead of blanks in text output.

On Wednesday 20 July 2005 22:46, Steven Bosscher wrote:
> Output of libgfortran from 2005-07-20 with the patches from
> Jerry[1] and Paul[2] applied:

That is,
[1] http://gcc.gnu.org/ml/fortran/2005-07/msg00280.html; and
[2] http://gcc.gnu.org/ml/fortran/2005-07/msg00294.html

>      19
>            1
>            4
>            9
>           16
>            2
>            0
>            6
>           49
>           64
>           81
>           10
>            1
>            1
>           44
>          169
>          196
>           22
>            2
>
> aka Still Very Wrong.

The output looks good though:
    19     1     4     9    16    25    36    49    64    81   100   121   144   169   196   225   256   289   324


The problem is apparently still on the read side of things.

Gr.
Steven



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-20 22:02 -------
Subject: Re:  Null Characters instead of blanks in text
 output.

Steve,

There are two problems:

>The output looks good though:
>    19     1     4     9    16    25    36    49    64    81   100   121   144   169   196   225   256   289   324
>  
>
               ^ we need four more spaces here.

>
>The problem is apparently still on the read side of things.
>
I agree; replacing (2x, i4) with i6 works.  It's all down to x-editing 
problems.  I must stop now but will resume in the morrow.

I believe both problems (and the one I patched) are down to the logic 
determining the present pointer, the maximum but unprinted pointer and 
the pending spaces.  I just do not see it yet.

Paul T




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-21 05:33 -------
Subject: Re:  Null Characters instead of blanks in text
 output.


Steven,

>> The output looks good though:
>>    19     1     4     9    16    25    36    49    64    81   100   
>> 121   144   169   196   225   256   289   324
>>  
>>
>               ^ we need four more spaces here. 

This one I have fixed: I was not accumulating skips and spaces for 
multiple sequences of tabs or X-edits.

>
> I agree; replacing (2x, i4) with i6 works.  It's all down to x-editing 
> problems.  I must stop now but will resume in the morrow.
>
This one is stranger: replacing 2X with TR2 works.  There is logic that 
distinguishes them in read_x, which was the fix for the eor problem. 
 However, when I remove it, everything breaks except your testcase!

I will go back to it tonight.  I am nearly there; I am just missing why 
TR2 works.

Paul T




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[prthomas at drfccad dot cea dot fr]

------- Additional Comments From prthomas at drfccad dot cea dot fr  2005-07-21 07:47 -------
Subject: Re:  Null Characters instead of blanks in t
	extoutput

Steven,

I figured out the third (I was going to say "final"...) bug during the drive
to work.

I am not in a position to do anything about it until tonight because I am up
to my
eyeballs with day-time work.

To recap-

The three buglets that I produced are:

(1) The receipt of a slash should clear the pending skips and spaces(last
night's patch);
(2) The skips and spaces need to accumulate to cope with sequences of tabs
and X-edits,
as mentioned and tested this morning; and
(3) The function read.c(read_x)must ignore current_unit->bytes_left, except
where the
record length is known.  I will check out a clean way to do this tonight.  I
think that
it is trivial but need to be sure that I pick the right condition.

I will incorporate these three patches into one and provide one or,
possibly, two test
cases.

Regards

Paul T


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-21 10:12 -------
Subject: Re:  Null Characters instead of blanks in t extoutput

On Thursday 21 July 2005 11:10, THOMAS Paul Richard 169137 wrote:
> Steven,
>
> Whilst waiting for somebody to show up to a meeting, I developed the third
> correction.
>
> > To recap-
> >
> > The three buglets that I produced are:
> >
> > (1) The receipt of a slash should clear the pending skips and
> > spaces(last night's patch);
> > (2) The skips and spaces need to accumulate to cope with
> > sequences of tabs and X-edits,
> > as mentioned and tested this morning; and
> > (3) The function read.c(read_x)must ignore
> > current_unit->bytes_left, except where the
> > record length is known.  I will check out a clean way to do
> > this tonight.  I think that
> > it is trivial but need to be sure that I pick the right condition.
>
> The patches to transfer.c and read.c that correct all three of the above
> are enclosed.
>
> They have been regtested on Cygwin.
>
> Will provide changelog entries and testcase(s) tonight, when I will
> resubmit.  I would be grateful if you would try the various failing SPEC
> cases and let me know what happens.

Hi Paul,

Thanks for your efforts.  Sadly these patches still do not fix mgrid :-(

In addition, it makes sixtrack worse.  The expected output is of the form,

                      1.340689733836071700000000000000000
                      0.146543110072956760000000000000000
                      1.260311090193034800000000000000000
                     -0.042293577150839000000000000000000
                    -64.139440118247251000000000000000000
                      0.000703903375558890710000000000000
                      1.340690456452690900000000000000000
                      0.146543147601565030000000000000000
                      1.260311267783928500000000000000000
                     -0.042293584340409571000000000000000
                    -64.139440156078706000000000000000000
                      0.000703903375535219540000000000000
                 450000.000000000000000000000000000000000
                 450316.755142387060000000000000000000000
                 450316.755142376410000000000000000000000


But now I get something that looks like memory corruption:

                      1.291130196023531517823812000000000
0000000000            0.143847492053550962687325000000000
4800000000            1.230797727535498431450378000000000
4200000000           -0.041176487158203642358067500000000
M SEED   1          -64.137216332498809379103480000000000
UTION                 0.000703904640534278491954822700000
0957530000            1.291130872561160991551787000000000
1602036000            0.143847531118832500096615900000000
5055850000            1.230797901908041502849755000000000
3846270600           -0.041176494385251151408855460000000
6256300000          -64.137216367717257980984870000000000
8443759257            0.000703904640508020307959613500000
5815140000       450000.000000000000000000000000000000000
2841676000       450316.755711623525712639100000000000000
5223840000       450316.755711611709557473700000000000000


A test case demonstrating the problem with the '\0' characters is this:

      IMPLICIT NONE
      INTEGER IOUT,IOA, III
      REAL CC

      IOA=18
      CC=3.1425
      OPEN(UNIT=18, FORM='FORMATTED', STATUS='UNKNOWN')
      WRITE(18,100) IOA, IOA, CC, IOA
C      REWIND(18)
C      READ(18,'(A10,18(2X,I4))') C10, K
100   FORMAT(1x/5x,'PARTICLE ',i3,' STABLE - RANDOM SEED ', i8,
     +' MOMENTUM DEVIATION ',g12.5 /5x,'REVOLUTION ',i8/)

      CLOSE(UNIT=18)!,STATUS='DELETE')
      END


The output I get is (with '^@' == '\0' again):
================================================

     PARTICLE  18 STABLE - RANDOM SEED       18 MOMENTUM DEVIATION   3.1425
^@^@^@^@^@REVOLUTION       18
================================================


I have attached the whole collection of patches that is in my local
tree right now.  It is your fixes plus Jerry's for the BN/BZ thing.

Gr.
Steven

Index: io/read.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/read.c,v
retrieving revision 1.14
diff -u -3 -p -r1.14 read.c
--- io/read.c	13 Jul 2005 18:43:11 -0000	1.14
+++ io/read.c	21 Jul 2005 09:44:30 -0000
@@ -691,24 +691,46 @@ read_f (fnode * f, char *dest, int lengt
   p++;
   w--;
 
-  while (w > 0)
+  if (g.blank_status == BLANK_UNSPECIFIED) /* Normal processing of exponent */
     {
-      if (*p == ' ')
+      while (w > 0 && isdigit (*p))
         {
-          if (g.blank_status == BLANK_ZERO) *p = '0';
-          if (g.blank_status == BLANK_NULL)
+          exponent = 10 * exponent + *p - '0';
+          p++;
+          w--;
+        }
+        
+      /* Only allow trailing blanks */
+
+      while (w > 0)
+        {
+          if (*p != ' ')
+  	  goto bad_float;
+          p++;
+          w--;
+        }
+    }    
+  else  /* BZ or BN status is enabled */
+    {
+      while (w > 0)
+        {
+          if (*p == ' ')
             {
-              p++;
-              w--;
-              continue;
+              if (g.blank_status == BLANK_ZERO) *p = '0';
+              if (g.blank_status == BLANK_NULL)
+                {
+                  p++;
+                  w--;
+                  continue;
+                }
             }
+          else if (!isdigit (*p))
+            goto bad_float;
+
+          exponent = 10 * exponent + *p - '0';
+          p++;
+          w--;
         }
-      if (!isdigit (*p))
-        goto bad_float;
-        
-      exponent = 10 * exponent + *p - '0';
-      p++;
-      w--;
     }
 
   exponent = exponent * exponent_sign;
@@ -784,12 +806,14 @@ read_f (fnode * f, char *dest, int lengt
 void
 read_x (fnode * f)
 {
-  int n, m;
+  int n;
 
   n = f->u.n;
-  m = (int)current_unit->bytes_left;
-  if (f->format == FMT_X)
-    n = (n > m) ? m : n;
-  if (n)
+
+  if ((current_unit->flags.pad == PAD_NO || is_internal_unit ())
+      && current_unit->bytes_left < n)
+    n = current_unit->bytes_left;
+
+  if (n > 0)
     read_block (&n);
 }
Index: io/transfer.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/transfer.c,v
retrieving revision 1.48
diff -u -3 -p -r1.48 transfer.c
--- io/transfer.c	14 Jul 2005 06:21:58 -0000	1.48
+++ io/transfer.c	21 Jul 2005 09:44:31 -0000
@@ -687,8 +687,8 @@ formatted_transfer (bt type, void *p, in
 	case FMT_TR:
 	  consume_data_flag = 0 ;
 
-	  pos = current_unit->recl - current_unit->bytes_left + f->u.n;
-	  skips = f->u.n;
+	  pos = current_unit->recl - current_unit->bytes_left + f->u.n +skips;
+	  skips = f->u.n + skips;
 	  pending_spaces = pos - max_pos;
 
 	  /* Writes occur just before the switch on f->format, above, so that
@@ -776,6 +776,7 @@ formatted_transfer (bt type, void *p, in
 
 	case FMT_SLASH:
 	  consume_data_flag = 0 ;
+	  skips = pending_spaces = 0;
 	  next_record (0);
 	  break;
 
Index: io/unit.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/unit.c,v
retrieving revision 1.12
diff -u -3 -p -r1.12 unit.c
--- io/unit.c	17 May 2005 17:02:38 -0000	1.12
+++ io/unit.c	21 Jul 2005 09:44:31 -0000
@@ -304,7 +304,7 @@ init_units (void)
       u->flags.access = ACCESS_SEQUENTIAL;
       u->flags.form = FORM_FORMATTED;
       u->flags.status = STATUS_OLD;
-      u->flags.blank = BLANK_ZERO;
+      u->flags.blank = BLANK_UNSPECIFIED;
       u->flags.position = POSITION_ASIS;
 
       u->recl = options.default_recl;
@@ -326,7 +326,7 @@ init_units (void)
       u->flags.access = ACCESS_SEQUENTIAL;
       u->flags.form = FORM_FORMATTED;
       u->flags.status = STATUS_OLD;
-      u->flags.blank = BLANK_ZERO;
+      u->flags.blank = BLANK_UNSPECIFIED;
       u->flags.position = POSITION_ASIS;
 
       u->recl = options.default_recl;
@@ -348,7 +348,7 @@ init_units (void)
       u->flags.access = ACCESS_SEQUENTIAL;
       u->flags.form = FORM_FORMATTED;
       u->flags.status = STATUS_OLD;
-      u->flags.blank = BLANK_ZERO;
+      u->flags.blank = BLANK_UNSPECIFIED;
       u->flags.position = POSITION_ASIS;
 
       u->recl = options.default_recl;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[stevenb at suse dot de]

------- Additional Comments From stevenb at suse dot de  2005-07-21 10:53 -------
Subject: Re:  Null Characters instead of blanks in t extoutput

On Thursday 21 July 2005 12:11, Steven Bosscher wrote:
> Thanks for your efforts.  Sadly these patches still do not fix mgrid :-(

This is a test case for the mgrid problem:

      IMPLICIT NONE
      INTEGER I
      REAL U(3)
      OPEN(UNIT=18, FORM='FORMATTED', STATUS='UNKNOWN')
      WRITE (18,100) (U(I), I=1,3)
100   FORMAT (2X, E15.6)
      CLOSE(UNIT=18)
      END


With the patches from the previous mail applied it now outputs:
========================================
     0.000000E+00
^@^@   0.000000E+00
^@^@   0.597604E-38
========================================
with as usual '^@' == '\0'.

Gr.
Steven



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-22 14:07 -------
Subject: Bug 22570

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pault@gcc.gnu.org	2005-07-22 14:07:20

Modified files:
	libgfortran/io : read.c transfer.c 
	libgfortran    : ChangeLog 

Log message:
	2005-07-22 Jerry DeLisle <jvdelisle@verizon.net>
	
	PR libfortran/21875  (FM111.f)
	* io/read.c (next_char): Return a ' ' character when BLANK_ZERO
	or BLANK_NULL are active.
	(read_decimal): Interpret ' ' character correctly for BZ or BN.
	(read_radix): Interpret ' ' character correctly for BZ or BN.
	(read_f): Interpret ' ' character correctly for BZ or BN.
	
	2005-07-22 Paul Thomas  <pault@gcc.gnu.org>
	
	PR libfortran/22570
	* read.c (read_x): Correct the condition for doing the
	x-editing during formatted input.
	* transfer.c (formatted_transfer): Cast offset difference
	as int, clean-up arithmetic with new variable, bytes_used,
	zero counters for FMT_SLASH,
	(data_transfer_init) Zero X- and T-editing counters
	unconditionally.
	(next_record_w) Zero X- and T-editing counters.
	unconditionally.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/read.c.diff?cvsroot=gcc&r1=1.14&r2=1.15
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&r1=1.48&r2=1.49
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.267&r2=1.268



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-22 17:43 -------
Subject: Bug 22570

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pault@gcc.gnu.org	2005-07-22 17:43:31

Modified files:
	libgfortran/io : unit.c 
	libgfortran    : ChangeLog 

Log message:
	2005-07-22 Jerry DeLisle <jvdelisle@verizon.net>
	
	PR libfortran/22570
	* io/unit.c (init_units): Replace BLANK_ZERO with
	BLANK_UNSPECIFIED.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unit.c.diff?cvsroot=gcc&r1=1.12&r2=1.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.268&r2=1.269



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-22 19:11 -------
Subject: Bug 22570

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	pault@gcc.gnu.org	2005-07-22 19:11:29

Modified files:
	libgfortran/io : read.c transfer.c unit.c 
	libgfortran    : ChangeLog 

Log message:
	2005-07-22 Jerry DeLisle <jvdelisle@verizon.net>
	
	PR libfortran/22570
	* io/unit.c (init_units): Replace BLANK_ZERO with
	BLANK_UNSPECIFIED.
	* io/read.c (next_char): Return a ' ' character when BLANK_ZERO
	or BLANK_NULL are active.
	(read_decimal): Interpret ' ' character correctly for BZ or BN.
	(read_radix): Interpret ' ' character correctly for BZ or BN.
	(read_f): Interpret ' ' character correctly for BZ or BN.
	
	2005-07-22 Paul Thomas  <pault@gcc.gnu.org>
	
	PR libfortran/22570
	* read.c (read_x): Correct the condition for doing the
	x-editing during formatted input.
	* transfer.c (formatted_transfer): Cast offset difference
	as int, clean-up arithmetic with new variable, bytes_used,
	zero counters for FMT_SLASH,
	(data_transfer_init) Zero X- and T-editing counters
	unconditionally.
	(next_record_w) Zero X- and T-editing counters.
	unconditionally.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/read.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8.10.5&r2=1.8.10.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.32.2.9&r2=1.32.2.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/unit.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.8.10.2&r2=1.8.10.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.67&r2=1.163.2.68



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[paulthomas2 at wanadoo dot fr]

------- Additional Comments From paulthomas2 at wanadoo dot fr  2005-07-22 19:19 -------
fixed on mainline and 4.02 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-22 19:20 -------
Fixed so closing.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-30 05:33 -------
Subject: Bug 22570

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pault@gcc.gnu.org	2005-07-30 05:33:40

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/io : transfer.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: x_slash_1.f 

Log message:
	2005-07-30 Paul Thomas  <pault@gcc.gnu.org>
	
	PR fortran/22570 and related issues.
	* transfer.c (formatted_transfer): Make sure that there
	really is data present before X- or T- editing. Move all
	treatment of tabbing during writes to start of next data
	producing format. Suppress incorrect zeroing of bytes_left
	in slash formating. Insert int cast for assignment of a
	difference of two gfc_offsets.
	
	PR fortran/22570 an related issues.
	* gfortran.dg/x_slash_1.f: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.271&r2=1.272
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&r1=1.49&r2=1.50
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5856&r2=1.5857
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/x_slash_1.f.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570

[Bug libfortran/22570] Null Characters instead of blanks in text output.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-30 06:18 -------
Subject: Bug 22570

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	pault@gcc.gnu.org	2005-07-30 06:18:35

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/io : transfer.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: x_slash_1.f 

Log message:
	2005-07-30 Paul Thomas  <pault@gcc.gnu.org>
	
	PR fortran/22570 and related issues.
	* transfer.c (formatted_transfer): Make sure that there
	really is data present before X- or T- editing. Move all
	treatment of tabbing during writes to start of next data
	producing format. Suppress incorrect zeroing of bytes_left
	in slash formating. Insert int cast for assignment of a
	difference of two gfc_offsets.
	
	PR fortran/22570 an related issues.
	* gfortran.dg/x_slash_1.f: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.69&r2=1.163.2.70
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.32.2.10&r2=1.32.2.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.309&r2=1.5084.2.310
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/x_slash_1.f.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22570