[Bug preprocessor/22042] New: stringification BUG

[Bug preprocessor/22042] New: stringification BUG

[s__nakayama at infoseek dot jp]

// test code
#define S(X) S2(X)
#define S2(X) #X
#define TAB "	" /* 0x09 */

S(S(TAB))


// gcc -E -P OUTPUT

"\"\\\"\\011\\\"\""

// expected result

"\"\\\"	\\\"\""


GCC # preprocessing operator converts the non-printable characters to octal.
But this behavior is non standard.

-- 
           Summary: stringification BUG
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: s__nakayama at infoseek dot jp
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-06-13 12:36 -------
I don't see why this is really a bug because if you output the string, it will look the same.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[s__nakayama at infoseek dot jp]

------- Additional Comments From s__nakayama at infoseek dot jp  2005-06-14 07:20 -------
(In reply to comment #1)
Hmm, it does't look the same.

// test code
#define S(X) S2(X)
#define S2(X) #X
#define TAB "	" /* 0x09 */

main()
{
  puts(S(S(TAB)));
}

// GCC 4.0.0 result
"\"\011\""

// GCC 2.95.3 result(expected result)
"\"	\""



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[s__nakayama at infoseek dot jp]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.0.4 3.2.3 3.3.3 3.3.6
                   |                            |3.4.4 4.0.0
      Known to work|                            |2.95.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[s__nakayama at infoseek dot jp]

------- Additional Comments From s__nakayama at infoseek dot jp  2005-06-23 15:35 -------
(In reply to comment #1)
> I don't see why this is really a bug because if you output the string, it 
will look the same.

NO! Your guess is wrong.
I never report, if the output always looks the same.
I wrote the sample if you output the string, it do not look the same.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-09 16:29 -------
Huh? I cannot reproduce it at all.
with all of the versions of GCC I tried from 2.95.3 to 4.1.0 I get the following:
"\"\\\"   \\\"\""


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[s__nakayama at infoseek dot jp]

------- Additional Comments From s__nakayama at infoseek dot jp  2005-07-09 18:23 -------
(In reply to comment #4)
> Huh? I cannot reproduce it at all.
> with all of the versions of GCC I tried from 2.95.3 to 4.1.0 I get the 
following:
> "\"\\\"   \\\"\""

Did you confirm there was a tab in the string?
I consider that your code is the tab has been converted into space.
If there is a tab in the string,
try the string including other suitable non-printable character.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-09 18:32 -------
The relevant part of the standard (C99: 6.10.3.2P2)
Otherwise, the original spelling of each preprocessing token in the argument is retained in the 
character string literal, except for special handling for producing the spelling of string literals and 
character constants: a\character is inserted before each" and \character of a character constant or 
string literal (including the delimiting " characters), except that it is implementation-defined whether 
a\character is inserted before the\character beginning a universal character name. If the replacement 
that results is not a valid character string literal, the behavior is undefined. The character string literal 
corresponding to an empty argument is ""

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
            Summary|stringification BUG         |[3.4/4.0/4.1 Regression]
                   |                            |stringification BUG
   Target Milestone|---                         |3.4.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-22 21:13 -------
Moving to 4.0.2 pre Mark.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.5                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #18 from pinskia at gcc dot gnu dot org  2005-11-04 00:28 -------
Fixed in 4.0.3.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #19 from pinskia at gcc dot gnu dot org  2005-11-04 00:28 -------
Subject: Bug 22042

Author: pinskia
Date: Fri Nov  4 00:28:39 2005
New Revision: 106465

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106465
Log:
2005-11-03  Andrew Pinski  <pinskia@physics.uc.edu>

        PR preprocessor/22042
        * macro.c (_cpp_builtin_macro_text): Lower the needed max
        buffer size.
        (cpp_quote_string): Don't octalify non printable
        charactors.
2005-11-03  Andrew Pinski  <pinskia@physics.uc.edu>

        PR preprocessor/22042
        * gcc.dg/cpp/strify4.c: New test.


Added:
    branches/gcc-4_0-branch/gcc/testsuite/gcc.dg/cpp/strify4.c
      - copied unchanged from r106463, trunk/gcc/testsuite/gcc.dg/cpp/strify4.c
Modified:
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_0-branch/libcpp/ChangeLog
    branches/gcc-4_0-branch/libcpp/macro.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #17 from pinskia at gcc dot gnu dot org  2005-11-04 00:23 -------
Subject: Bug 22042

Author: pinskia
Date: Fri Nov  4 00:23:01 2005
New Revision: 106463

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106463
Log:
2005-11-03  Andrew Pinski  <pinskia@physics.uc.edu>

        PR preprocessor/22042
        * macro.c (_cpp_builtin_macro_text): Lower the needed max
        buffer size.
        (cpp_quote_string): Don't octalify non printable
        charactors.
2005-11-03  Andrew Pinski  <pinskia@physics.uc.edu>

        PR preprocessor/22042
        * gcc.dg/cpp/strify4.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/cpp/strify4.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libcpp/ChangeLog
    trunk/libcpp/macro.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[joseph at codesourcery dot com]

------- Comment #16 from joseph at codesourcery dot com  2005-11-04 00:05 -------
Subject: Re:  [3.4/4.0/4.1 Regression] stringification
 BUG

On Thu, 3 Nov 2005, mmitchel at gcc dot gnu dot org wrote:

> Joseph, you're probably the person who best understands the behavior required
> by the standard.  
> 
> Since Per writes:
> 
> "I don't know enough about fine points of the standard to say what is
> right.  If you and Andrew think it is right, I'm ok with it."
> 
> would you mind reviewing the patch?  Andrew, if Joseph approves the patch, it
> is OK. 

Except for some laxity in the handling of UCNs (for C but not for C++) the 
standards exactly define how the spelling of a token translates into the 
spelling of the result of applying # to it, and there is nothing to allow 
the conversion to octal; this patch is correct.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[mmitchel at gcc dot gnu dot org]

------- Comment #15 from mmitchel at gcc dot gnu dot org  2005-11-03 23:49 -------
Joseph, you're probably the person who best understands the behavior required
by the standard.  

Since Per writes:

"I don't know enough about fine points of the standard to say what is
right.  If you and Andrew think it is right, I'm ok with it."

would you mind reviewing the patch?  Andrew, if Joseph approves the patch, it
is OK. 


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joseph at codesourcery dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[mmitchel at gcc dot gnu dot org]

------- Comment #14 from mmitchel at gcc dot gnu dot org  2005-10-31 03:46 -------
Leaving as P2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2005-10-27 19:36 -------
Patch submitted: <http://gcc.gnu.org/ml/gcc-patches/2005-10/msg01583.html>.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |10/msg01583.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2005-10-27 14:33 -------
I will relook at this and post it soon.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2005-10-22 21:53 -------
Sorry but my machine went bonkers and I cannot submit this.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pinskia at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2005-10-18 23:39 -------
I have a fix for the preprocessor which I need to test.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2005-10-17 23:02 -------
Confirmed a bug by Neil Booth on IRC.  This sounds like this was added by Zack
too.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-10-17 23:02:10
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042

[Bug preprocessor/22042] [3.4/4.0/4.1 Regression] stringification BUG

[steven at gcc dot gnu dot org]

------- Comment #8 from steven at gcc dot gnu dot org  2005-10-17 09:29 -------
What is the deal here?  Is there a bug, or not?  If so, can someone
confirm the bug, and otherwise close it as invalid?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22042