public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ.
@ 2005-07-15 17:23 reichelt at gcc dot gnu dot org
  2005-07-15 17:28 ` [Bug fortran/22503] " pinskia at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2005-07-15 17:23 UTC (permalink / raw)
  To: gcc-bugs

Consider the following code snippet:

===========================
       subroutine FOO
         logical I
         I = I .eq. I
       end subroutine FOO
===========================

g77 used to give the following error message with the suggesiton what to do:

test.f: In subroutine `foo':
test.f:3: 
            I = I .eq. I
                1 2    3
Use .EQV./.NEQV. instead of .EQ./.NE. at (2) for LOGICAL operands at (1) and (3)

gfortran only gives:

 In file test.f90:3

         I = I .eq. I
            1
Error: Operands of comparison operator '.eq.' at (1) are LOGICAL(4)/LOGICAL(4)


A suggestion to use .EQV./.NEQV. instead would be nice (especially since
other compilers accept the code without modification).

-- 
           Summary: Suggest to use .EQV. when comparing logicals with .EQ.
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: enhancement
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/22503] Suggest to use .EQV. when comparing logicals with .EQ.
  2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
@ 2005-07-15 17:28 ` pinskia at gcc dot gnu dot org
  2005-07-26 18:34 ` reichelt at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-07-15 17:28 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-15 17:23 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-15 17:23:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/22503] Suggest to use .EQV. when comparing logicals with .EQ.
  2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
  2005-07-15 17:28 ` [Bug fortran/22503] " pinskia at gcc dot gnu dot org
@ 2005-07-26 18:34 ` reichelt at gcc dot gnu dot org
  2005-07-27  8:40 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2005-07-26 18:34 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2005-07-26 18:33 -------
Testing a patch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/22503] Suggest to use .EQV. when comparing logicals with .EQ.
  2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
  2005-07-15 17:28 ` [Bug fortran/22503] " pinskia at gcc dot gnu dot org
  2005-07-26 18:34 ` reichelt at gcc dot gnu dot org
@ 2005-07-27  8:40 ` cvs-commit at gcc dot gnu dot org
  2005-07-27  8:41 ` cvs-commit at gcc dot gnu dot org
  2005-07-27  8:54 ` reichelt at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-27  8:40 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-27 08:30 -------
Subject: Bug 22503

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	reichelt@gcc.gnu.org	2005-07-27 08:30:47

Modified files:
	gcc/fortran    : ChangeLog resolve.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: logical_comp.f90 

Log message:
	PR fortran/22503
	* resolve.c (resolve_operator): Improve diagnostic for comparison
	of logicals with invalid operator.
	
	* gfortran.dg/logical_comp.f90: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.502&r2=1.503
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/resolve.c.diff?cvsroot=gcc&r1=1.46&r2=1.47
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5826&r2=1.5827
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/logical_comp.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/22503] Suggest to use .EQV. when comparing logicals with .EQ.
  2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2005-07-27  8:40 ` cvs-commit at gcc dot gnu dot org
@ 2005-07-27  8:41 ` cvs-commit at gcc dot gnu dot org
  2005-07-27  8:54 ` reichelt at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-27  8:41 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-27 08:39 -------
Subject: Bug 22503

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	reichelt@gcc.gnu.org	2005-07-27 08:39:46

Modified files:
	gcc/fortran    : ChangeLog resolve.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: logical_comp.f90 

Log message:
	PR fortran/22503
	* resolve.c (resolve_operator): Improve diagnostic for comparison
	of logicals with invalid operator.
	
	* gfortran.dg/logical_comp.f90: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.335.2.95&r2=1.335.2.96
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/resolve.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.34.2.11&r2=1.34.2.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.302&r2=1.5084.2.303
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/logical_comp.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug fortran/22503] Suggest to use .EQV. when comparing logicals with .EQ.
  2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2005-07-27  8:41 ` cvs-commit at gcc dot gnu dot org
@ 2005-07-27  8:54 ` reichelt at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2005-07-27  8:54 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2005-07-27 08:41 -------
Fixed on mainline and 4.0 branch (for 4.0.2).


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/fortra
                   |                            |n/2005-07/msg00416.html
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22503


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-07-27  8:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-15 17:23 [Bug fortran/22503] New: Suggest to use .EQV. when comparing logicals with .EQ reichelt at gcc dot gnu dot org
2005-07-15 17:28 ` [Bug fortran/22503] " pinskia at gcc dot gnu dot org
2005-07-26 18:34 ` reichelt at gcc dot gnu dot org
2005-07-27  8:40 ` cvs-commit at gcc dot gnu dot org
2005-07-27  8:41 ` cvs-commit at gcc dot gnu dot org
2005-07-27  8:54 ` reichelt at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).