[Bug fortran/21470] New: mark subroutine arguments __restrict__

[Bug fortran/21470] New: mark subroutine arguments __restrict__

[tkoenig at gcc dot gnu dot org]

Fortran subroutine arguments should be marked as
__restrict__.  Currently, the following code isn't
vectorized:

$ cat loopsum.f90
subroutine foo(a,b,c,n)
  real, dimension(n), intent(in) :: a,b
  real, dimension(n), intent(out) :: c
  do i=1,n
    c(i) = a(i)+b(i)
  end do
end
$ gfortran -O -S -ftree-vectorize -ftree-vectorizer-verbose=5 loopsum.f90

loopsum.f90:4: note: not vectorized: can't determine dependence between: (*a_18)
[D.527_17] and (*c_25)[D.527_17]
loopsum.f90:1: note: vectorized 0 loops in function.
$ gfortran -v
Using built-in specs.
Target: ia64-unknown-linux-gnu
Configured with: ../gcc-4.1-20050508/configure --prefix=/home/zfkts --enable-
languages=c,f95
Thread model: posix
gcc version 4.1.0 20050508 (experimental)

-- 
           Summary: mark subroutine arguments __restrict__
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug fortran/21470] mark subroutine arguments __restrict__

[tkoenig at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-09 14:53 -------
Actually -fargument-noalias-global is set to true for fortran and should be respected instead of 
marking them as restrict.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|fortran                     |tree-optimization
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-09 14:53:51
               date|                            |
            Summary|mark subroutine arguments   |-fargument-noalias-global
                   |__restrict__                |has no effect for the
                   |                            |vectorizer


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-09 15:54 -------
If the aliasing information is correct on the VOPS, I would assume that the vectorizer would not have 
problems with it.

Note there is another bug about this option, see PR 17064.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
  BugsThisDependsOn|                            |17064
           Keywords|                            |alias


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-06 19:47 -------
I have a fix which I need to bootstrap/test.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-01-26 17:51 -------
Subject: Bug 21470

Author: pinskia
Date: Thu Jan 26 17:51:25 2006
New Revision: 110263

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110263
Log:
2006-01-26  Richard Guenther  <rguenther@suse.de>
            Andrew Pinski  <pinskia@physics.uc.edu>

        PR tree-opt/21470
        partial PR tree-opt/17064
        * tree-ssa-structalias.c (intra_create_variable_infos):
        Create heap variables for incoming parameters if
        flag_argument_noalias > 1.
        (find_what_p_points_to): Look through default defs of
        parameter decls.


Modified:
    trunk/gcc/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-01-26 17:50 -------
Fixed applied.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-01-16 17:09 -------
Patch posted: http://gcc.gnu.org/ml/gcc-patches/2006-01/msg00864.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |01/msg00864.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-01-10 20:31 -------
I have a fix which comes from Richard Guenther and modified for
-fargument-noalias-global instead of restrict as it was using the wrong test.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470

[Bug tree-optimization/21470] -fargument-noalias-global has no effect for the vectorizer

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-10-05 13:20 -------
Talked to Daniel Berlin about the patch I had, it was in the wrong spot, I had
it in the post process and not when analyzing the code.  So unassigning for
now.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pinskia at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21470