[Bug tree-optimization/22525] New: tree based value profiling (-fprofile-use) produces mismatch types in conditional

[Bug tree-optimization/22525] New: tree based value profiling (-fprofile-use) produces mismatch types in conditional

[pinskia at gcc dot gnu dot org]

The testcase is gcc.dg/tree-prof/val-prof-2.c.  It only happens when profile use is used.
Note this is worse if we use unsigned long long instead as we get a size mismatch.
See PR 22368 for the patch to catch this (the second patch):

/Users/pinskia/src/local/gcc/gcc/testsuite/gcc.dg/tree-prof/val-prof-2.c: In function 'main':^M
/Users/pinskia/src/local/gcc/gcc/testsuite/gcc.dg/tree-prof/val-prof-2.c:25: error: types mismatch in 
comparsion^M
unsigned intD.3^M
intD.0^M
PROF.4D.1300 != 0;^M
^M
/Users/pinskia/src/local/gcc/gcc/testsuite/gcc.dg/tree-prof/val-prof-2.c:25: internal compiler error: 
verify_stmts failed^M
Please submit a full bug report,^M
with preprocessed source if appropriate.^M
See <URL:http://gcc.gnu.org/bugs.html> for instructions.^M

-- 
           Summary: tree based value profiling (-fprofile-use) produces
                    mismatch types in conditional
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
OtherBugsDependingO 22368
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-17 17:53 -------
Created an attachment (id=9295)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9295&action=view)
patch which I need to test (from Honza)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-08 03:18 -------
Confirmed, will test the patch now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-08 03:18:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-08 12:31 -------
And yes the patch fixes the bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2006-04-19 08:39 -------
I have a patch (and found this bug "too late").


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-11-11 18:23:35         |2006-04-19 08:39:25
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2006-04-24 07:58 -------
Subject: Bug 22525

Author: rguenth
Date: Mon Apr 24 07:58:53 2006
New Revision: 113216

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113216
Log:
2006-04-24  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/22525
        * value-prof.c (tree_mod_pow2): Remove unnecessary temporary
        variable, adjust types of generated expressions.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/value-prof.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2006-04-24 08:36 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[brett dot albertson at stratech dot com]

------- Comment #7 from brett dot albertson at stratech dot com  2006-04-25 19:29 -------
(In reply to comment #6)
> Fixed.
> 

After this patch was applied onto trunk, the following test started failing on
Solaris x86:

FAIL: gcc.dg/tree-prof/val-prof-2.c scan-tree-dump n \+ \-1

All the other val-prof-2.c tests PASS.  Any ideas?

Brett Albertson


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525

[Bug tree-optimization/22525] tree based value profiling (-fprofile-use) produces mismatch types in conditional

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2006-04-26 07:59 -------
Sorry, I fixed that in a followup.  -1 is now unsigned and so appears as n +
fffffffffff.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22525