[Bug middle-end/23401] New: Gimplifier produces too many temporaries

[Bug middle-end/23401] New: Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

Take the following code:
struct f
{
  struct {
   int i;
  } ff[10];
};

struct f g;
int ffff(int i)
{
  int t1 = 0;
  int i1 = g.ff[t1].i;
  int i2 = g.ff[i].i;
  return i1 + i2;
}

The gimplfiier will produce at -O0:
  int i.0;
  int t1.1;
  int D.1289;
  int t1;
  int i1;
  int i2;

  t1 = 0;
  i.0 = i;
  i1 = g.ff[i.0].i;
  t1.1 = t1;
  i2 = g.ff[t1.1].i;
  D.1289 = i1 + i2;
  return D.1289;

Notice how there is a t1.0 and i.0, there should not be there as i and t1 are already gimple variables.
This might produce a nice speed up for some testcase but I don't know.  at -O0, there will be less 
registers to be allocated so reload should not be as high as before.

-- 
           Summary: Gimplifier produces too many temporaries
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-15 15:21 -------
For PR 8361, there are about 14 places where this happens.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-15 15:24 -------
In PR15855, there are a lot more, at about 874.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-15 15:43 -------
Hmm, I think this FIXME has something to do with it:
	  /* Gimplify the dimension.
	     Temporary fix for gcc.c-torture/execute/20040313-1.c.
	     Gimplify non-constant array indices into a temporary
	     variable.
	     FIXME - The real fix is to gimplify post-modify
	     expressions into a minimal gimple lvalue.  However, that
	     exposes bugs in alias analysis.  The alias analyzer does
	     not handle &PTR->FIELD very well.  Will fix after the
	     branch is merged into mainline (dnovillo 2004-05-03).  */

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-31 16:04 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-31 16:04:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-12-18 01:03 -------
This never got fixed after the tree-ssa branch was merged into the mainline so
ping Diego.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2007-07-09 06:00 -------
Alias analysis can handle &a->b now and we also fold during forwprop * &a->b
into a->b so it might be a good idea to have this fixed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2008-12-07 12:03 -------
Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |12/msg00415.html
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
   Last reconfirmed|2005-08-31 16:04:05         |2008-12-07 12:03:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-03-31 10:23 -------
Subject: Bug 23401

Author: rguenth
Date: Tue Mar 31 10:23:44 2009
New Revision: 145338

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145338
Log:
2009-03-31  Richard Guenther  <rguenther@suse.de>

        PR middle-end/23401
        PR middle-end/27810
        * tree.h (DECL_GIMPLE_FORMAL_TEMP_P): Remove.
        (struct tree_decl_with_vis): Remove gimple_formal_temp member.
        * tree-eh.c (lower_eh_constructs_2): Move LHS assignment to
        a separate statement.
        * gimplify.c (pop_gimplify_context): Remove formal temp handling.
        (lookup_tmp_var): Likewise.
        (is_gimple_formal_tmp_or_call_rhs): Remove.
        (is_gimple_reg_or_call_rhs): Rename to ...
        (is_gimple_reg_rhs_or_call): ... this.
        (is_gimple_mem_or_call_rhs): Rename to ...
        (is_gimple_mem_rhs_or_call): ... this.
        (internal_get_tmp_var): Use is_gimple_reg_rhs_or_call.  Set
        DECL_GIMPLE_REG_P only if is_formal is true.
        (gimplify_compound_lval): Use is_gimple_reg.  Remove workaround
        for non-proper post-modify expression gimplification.
        (gimplify_self_mod_expr): For post-modify expressions gimplify
        the lvalue to a minimal lvalue.
        (rhs_predicate_for): Remove formal temp case.
        (gimplify_modify_expr_rhs): Likewise.
        (gimplify_addr_expr): Use is_gimple_reg.
        (gimplify_expr): Remove formal temp cases.
        (gimple_regimplify_operands): Likewise.
        * tree-ssa-pre.c (get_or_alloc_expr_for): Treat EXC_PTR_EXPR
        and FILTER_EXPR like constants.
        * gimple.c (walk_gimple_op): Fix val_only initialization, use
        is_gimple_reg.
        (is_gimple_formal_tmp_rhs): Remove.
        (is_gimple_reg_rhs): Remove special casing.
        (is_gimple_mem_rhs): Fix.
        (is_gimple_reg): Move DECL_GIMPLE_REG_P handling earlier.
        (is_gimple_formal_tmp_var): Remove.
        (is_gimple_formal_tmp_reg): Likewise.
        (is_gimple_min_lval): Allow invariant component ref parts.
        * gimple.h (is_gimple_formal_tmp_rhs, is_gimple_formal_tmp_var,
        is_gimple_formal_tmp_reg): Remove declarations.
        * tree-cfg.c (verify_expr): Verify that variables with address
        taken do not have DECL_GIMPLE_REG_P set.
        * tree-mudflap.c (mf_build_check_statement_for): Use
        force_gimple_operand instead of gimplify_expr.

        java/
        * java-gimplify.c (java_gimplify_expr): Do not manually gimplify
        the first operand of binary and comaprison expressions.

        * gcc.dg/tree-ssa/pr23401.c: New testcase.
        * gcc.dg/tree-ssa/pr27810.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr23401.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr27810.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple.c
    trunk/gcc/gimple.h
    trunk/gcc/gimplify.c
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/java-gimplify.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-cfg.c
    trunk/gcc/tree-eh.c
    trunk/gcc/tree-mudflap.c
    trunk/gcc/tree-ssa-pre.c
    trunk/gcc/tree.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401

[Bug middle-end/23401] Gimplifier produces too many temporaries

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2009-03-31 10:31 -------
Fixed.  No assembly differences for the testcase though.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23401