[Bug target/23473] New: ICE at config/arm/arm.c:3280

[Bug target/23473] New: ICE at config/arm/arm.c:3280

[kazu at gcc dot gnu dot org]

Consider

struct s {
  unsigned a : 1;
};

int
foo (struct s *p, int b, int c, int d)
{
  p->a = 0;
  return b;
}

"./cc1 -quiet -O2 -mthumb -fPIC min.c" gives me

min.c: In function 'foo':
min.c:10: internal compiler error: in thumb_find_work_register, at
config/arm/arm.c:3280
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

This testcase is reduced from libiberty/regex.c.

-- 
           Summary: ICE at config/arm/arm.c:3280
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kazu at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: arm-none-eabi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] ICE at config/arm/arm.c:3280

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-19 02:40 -------
  /* Something went wrong - thumb_compute_save_reg_mask()
     should have arranged for a suitable register to be pushed.  */
  gcc_unreachable ();



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] [4.1 Regression] ICE at config/arm/arm.c:3280

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-19 02:53 -------
Seems like it was caused by:

        PR target/23355
        * arm.c (thumb_compute_save_reg_mask): Use similar logic to
        arm_compure_save_reg0_reg12_mask to determine when the PIC register
        must be saved.

----

Confirmed, it worked a little bit ago.  Also it fails on arm-linux-gnu.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rearnsha at gcc dot gnu dot
                   |                            |org, pinskia at gcc dot gnu
                   |                            |dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|arm-none-eabi               |arm-none-eabi, arm-linux-gnu
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-19 02:53:59
               date|                            |
            Summary|ICE at config/arm/arm.c:3280|[4.1 Regression] ICE at
                   |                            |config/arm/arm.c:3280
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] [4.1 Regression] ICE at config/arm/arm.c:3280

[kazu at gcc dot gnu dot org]

------- Additional Comments From kazu at gcc dot gnu dot org  2005-08-19 03:11 -------
In fact, reverting Richard Earnshaw's patch

2005-08-15  Richard Earnshaw  <richard.earnshaw@arm.com>

        PR target/23355
        * arm.c (thumb_compute_save_reg_mask): Use similar logic to
        arm_compure_save_reg0_reg12_mask to determine when the PIC register
        must be saved.

fixes the problem (although simply reverting the patch is probably not a
good idea because it's supposed to fix PR 23355).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] [4.1 Regression] ICE at config/arm/arm.c:3280

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2005-08-19 09:44 -------
OK.  I think I understand what's failing here.  Testing patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rearnsha at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] [4.1 Regression] ICE at config/arm/arm.c:3280

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-19 13:17 -------
Subject: Bug 23473

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rearnsha@gcc.gnu.org	2005-08-19 13:17:04

Modified files:
	gcc            : ChangeLog 
	gcc/config/arm : arm.c arm-protos.h 

Log message:
	PR target/23473
	* arm.md (arm_load_pic_register): Change argument to the mask of
	saved registers.  Call thumb_find_work_register if we need a
	scratch register on Thumb.
	(arm_expand_prologue): Pass empty register set to
	arm_load_pic_register.
	(thumb_expand_prologue): Pass live_regs_mask directly to
	arm_load_pic_register.
	* arm-protos.h (arm_load_pic_register): Update prototype.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9780&r2=2.9781
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/arm/arm.c.diff?cvsroot=gcc&r1=1.474&r2=1.475
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/arm/arm-protos.h.diff?cvsroot=gcc&r1=1.90&r2=1.91



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473

[Bug target/23473] [4.1 Regression] ICE at config/arm/arm.c:3280

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2005-08-19 13:17 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23473