[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-08-18 04:09 -------
 Thomas, do you intend on mailing this patch to gcc-patches?  It should be small
enough not to require a copyright assignment.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-19 06:01 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-19 06:01:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-19 11:35 -------
PR 23361 is the bug about unrolling the loops.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |23361


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[dank at kegel dot com]

------- Additional Comments From dank at kegel dot com  2005-08-22 06:33 -------
Yes, Tommy mailed the patch, see
http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01195.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[dank at kegel dot com]

------- Additional Comments From dank at kegel dot com  2005-08-22 06:34 -------
I think the patch applies cleanly to gcc-4.0.x;
it's so small, seems like the target for this bug
ought to be gcc-4.0.2.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dank at kegel dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[tkho at ucla dot edu]

------- Additional Comments From tkho at ucla dot edu  2005-08-22 20:38 -------
I want to note that a benchmark built with -funsafe-loop-optimizations turns up
being slower AFTER fixing the typo (and enabling the specialization), so the
specialization code should definitely be removed as soon as gcc can get rid of
empty loops.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-23 10:40 -------
Subject: Bug 23358

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2005-08-23 10:40:14

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: stl_construct.h 

Log message:
	2005-08-23  Thomas Kho  <tkho@ucla.edu>
	
	PR libstdc++/23358
	* include/bits/stl_construct.h (_Destroy(_ForwardIterator,
	_ForwardIterator, allocator<_Tp>)): Removed unused template parameter.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3074&r2=1.3075
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_construct.h.diff?cvsroot=gcc&r1=1.21&r2=1.22



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-24 02:16 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-07 16:30 -------
Subject: Bug 23358

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	paolo@gcc.gnu.org	2005-09-07 16:30:38

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: stl_construct.h 

Log message:
	2005-09-07  Thomas Kho  <tkho@ucla.edu>
	
	PR libstdc++/23358
	* include/bits/stl_construct.h (_Destroy(_ForwardIterator,
	_ForwardIterator, allocator<_Tp>)): Removed unused template parameter.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2917.2.78&r2=1.2917.2.79
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_construct.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.20&r2=1.20.6.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-09-07 16:32 -------
Fixed for 4.0.2 too.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[chris at bubblescope dot net]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bubblescope dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[fang at csl dot cornell dot edu]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fang at csl dot cornell dot
                   |                            |edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[chris at bubblescope dot net]

------- Additional Comments From chris at bubblescope dot net  2005-08-12 18:34 -------
Yep, it's the extra template parameter which is confusing the compiler. If you have parameters it can't 
deduce from the input to a function, they must be given explicitly, so in this case that function is just 
ignored. This has been wrong since it was submitted (version 1.19 of the file). Removing that extra 
template parameter is the right thing to do. I had a quick look at other functions submitted at the same 
time and they are fine, so it's just a copy+paste bug I suspect :)

Hopefully gcc will eventually get clever enough to remove empty loops by itself, and then we won't need 
these types of hacks, but for now this is the right patch to apply.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[tkho at tommykho dot com]

------- Additional Comments From tkho at tommykho dot com  2005-08-12 18:10 -------
Created an attachment (id=9483)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9483&action=view)
Testcase

Comparing the reported time before and after the proposed fix results in orders
of magnitude speedup.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358

[Bug libstdc++/23358] _Destroy doesn't optimize for scalar types

[tkho at tommykho dot com]

------- Additional Comments From tkho at tommykho dot com  2005-08-12 18:05 -------
Created an attachment (id=9482)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9482&action=view)
Fix for _Destroy

It looks like the extra template parameter confuses the compiler. I'm pretty
new--should extra template parameters be ignored by the compiler?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23358