[Bug target/23463] New: [4.1 Regression] va-arg-22.c execution fails

[Bug target/23463] New: [4.1 Regression] va-arg-22.c execution fails

[jsm28 at gcc dot gnu dot org]

FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O0 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O1 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O2 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O3 -fomit-frame-pointer 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O3 -fomit-frame-pointer
-funroll-all-loops -finline-functions 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O3 -fomit-frame-pointer
-funroll-loops 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -O3 -g 
FAIL: gcc.c-torture/execute/va-arg-22.c execution,  -Os 

have appeared on mainline between 20050816 and 20050817 on hppa2.0w-hp-hpux11.11
and hppa64-hp-hpux11.11, gcc-testresults shows them also on hppa-linux.

-- 
           Summary: [4.1 Regression] va-arg-22.c execution fails
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: hppa*-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[danglin at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-08-24 04:27 -------
I got this failure on ppc-linux as well.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-24 04:27:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[phython at gcc dot gnu dot org]

------- Additional Comments From phython at gcc dot gnu dot org  2005-08-24 05:46 -------
 This looks to be a problem on sparc too:
http://gcc.gnu.org/ml/gcc-testresults/2005-08/msg01257.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phython at gcc dot gnu dot
                   |                            |org
 GCC target triplet|hppa*-*-*                   |hppa*-*-*, powerpc-*-linux,-
                   |                            |gnu sparc*-*-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-25 22:58 -------
This was caused by my patch:
>       * gimplify.c (zero_sized_type): New function.
>       (gimplify_modify_expr_rhs): If we have a zero sized type,
>       replace the statement with an empty statement.

I had forgot that you could get the side effects on either side of the assignment.

See http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01444.html

note I think we should only expand the side effects and not the assignment.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-25 22:59 -------
CCing alan since he supplied the info.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-26 01:40 -------
Here is a testcase which fails on all targets which shows a testcase where both sides have side effects:
struct g{};
char y[3];
char *f = &y[0];
char *ff = &y[0];
void h(void)
{
  *((struct g*)(f++)) = *((struct g*)(ff++));
}

void abort (void);

int main(void)
{
  h();
  if (f != &y[1])
    abort();
  if (ff != &y[1])
    abort();
}

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|pass via ref zero sized     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-26 01:42 -------
Mine since I caused it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-26 02:25 -------
Here is a full testcase:
struct g{};
char y[3];
char *f = &y[0];
char *ff = &y[0];
void h(void)
{
  struct g t;
  *((struct g*)(f++)) = *((struct g*)(ff++));
  *((struct g*)(f++)) = (struct g){};
  t = *((struct g*)(ff++));
}

void abort (void);

int main(void)
{
  h();
  if (f != &y[2])
    abort();
  if (ff != &y[2])
    abort();
}

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug target/23463] [4.1 Regression] va-arg-22.c execution fails

[amodra at bigpond dot net dot au]

------- Additional Comments From amodra at bigpond dot net dot au  2005-08-26 07:55 -------
Unfortunately the patch causes gcc.c-torture/compile/920928-5.c to fail on
powerpc-linux.  Infinite recursion in gimplify_expr.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |target


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug middle-end/23463] [4.1 Regression] va-arg-22.c execution fails

[amodra at bigpond dot net dot au]

------- Additional Comments From amodra at bigpond dot net dot au  2005-08-27 06:18 -------
bootstrapped and regression tested powerpc-linux, all languages except ada.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug middle-end/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-27 15:41 -------
Patch posted here: <http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01632.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |08/msg01632.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug middle-end/23463] [4.1 Regression] va-arg-22.c execution fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-27 21:37 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463

[Bug middle-end/23463] [4.1 Regression] va-arg-22.c execution fails

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-27 21:38 -------
Subject: Bug 23463

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2005-08-27 21:37:53

Modified files:
	gcc            : ChangeLog gimplify.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.c-torture/execute: zero-struct-1.c 

Log message:
	2005-08-27  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR middle-end/23463
	* gimplify.c (gimplify_modify_expr_rhs): Remove check for zero sized
	types.
	(gimplify_modify_expr): Check for zero sized types and gimplify the
	rhs and lhs as statements.
	
	2005-08-27  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR middle-end/23463
	* gcc.c-torture/execute/zero-struct-1.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9840&r2=2.9841
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/gimplify.c.diff?cvsroot=gcc&r1=2.148&r2=2.149
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5970&r2=1.5971
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/zero-struct-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23463