[Bug libstdc++/23465] New: Assignment fails on TR1 unordered containers

[Bug libstdc++/23465] New: Assignment fails on TR1 unordered containers

[chris at bubblescope dot net]

 

-- 
           Summary: Assignment fails on TR1 unordered containers
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: chris at bubblescope dot net
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[chris at bubblescope dot net]

------- Additional Comments From chris at bubblescope dot net  2005-08-18 17:26 -------
The following simple piece of code fails to compile.

#include <tr1/unordered_set>

int main(void)
{
  std::tr1::unordered_set<int> i,j;
 i = j;
}

The error is in fact in <tr1/hashtable>, and as all the unordered containers inherit from here, the bug 
is in all of them.

There are two main reasons for this lack of compiling.

Firstly, hash_code_base::m_swap calls m_swap on various elements, most of which don't have a swap 
member function. Changing these calls to swap fixes that, and does what the code should.

The second compilation error is on line 1275,  hashtable::hashtable, where the member function 
copy_code_from is called on a pointer. I'm not however sure what this function is supposed to do. If no 
hashtable experts pop up, I intend to try to figure out how this functions works and how it should..

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-08-23 09:57 -------
Thanks Chris. I will work on this issue.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pcarlini at suse dot de
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-23 09:57:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-24 15:00 -------
Subject: Bug 23465

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2005-08-24 15:00:20

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/tr1: hashtable 
Added files:
	libstdc++-v3/testsuite/tr1/6_containers/unordered/hashtable: 
	                                                             23465.cc 

Log message:
	2005-08-24  Paolo Carlini  <pcarlini@suse.de>
	Chris Jefferson  <chris@bubblescope.net>
	
	PR libstdc++/23465
	* include/tr1/hashtable (hash_code_base::m_swap): Use
	std::swap.
	(hashtable<>::hashtable(const hashtable&)): Use copy_code;
	fix m_allocate_node call.
	* testsuite/tr1/6_containers/unordered/hashtable/23465.cc: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3076&r2=1.3077
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/tr1/hashtable.diff?cvsroot=gcc&r1=1.6&r2=1.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/tr1/6_containers/unordered/hashtable/23465.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[pcarlini at suse dot de]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-25 08:26 -------
Subject: Bug 23465

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	paolo@gcc.gnu.org	2005-08-25 08:26:18

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/tr1: hashtable 
Added files:
	libstdc++-v3/testsuite/tr1/6_containers/unordered/hashtable: 
	                                                             23465.cc 

Log message:
	2005-08-25  Paolo Carlini  <pcarlini@suse.de>
	Chris Jefferson  <chris@bubblescope.net>
	
	PR libstdc++/23465
	* include/tr1/hashtable (hash_code_base::m_swap): Use
	std::swap.
	(hashtable<>::hashtable(const hashtable&)): Use copy_code;
	fix m_allocate_node call.
	* testsuite/tr1/6_containers/unordered/hashtable/23465.cc: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2917.2.71&r2=1.2917.2.72
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/tr1/hashtable.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3.4.1&r2=1.3.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/tr1/6_containers/unordered/hashtable/23465.cc.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465

[Bug libstdc++/23465] Assignment fails on TR1 unordered containers

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-08-25 08:27 -------
Fixed for 4.0.2.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23465