[Bug c++/23586] New: [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[Bug c++/23586] New: [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[reichelt at gcc dot gnu dot org]

For an invalid code snippet like

  int i;
  namespace N = i;

we issue the error message

  bug.cc:2: error: expected namespace-name before ';' token
  bug.cc:2: error: unknown namespace '<declaration error>'

with the not very helpful '<declaration error>'.

The situation for the code snippet

  int i;
  using namespace i;

is similar. Here we get the error message:

  bug.cc:2: error: expected namespace-name before ';' token
  bug.cc:2: error: '<type error>' is not a namespace

With the old parser we got

  bug.cc:2: error: unknown namespace `i'

resp.

  bug.cc:2: error: namespace `i' undeclared

so this qualifies as a diagnostic regression.

I'll post a patch soon.

-- 
           Summary: [3.4/4.0/4.1 regression] Bad diagnostic for invalid
                    namespace-name
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-26 22:20 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-26 22:20:02
               date|                            |
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-26 22:21 -------
Btw, the problem is related to PR13377.
The problem there is twofold: The compiler fails to report which
name is not a namespace-name (N2) and why (because it's ambiguous).

The patch would only fix the first problem; the second would
still remain.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |08/msg01601.html
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-30 16:22 -------
Subject: Bug 23586

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	reichelt@gcc.gnu.org	2005-08-30 16:22:01

Modified files:
	gcc/cp         : ChangeLog parser.c name-lookup.c 

Log message:
	PR c++/23586
	* parser.c (cp_parser_namespace_name): Move diagnostic for
	invalid namespace-name to here from ...
	* name-lookup.c (do_namespace_alias): ... here and ...
	(do_using_directive): ... here.  Remove dead code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4862&r2=1.4863
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.351&r2=1.352
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&r1=1.138&r2=1.139



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4/4.0/4.1 regression] Bad diagnostic for invalid namespace-name

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-30 16:26 -------
Subject: Bug 23586

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	reichelt@gcc.gnu.org	2005-08-30 16:25:54

Modified files:
	gcc/cp         : ChangeLog parser.c name-lookup.c 

Log message:
	PR c++/23586
	* parser.c (cp_parser_namespace_name): Move diagnostic for
	invalid namespace-name to here from ...
	* name-lookup.c (do_namespace_alias): ... here and ...
	(do_using_directive): ... here.  Remove dead code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4648.2.85&r2=1.4648.2.86
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.319.2.12&r2=1.319.2.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.109.4.7&r2=1.109.4.8



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4 regression] Bad diagnostic for invalid namespace-name

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-30 16:28 -------
Fixed on the 4.0 branch (for 4.0.2) and mainline.

Testing patch for the 3.4 branch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |
                   |patches/2005-               |
                   |08/msg01601.html            |
            Summary|[3.4/4.0/4.1 regression] Bad|[3.4 regression] Bad
                   |diagnostic for invalid      |diagnostic for invalid
                   |namespace-name              |namespace-name
   Target Milestone|4.0.2                       |3.4.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4 regression] Bad diagnostic for invalid namespace-name

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-31 08:32 -------
Patch for the 3.4 branch posted.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |08/msg01818.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4 regression] Bad diagnostic for invalid namespace-name

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-31 10:16 -------
Subject: Bug 23586

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	reichelt@gcc.gnu.org	2005-08-31 10:16:05

Modified files:
	gcc/cp         : ChangeLog parser.c name-lookup.c 

Log message:
	PR c++/23586
	* parser.c (cp_parser_namespace_name): Move diagnostic for
	invalid namespace-name to here from ...
	* name-lookup.c (do_namespace_alias): ... here and ...
	(do_using_directive): ... here.  Remove dead code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.230&r2=1.3892.2.231
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.157.2.58&r2=1.157.2.59
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.34.2.22&r2=1.34.2.23



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586

[Bug c++/23586] [3.4 regression] Bad diagnostic for invalid namespace-name

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-31 10:17 -------
Now also fixed on the 3.4 branch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23586