[Bug rtl-optimization/23567] New: [3.4/4.0 regression] if-conversion causes wrong code

[Bug rtl-optimization/23567] New: [3.4/4.0 regression] if-conversion causes wrong code

[belyshev at depni dot sinp dot msu dot ru]

This patch:

2003-11-02  Roger Sayle  <roger@eyesopen.com>

	PR optimization/10817
	* ifcvt.c (noce_emit_move_insn): Improve documentation comment.
	(noce_try_move): New function to optimize an if-the-else into an
	unconditional move, i.e. "if (a!=b) x=a; else x=b" into "x=a".
	(noce_process_if_block): Attempt simplification with noce_try_move.

causes wrong codegen for this testcase, (taken from debian bug #325050, see
bugs.debian.org/cgi-bin/bugreport.cgi?bug=325050 )

-----------------------------
struct
{
  int len;
  char *name;
} s;

int main (void)
{
  s.len = 0;
  s.name = "";
  if (s.name [s.len] != 0)
    s.name [s.len] = 0;
  return 0;
}
-----------------------------

This looks very similar to PR 13400.

-- 
           Summary: [3.4/4.0 regression] if-conversion causes wrong code
           Product: gcc
           Version: 4.0.2
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: belyshev at depni dot sinp dot msu dot ru
                CC: gcc-bugs at gcc dot gnu dot org,sayle at gcc dot gnu dot
                    org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0 regression] if-conversion causes wrong code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-25 21:48 -------
I want to say this was fixed on the mainline by:
2005-05-18  Richard Henderson  <rth@redhat.com>

        PR 21541
        * ifcvt.c (noce_process_if_block): Avoid conversion when the
        memory destination is readonly.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-25 23:21 -------
This is also latent on the mainline too so I was wrong in saying RTH's patch fixed it.
Use -O1 -fno-tree-dominator-opts to reproduce it there.

Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
      Known to fail|                            |3.4.0 4.0.0 4.1.0
      Known to work|                            |3.3.3
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-25 23:21:40
               date|                            |
            Summary|[3.4/4.0 regression] if-    |[3.4/4.0/4.1 regression] if-
                   |conversion causes wrong code|conversion causes wrong code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[debian-gcc at lists dot debian dot org]

------- Additional Comments From debian-gcc at lists dot debian dot org  2005-08-29 09:37 -------
reported as http://bugs.debian.org/325050

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |debian-gcc at lists dot
                   |                            |debian dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[jakub at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-08-25 23:21:40         |2005-08-29 17:15:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2005-11-07 13:17 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[jakub at gcc dot gnu dot org]

------- Comment #10 from jakub at gcc dot gnu dot org  2005-11-07 08:28 -------
Subject: Bug 23567

Author: jakub
Date: Mon Nov  7 08:28:01 2005
New Revision: 106586

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106586
Log:
        PR rtl-optimization/23567
        * ifcvt.c (noce_mem_write_may_trap_or_fault_p): New function.
        (noce_process_if_block): Don't do any optimizations except
        if (cond) x = x; if !set_b and write into orig_x may trap
        or fault.

        * gcc.c-torture/execute/20051104-1.c: New test.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/gcc.c-torture/execute/20051104-1.c
Modified:
    branches/gcc-4_0-branch/gcc/ChangeLog
    branches/gcc-4_0-branch/gcc/ifcvt.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2005-11-07 08:02 -------
Subject: Bug 23567

Author: jakub
Date: Mon Nov  7 08:01:54 2005
New Revision: 106585

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106585
Log:
        PR rtl-optimization/23567
        * ifcvt.c (noce_mem_write_may_trap_or_fault_p): New function.
        (noce_process_if_block): Don't do any optimizations except
        if (cond) x = x; if !set_b and write into orig_x may trap
        or fault.  Remove the MEM_READONLY_P check.

        * gcc.c-torture/execute/20051104-1.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/20051104-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ifcvt.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2005-11-04 10:52 -------
Sorry, haven't touched this for a while.
Testing a new patch, there have been other problems in noce_process_if_block.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[steven at gcc dot gnu dot org]

------- Comment #7 from steven at gcc dot gnu dot org  2005-11-03 21:00 -------
Jakub, ping!
What's up with this one?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[mmitchel at gcc dot gnu dot org]

------- Comment #6 from mmitchel at gcc dot gnu dot org  2005-10-31 05:39 -------
Elevating to P1; this is a serious wrong-code regression.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[steven at gcc dot gnu dot org]

------- Comment #5 from steven at gcc dot gnu dot org  2005-10-25 16:24 -------
Jakub, ping!

Are you going to post your patch from comment #4??


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steven at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567

[Bug rtl-optimization/23567] [3.4/4.0/4.1 regression] if-conversion causes wrong code

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23567