[Bug target/23704] New: gcc.dg/rs6000-fpint.c fails

[Bug target/23704] New: gcc.dg/rs6000-fpint.c fails

[rth at gcc dot gnu dot org]

Apparently -mno-powerpc-gfxopt is overridden by a later -m64 option.
If the testcase is run by hand, with -m64 before -mno-powerpc-gfxopt
on the command-line, then it'll pass.

-- 
           Summary: gcc.dg/rs6000-fpint.c fails
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rth at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: powerpc64-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[amodra at bigpond dot net dot au]

------- Additional Comments From amodra at bigpond dot net dot au  2005-09-07 01:26 -------
Indeed, that is what is happening.  -m64 ought to normally imply
-mpowerpc-gfxopt, because all powerpc64 capable chips also support the insns
enabled by -mpowerpc-gfxopt as far as I know.  However, I guess there's not much
harm in preventing -m64 from overriding a prior -mno-powerpc-gfxopt.

Index: gcc/config/rs6000/rs6000.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.c,v
retrieving revision 1.866
diff -u -p -r1.866 rs6000.c
--- gcc/config/rs6000/rs6000.c	6 Sep 2005 02:04:59 -0000	1.866
+++ gcc/config/rs6000/rs6000.c	7 Sep 2005 01:11:56 -0000
@@ -1620,9 +1620,9 @@ rs6000_handle_option (size_t code, const
 #else
     case OPT_m64:
 #endif
-      target_flags |= MASK_POWERPC64 | MASK_POWERPC | MASK_PPC_GFXOPT;
-      target_flags_explicit |= MASK_POWERPC64 | MASK_POWERPC
-	| MASK_PPC_GFXOPT;
+      target_flags |= MASK_POWERPC64 | MASK_POWERPC;
+      target_flags |= ~target_flags_explicit & MASK_PPC_GFXOPT;
+      target_flags_explicit |= MASK_POWERPC64 | MASK_POWERPC;
       break;
 
 #ifdef TARGET_USES_AIX64_OPT


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2005-09-07 01:55 -------
You could also disable the test for lp64, if you felt that better.
But then you should document that the various isa extension options
are non-functional.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-15 20:15 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-09-15 20:15:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[amodra at bigpond dot net dot au]

------- Comment #6 from amodra at bigpond dot net dot au  2005-11-08 03:17 -------
I meant, fixed on 3.4 and 4.0 by patch for pr20277


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[amodra at bigpond dot net dot au]

------- Comment #5 from amodra at bigpond dot net dot au  2005-11-08 03:15 -------
Fixed mainline.  Bug fixed on 3.4 and 4.0 branch by patch for pr20227


-- 

amodra at bigpond dot net dot au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704

[Bug target/23704] gcc.dg/rs6000-fpint.c fails

[amodra at gcc dot gnu dot org]

------- Comment #4 from amodra at gcc dot gnu dot org  2005-11-08 03:09 -------
Subject: Bug 23704

Author: amodra
Date: Tue Nov  8 03:08:43 2005
New Revision: 106631

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106631
Log:
        PR target/23704
        * config/rs6000/rs6000.c (rs6000_handle_option <OPT_m64>): Don't
        override prior explicit -mno-powerpc-gfxopt.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23704