public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dberlin at dberlin dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/23588] CCP not fully propagating constants
Date: Wed, 07 Sep 2005 13:36:00 -0000	[thread overview]
Message-ID: <20050907133610.32453.qmail@sourceware.org> (raw)
In-Reply-To: <20050827022854.23588.dberlin@gcc.gnu.org>


------- Additional Comments From dberlin at gcc dot gnu dot org  2005-09-07 13:36 -------
Subject: Re:  CCP not fully propagating
	constants

On Wed, 2005-09-07 at 04:19 +0000, pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-07 04:19 -------
> (In reply to comment #3)
> > And then we hit an assert if we change evaluate_stmt to be always call fold_ccp.
> > The assert is in set_lattice_value, when we are changing from VARRYING to CONSTANT which should 
> > be  a valid transition.
> 
> Only if the VARRYING is the default state.
> Before the TCB, this was allowed:
> /* VARYING -> CONSTANT is an invalid state transition, except
>  for objects which start off in a VARYING state.  */
> 

VARYING->CONSTANT should actually never happen, regardless of what the
comment says.

We shouldn't set it to VARYING in the first place if we think it has a
chance of becoming CONSTANT.

So i imagine get_default_value or whatever needs to be more
foregiving :)





-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23588


  parent reply	other threads:[~2005-09-07 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-27  3:31 [Bug tree-optimization/23588] New: " dberlin at gcc dot gnu dot org
2005-08-27  3:31 ` [Bug tree-optimization/23588] " pinskia at gcc dot gnu dot org
2005-09-07  3:46 ` pinskia at gcc dot gnu dot org
2005-09-07  3:51 ` pinskia at gcc dot gnu dot org
2005-09-07  4:28 ` pinskia at gcc dot gnu dot org
2005-09-07 13:36 ` dberlin at dberlin dot org [this message]
2005-09-21 15:02 ` steven at gcc dot gnu dot org
     [not found] <bug-23588-1@http.gcc.gnu.org/bugzilla/>
2005-10-07 21:21 ` steven at gcc dot gnu dot org
2006-03-26 18:14 ` pinskia at gcc dot gnu dot org
2006-03-26 18:22 ` pinskia at gcc dot gnu dot org
2008-03-26 23:48 ` rguenth at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050907133610.32453.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).