public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean
@ 2005-08-16 8:03 debian-gcc at lists dot debian dot org
2005-08-16 9:28 ` [Bug libstdc++/23417] " chris at bubblescope dot net
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: debian-gcc at lists dot debian dot org @ 2005-08-16 8:03 UTC (permalink / raw)
To: gcc-bugs
[forwarded from http://bugs.debian.org/]
gcc version 4.0.2 20050806
Warning is "_M_header should be initialized in the member intialization
list". Ok, patch follows:
--- /usr/include/c++/4.0.1/bits/stl_tree.h~ 2005-07-12 06:15:28.000000000 +0200
+++ /usr/include/c++/4.0.1/bits/stl_tree.h 2005-08-09 15:43:32.000000000 +0200
@@ -401,7 +401,7 @@
_Rb_tree_impl(const _Node_allocator& __a = _Node_allocator(),
const _Key_compare& __comp = _Key_compare())
- : _Node_allocator(__a), _M_key_compare(__comp), _M_node_count(0)
+ : _Node_allocator(__a), _M_key_compare(__comp), _M_header(),
_M_node_count(0)
{
this->_M_header._M_color = _S_red;
this->_M_header._M_parent = 0;
--
Summary: bits/stl_tree.h isn't -Weffc++ clean
Product: gcc
Version: 4.0.2
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libstdc++
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: debian-gcc at lists dot debian dot org
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
@ 2005-08-16 9:28 ` chris at bubblescope dot net
2005-08-16 11:51 ` chris at bubblescope dot net
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: chris at bubblescope dot net @ 2005-08-16 9:28 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From chris at bubblescope dot net 2005-08-16 09:10 -------
In the FAQ (4.4), things that only looks like bugs, mentions that libstdc++ isn't -Weffc++ clean.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
2005-08-16 9:28 ` [Bug libstdc++/23417] " chris at bubblescope dot net
@ 2005-08-16 11:51 ` chris at bubblescope dot net
2005-08-16 12:08 ` pinskia at gcc dot gnu dot org
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: chris at bubblescope dot net @ 2005-08-16 11:51 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bubblescope dot net
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
2005-08-16 9:28 ` [Bug libstdc++/23417] " chris at bubblescope dot net
2005-08-16 11:51 ` chris at bubblescope dot net
@ 2005-08-16 12:08 ` pinskia at gcc dot gnu dot org
2005-08-17 2:40 ` pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-08-16 12:08 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-08-16 12:02 -------
(In reply to comment #1)
> In the FAQ (4.4), things that only looks like bugs, mentions that libstdc++ isn't -Weffc++ clean.
And more than that, there is a bug in that database which is suspended for libstdc++ vs -Weffc++,
PR 12854.
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |12854
nThis| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (2 preceding siblings ...)
2005-08-16 12:08 ` pinskia at gcc dot gnu dot org
@ 2005-08-17 2:40 ` pinskia at gcc dot gnu dot org
2005-09-12 19:21 ` bkoz at gcc dot gnu dot org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-08-17 2:40 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-08-17 02:36 -------
Having a testcase to reproduce this would be nice.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (3 preceding siblings ...)
2005-08-17 2:40 ` pinskia at gcc dot gnu dot org
@ 2005-09-12 19:21 ` bkoz at gcc dot gnu dot org
2005-09-12 19:48 ` cvs-commit at gcc dot gnu dot org
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2005-09-12 19:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bkoz at gcc dot gnu dot org 2005-09-12 19:20 -------
Reproducer, compile with -Weffc++.
#include <list>
std::list<int> l;
...fixing....
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |bkoz at gcc dot gnu dot org
|dot org |
Status|UNCONFIRMED |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (4 preceding siblings ...)
2005-09-12 19:21 ` bkoz at gcc dot gnu dot org
@ 2005-09-12 19:48 ` cvs-commit at gcc dot gnu dot org
2005-09-12 19:55 ` cvs-commit at gcc dot gnu dot org
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-12 19:48 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-12 19:48 -------
Subject: Bug 23417
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: bkoz@gcc.gnu.org 2005-09-12 19:48:05
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: stl_list.h
Log message:
2005-09-12 Benjamin Kosnik <bkoz@redhat.com>
PR libstdc++/23417
* include/bits/stl_list.h (_List_impl): Use member initialization
list for -Weffc++.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3097&r2=1.3098
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_list.h.diff?cvsroot=gcc&r1=1.52&r2=1.53
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (5 preceding siblings ...)
2005-09-12 19:48 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-12 19:55 ` cvs-commit at gcc dot gnu dot org
2005-09-12 19:59 ` pcarlini at suse dot de
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-12 19:55 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-12 19:55 -------
Subject: Bug 23417
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: bkoz@gcc.gnu.org 2005-09-12 19:54:56
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: stl_list.h
Log message:
2005-09-12 Benjamin Kosnik <bkoz@redhat.com>
PR libstdc++/23417
* include/bits/stl_list.h (_List_impl): Use member initialization
list for -Weffc++.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2917.2.80&r2=1.2917.2.81
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_list.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.47.6.1&r2=1.47.6.2
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (6 preceding siblings ...)
2005-09-12 19:55 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-12 19:59 ` pcarlini at suse dot de
2005-09-12 20:05 ` bkoz at gcc dot gnu dot org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pcarlini at suse dot de @ 2005-09-12 19:59 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2005-09-12 19:59 -------
Benjamin, can you also check, say, std::set? After all the PR is about
stl_tree.h... ;)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (7 preceding siblings ...)
2005-09-12 19:59 ` pcarlini at suse dot de
@ 2005-09-12 20:05 ` bkoz at gcc dot gnu dot org
2005-09-12 20:09 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2005-09-12 20:05 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bkoz at gcc dot gnu dot org 2005-09-12 20:05 -------
Yep. Sorry. I fixed that bit too.
-benjamin
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (8 preceding siblings ...)
2005-09-12 20:05 ` bkoz at gcc dot gnu dot org
@ 2005-09-12 20:09 ` cvs-commit at gcc dot gnu dot org
2005-09-12 20:33 ` cvs-commit at gcc dot gnu dot org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-12 20:09 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-12 20:09 -------
Subject: Bug 23417
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: bkoz@gcc.gnu.org 2005-09-12 20:09:18
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: stl_tree.h
Log message:
2005-09-12 Benjamin Kosnik <bkoz@redhat.com>
PR libstdc++/23417
* include/bits/stl_list.h (_List_impl): Use member initialization
list for -Weffc++.
* include/bits/stl_tree.h (_Rb_tree_impl): Same.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2917.2.81&r2=1.2917.2.82
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.44.6.2&r2=1.44.6.3
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (9 preceding siblings ...)
2005-09-12 20:09 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-12 20:33 ` cvs-commit at gcc dot gnu dot org
2005-09-12 20:51 ` bkoz at gcc dot gnu dot org
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-12 20:33 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-12 20:33 -------
Subject: Bug 23417
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: bkoz@gcc.gnu.org 2005-09-12 20:32:54
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: stl_tree.h
Log message:
2005-09-12 Benjamin Kosnik <bkoz@redhat.com>
PR libstdc++/23417
* include/bits/stl_list.h (_List_impl): Use member initialization
list for -Weffc++.
* include/bits/stl_tree.h (_Rb_tree_impl): Same.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3098&r2=1.3099
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_tree.h.diff?cvsroot=gcc&r1=1.48&r2=1.49
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (10 preceding siblings ...)
2005-09-12 20:33 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-12 20:51 ` bkoz at gcc dot gnu dot org
2005-09-12 20:54 ` pinskia at gcc dot gnu dot org
2005-09-18 13:39 ` cvs-commit at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2005-09-12 20:51 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bkoz at gcc dot gnu dot org 2005-09-12 20:51 -------
Fixed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.0.3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (11 preceding siblings ...)
2005-09-12 20:51 ` bkoz at gcc dot gnu dot org
@ 2005-09-12 20:54 ` pinskia at gcc dot gnu dot org
2005-09-18 13:39 ` cvs-commit at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-12 20:54 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.3 |4.0.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug libstdc++/23417] bits/stl_tree.h isn't -Weffc++ clean
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
` (12 preceding siblings ...)
2005-09-12 20:54 ` pinskia at gcc dot gnu dot org
@ 2005-09-18 13:39 ` cvs-commit at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-18 13:39 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-18 13:39 -------
Subject: Bug 23417
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: paolo@gcc.gnu.org 2005-09-18 13:39:26
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: stl_tree.h
Log message:
2005-09-18 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/23417 (cont)
* include/bits/stl_tree.h (_Rb_tree_impl<true>): Use member
initialization list for -Weffc++.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.3109&r2=1.3110
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_tree.h.diff?cvsroot=gcc&r1=1.49&r2=1.50
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23417
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2005-09-18 13:39 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-16 8:03 [Bug libstdc++/23417] New: bits/stl_tree.h isn't -Weffc++ clean debian-gcc at lists dot debian dot org
2005-08-16 9:28 ` [Bug libstdc++/23417] " chris at bubblescope dot net
2005-08-16 11:51 ` chris at bubblescope dot net
2005-08-16 12:08 ` pinskia at gcc dot gnu dot org
2005-08-17 2:40 ` pinskia at gcc dot gnu dot org
2005-09-12 19:21 ` bkoz at gcc dot gnu dot org
2005-09-12 19:48 ` cvs-commit at gcc dot gnu dot org
2005-09-12 19:55 ` cvs-commit at gcc dot gnu dot org
2005-09-12 19:59 ` pcarlini at suse dot de
2005-09-12 20:05 ` bkoz at gcc dot gnu dot org
2005-09-12 20:09 ` cvs-commit at gcc dot gnu dot org
2005-09-12 20:33 ` cvs-commit at gcc dot gnu dot org
2005-09-12 20:51 ` bkoz at gcc dot gnu dot org
2005-09-12 20:54 ` pinskia at gcc dot gnu dot org
2005-09-18 13:39 ` cvs-commit at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).