public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/23906] New: inappropriate branch condition in function "transform_sections" in "dependency.c"
@ 2005-09-15 22:48 skyhover at hotmail dot com
2005-09-16 3:27 ` [Bug fortran/23906] " pbrook at gcc dot gnu dot org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: skyhover at hotmail dot com @ 2005-09-15 22:48 UTC (permalink / raw)
To: gcc-bugs
Line 422 in the file is a if-statement:
if (l_stride != NULL)
mpz_cdiv_q (X2, X2, r_stride->value.integer);
I am not clear about the functionality of "mpz_cdiv_q", but I think the
condition should be "r_stride != NULL" by looking at its surroundings and
complying to certain consistency rules.
Thank you.
--
Summary: inappropriate branch condition in function
"transform_sections" in "dependency.c"
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: skyhover at hotmail dot com
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23906
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/23906] inappropriate branch condition in function "transform_sections" in "dependency.c"
2005-09-15 22:48 [Bug fortran/23906] New: inappropriate branch condition in function "transform_sections" in "dependency.c" skyhover at hotmail dot com
2005-09-16 3:27 ` [Bug fortran/23906] " pbrook at gcc dot gnu dot org
@ 2005-09-16 3:27 ` cvs-commit at gcc dot gnu dot org
2005-09-16 3:27 ` pbrook at gcc dot gnu dot org
2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-16 3:27 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pbrook at gcc dot gnu dot org 2005-09-16 03:26 -------
This looks like a bug. However I don't agree with this analysis.
We should be applying the same transformation to both l and r.
Also, multiplying then dividing by the same value makes no sense.
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-09-16 03:26 -------
Subject: Bug 23906
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: pbrook@gcc.gnu.org 2005-09-16 03:26:37
Modified files:
gcc/fortran : ChangeLog dependency.c
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/gfortran.dg: dependency_1.f90
Log message:
2005-09-16 Paul Brook <paul@codesourcery.com>
PR fortran/23906
fortran/
* dependency.c (transform_sections): Divide by correct value.
Elaborate comment.
testsuite/
* gfortran.dg/dependency_1.f90: New test.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.555&r2=1.556
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/dependency.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6069&r2=1.6070
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/dependency_1.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-09-16 03:26:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23906
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/23906] inappropriate branch condition in function "transform_sections" in "dependency.c"
2005-09-15 22:48 [Bug fortran/23906] New: inappropriate branch condition in function "transform_sections" in "dependency.c" skyhover at hotmail dot com
@ 2005-09-16 3:27 ` pbrook at gcc dot gnu dot org
2005-09-16 3:27 ` cvs-commit at gcc dot gnu dot org
2005-09-16 3:27 ` pbrook at gcc dot gnu dot org
2 siblings, 0 replies; 4+ messages in thread
From: pbrook at gcc dot gnu dot org @ 2005-09-16 3:27 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pbrook at gcc dot gnu dot org 2005-09-16 03:27 -------
Fixed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23906
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/23906] inappropriate branch condition in function "transform_sections" in "dependency.c"
2005-09-15 22:48 [Bug fortran/23906] New: inappropriate branch condition in function "transform_sections" in "dependency.c" skyhover at hotmail dot com
2005-09-16 3:27 ` [Bug fortran/23906] " pbrook at gcc dot gnu dot org
2005-09-16 3:27 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-16 3:27 ` pbrook at gcc dot gnu dot org
2 siblings, 0 replies; 4+ messages in thread
From: pbrook at gcc dot gnu dot org @ 2005-09-16 3:27 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pbrook at gcc dot gnu dot org 2005-09-16 03:26 -------
This looks like a bug. However I don't agree with this analysis.
We should be applying the same transformation to both l and r.
Also, multiplying then dividing by the same value makes no sense.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-09-16 03:26:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23906
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-16 3:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-15 22:48 [Bug fortran/23906] New: inappropriate branch condition in function "transform_sections" in "dependency.c" skyhover at hotmail dot com
2005-09-16 3:27 ` [Bug fortran/23906] " pbrook at gcc dot gnu dot org
2005-09-16 3:27 ` cvs-commit at gcc dot gnu dot org
2005-09-16 3:27 ` pbrook at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).