[Bug inline-asm/16194] New: [3.4/3.5 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[Bug inline-asm/16194] New: [3.4/3.5 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[prafullat at kpitcummins dot com]

Hi,

GCC-3.5 snapshot dated 20.06.2004 gives an ICE (Internal Compiler Error) for 
following code when compiled with options -ms for H8/300 targets. This bug was 
there in Released GCC version 3.4.

bug.c
*************************************************************
void bug(char* dst) 
{ 
	register char* _dst __asm ("er6"); 
	__asm__ ("eepmov.b":"=g"(*_dst)::"r4","er5","er6"); 
}
*************************************************************
$h8300-elf-gcc -ms bug.c
bug.c: In function `bug':
bug.c:5: internal compiler error: asm clobber conflict with output operand
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

I have already posted this bug on gcc mailing list. 
Please refer to http://gcc.gnu.org/ml/gcc/2004-05/msg00690.html for two 
postings related to this bug.

Regards,
Prafulla Thakare,
KPIT Cummins InfoSystems Ltd.
Pune, India

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas' SH and H8 Series.
The following site also offers free technical support to its users. 
Visit http://www.kpitgnutools.com for details. 
Latest versions of KPIT GNU tools are released on June 1, 2004.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-- 
           Summary: [3.4/3.5 Regression] In case of H8/300 target, internal
                    compiler error (ICE): asm clobber conflict with output
                    operand
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: inline-asm
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: prafullat at kpitcummins dot com
                CC: gcc-bugs at gcc dot gnu dot org,prafullat at kpitcummins
                    dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: h8300-unknown-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug target/16194] [3.4/3.5 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-25 23:58 -------
I do not know if this is invalid code but g is selecting really m which means it just passes the address 
in, which just so happens to be at "er6".

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
          Component|inline-asm                  |target


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug target/16194] [3.4/3.5 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[prafullat at kpitcummins dot com]

------- Additional Comments From prafullat at kpitcummins dot com  2004-07-01 05:25 -------
Following code was causing ICE for H8 target. Same is confirmed for SH target.
Logically, it seems that compiler will give ICE for any asm instruction with 
following format and if you are pointing to memory addressed by the input or 
output operands that conflict with clobber list. 
General Instruction format:
asm ("INSN" : O/P Operand : I/P operand : Clobber List);

for H8 target:
///////////////////////////////////////////////////////////////////////////
void bug(void) 
{ 
	register char* _dst __asm ("r6"); 
	__asm__ ("eepmov.b":"=g"(*_dst)::"r4","er5","er6");  	//for H8 target
} 
///////////////////////////////////////////////////////////////////////////

For SH target
///////////////////////////////////////////////////////////////////////////
void bug(void)
{
	register char* _dst __asm ("r1"); 
	register char* _dst1 __asm ("r0"); 
	__asm__ ("mov.b %0,%1":"=g"(*_dst):"g"(*_dst1):"r0","r1"); 
}
///////////////////////////////////////////////////////////////////////////



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug target/16194] [3.4/3.5 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[prafullat at kpitcummins dot com]

------- Additional Comments From prafullat at kpitcummins dot com  2004-08-03 10:39 -------
Hi,

The invalid code is causing ICE for SH as well as H8 targets. There is a 
logical error in this code (i.e. instead of specifying the register, it is 
actually passing content of register) , which compiler is not supposed to 
handle. 
But refer to patch posted at http://gcc.gnu.org/ml/gcc-patches/2002-
09/msg01168.html, part of this patch has added a block of code to do a sanity 
check on input/output operand and clobber list.
This block has introduces this ICE i.e. for invalid asm code.

We feel that compiler should flash normal error instead of internal compiler 
error. 
Will it be proper to call "error" instead of "internal_error" in file stmt.c , 
line number 14 and 16?


Please comment.

Thanks and Regards,
Prafulla Thakare,
KPIT Cummins InfoSystems Ltd.
Pune, India

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas' SH and H8 Series.
The following site also offers free technical support to its users. 
Visit http://www.kpitgnutools.com for details. 
Latest versions of KPIT GNU tools are released on June 1, 2004.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug target/16194] [3.4/4.0 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug target/16194] [3.4/4.0 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-11-01 00:45 -------
Postponed until GCC 3.4.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.3                       |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug rtl-optimization/16194] [3.4/4.0 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-08 16:01 -------
I think this is invalid code though.  An example for PPC:
void bug(char* dst)
{
        register char* _dst __asm ("r6");
        __asm__ ("%0":"=g"(*_dst): :"r4","r5","r6");
}

Note you saying that you clobered r6 but pass something which is in the memory address in r6.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|target                      |rtl-optimization
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-11-08 16:01:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug rtl-optimization/16194] [3.3/3.4/4.0 Regression] In case of H8/300 target, internal compiler error (ICE): asm clobber conflict with output operand

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-08 18:26 -------
And here is the x86 example:
void bug(char* dst)
{
        register char* _dst __asm ("eax");
        __asm__ ("%0":"=g"(*_dst): :"eax");
}

: Search converges between 2002-09-22-trunk (#90) and 2002-09-29-trunk (#91).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.3.5 3.4.3 4.0.0
      Known to work|                            |3.2.3
            Summary|[3.4/4.0 Regression] In case|[3.3/3.4/4.0 Regression] In
                   |of H8/300 target, internal  |case of H8/300 target,
                   |compiler error (ICE): asm   |internal compiler error
                   |clobber conflict with output|(ICE): asm clobber conflict
                   |operand                     |with output operand


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-15 06:33 -------
This was caused by:
2002-09-23  Hans-Peter Nilsson  <hp@axis.com>
        
        * doc/extend.texi (Extended Asm): Clarify that overlap between
        asm-declared register variables used in an asm and the asm clobber
        list is not allowed.
        * stmt.c (decl_conflicts_with_clobbers_p): New function.
        (expand_asm_operands): Keep track of clobbered registers.  Call
        decl_conflicts_with_clobbers_p for each input and output operand.
        If no conflicts found before, also do conflict sanity check when
        emitting clobbers.

But I don't understand why we hit the ICE instead of the error.

Oh, now I know why, because g (and m) can have an INDIRECT_REF.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at axis dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-15 07:20 -------
Mine, I posted a patch for this but it has not showed up on gcc-patches yet.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-15 07:20 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2005-01/msg00868.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0 Regression] global register with inline-asm and clobered

[hp at gcc dot gnu dot org]

------- Additional Comments From hp at gcc dot gnu dot org  2005-01-15 19:13 -------
For future reference, it would have been ok to assign this bug to me, once
the bug was diagnosed and attributed to an incomplete patch of mine.
(BTW, your patch introduces spurious spaces.)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-21 16:58 -------
I am no longer working on this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pinskia at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.3/3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.4                       |3.4.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-22 21:12 -------
Moving to 4.0.2 pre Mark.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.5                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[mmitchel at gcc dot gnu dot org]

------- Comment #13 from mmitchel at gcc dot gnu dot org  2005-10-30 22:38 -------
Set to P2; I'd like to fix this, if possible, since it's hard enough to write
extended asm code without getting ICEs.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[pinskia at gcc dot gnu dot org]

------- Comment #18 from pinskia at gcc dot gnu dot org  2006-02-09 20:25 -------
Fixed at least on the mainline.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|3.2.3                       |3.2.3 4.2.0
            Summary|[3.4/4.0/4.1/4.2 Regression]|[3.4/4.0/4.1 Regression]
                   |global register with inline-|global register with inline-
                   |asm and clobered            |asm and clobered


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[amylaar at gcc dot gnu dot org]

------- Comment #19 from amylaar at gcc dot gnu dot org  2006-02-09 21:53 -------
(In reply to comment #17)
I am currently testing the back-merged patch in the 4.1 branch on
i686-pc-linux-gnu native, X sh-elf, X sh64-elf, X arm-elf and X cris-elf.

I have no intention on working on this bug in the other affected branches.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194

[Bug inline-asm/16194] [3.4/4.0/4.1 Regression] global register with inline-asm and clobered

[amylaar at gcc dot gnu dot org]

------- Comment #20 from amylaar at gcc dot gnu dot org  2006-02-14 14:36 -------
Subject: Bug 16194

Author: amylaar
Date: Tue Feb 14 14:36:15 2006
New Revision: 110970

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110970
Log:
PR inline-asm/16194

2006-01-31  J"orn Rennecke <joern.rennecke@st.com>

gcc:
        * tree.h (decl_overlaps_hard_reg_set_p) Don't declare.
        (tree_overlaps_hard_reg_set): Declare.
        * stmt.c (decl_overlaps_hard_reg_set_p): Now static.  Change return
        type and signature to match function type expected by walk_tree.
        (tree_overlaps_hard_reg_set): New function.
        (decl_conflicts_with_clobbers_p): Rename to:
        (tree_conflicts_with_clobbers_p).  Take HARD_REG_SET * argument.
        Use tree_overlaps_hard_reg_set.  Changed caller.
        * doc/tm.texi (TARGET_MD_ASM_CLOBBERS): Replace
        decl_overlaps_hard_reg_set_p with tree_overlaps_hard_reg_set.
        * cris.c (cris_md_asm_clobbers): Likewise.

gcc/testsuite:
        * gcc.dg/pr16194.c: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/pr16194.c
      - copied unchanged from r110810, trunk/gcc/testsuite/gcc.dg/pr16194.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/config/cris/cris.c
    branches/gcc-4_1-branch/gcc/doc/tm.texi
    branches/gcc-4_1-branch/gcc/stmt.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/tree.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16194