[Bug preprocessor/13726] New: [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[Bug preprocessor/13726] New: [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[neroden at gcc dot gnu dot org]

Not really critical, but it is a regression from 2.95 and is known to break 
some programs, notably one called cxref.  :-( 
 
Put this in test.c: 
#include "test.h" /* comment */ 
 
(Put anything in test.h) 
 
cpp -C -dI outputs 
#include "test.h" 
losing the comment.

-- 
           Summary: [3.3/3.4/3.5 regression]cpp -C -dI loses comments on
                    same line as #include directives
           Product: gcc
           Version: 3.3.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: neroden at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[dhazeghi at yahoo dot com]

------- Additional Comments From dhazeghi at yahoo dot com  2004-01-18 02:06 -------
Confirmed with mainline.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-01-18 02:06:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2004-02-15 12:39 -------
Adjust miletsone

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.3                       |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/3.5 regression]cpp -C -dI loses comments on same line as #include directives

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-03-01 01:45 -------
This is not a showstopper for any 3.4.x release, although it should be fixed if
possible.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.4                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[neroden at gcc dot gnu dot org]

------- Additional Comments From neroden at gcc dot gnu dot org  2004-11-27 02:39 -------
libcpp turns off save_comments in start_directive, near the start of 
_cpp_handle_directive (all in directives.c).  This is arguably mistaken, but 
there's probably a reason for it, so I'm loathe to just remove it 
unconditionally.  :-P 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|4.0 3.4.0                   |4.0.0 3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[echristo at redhat dot com]

------- Additional Comments From echristo at redhat dot com  2005-01-29 00:25 -------
Current mainline does this:

[echristo@dzur ~/tmp]$ /dzur/sourceware/builds-gcc/build-dzur/gcc/cc1 -dI -C test.c
In file included from test.c:1:
test.h:1: internal compiler error: in c_lex_with_flags, at c-lex.c:466
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
[echristo@dzur ~/tmp]$ cat test.c
#include "test.h" /* this is a comment.  */
[echristo@dzur ~/tmp]$ cat test.h
/* this is another comment.  */

------

I'm investigating.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[echristo at redhat dot com]

------- Additional Comments From echristo at redhat dot com  2005-01-29 00:26 -------
The previous was because i'm an idiot.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[echristo at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |echristo at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-05-31 00:42:53         |2005-01-29 00:33:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[echristo at redhat dot com]

------- Additional Comments From echristo at redhat dot com  2005-02-01 02:21 -------
The best I can get without major surgery to cpp is this:

#include "test.h"
<contents of test.h>
                   /* comment from include line  */

Which is likely insufficient for any good needs. I think what we need to be able
to do with cpplib is to put actions on a stack and have them popped at the end
of the directive.

Another option is to have _cpp_push_include (or push_file) finish out the
current buffer before actually pushing out the file. I don't know how well this
will work out in practice though.

Thoughts?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zack at codesourcery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0 regression]cpp -C -dI loses comments on same line as #include directives

[echristo at redhat dot com]

------- Additional Comments From echristo at redhat dot com  2005-02-08 03:11 -------
cpplib isn't my component and I'd prefer not to implement anything before
knowing that the general idea is ok. reassigning to unassigned.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|echristo at redhat dot com  |unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.3/3.4/4.0/4.1 regression]cpp -C -dI loses comments on same line as #include directives

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.4/4.0/4.1 regression]cpp -C -dI loses comments on same line as #include directives

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.1                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.4/4.0/4.1 regression]cpp -C -dI loses comments on same line as #include directives

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-22 21:41 -------
I think this is related to PR 24024.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.4/4.0/4.1 regression]cpp -C -dI loses comments on same line as #include directives

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726

[Bug preprocessor/13726] [3.4/4.0/4.1 regression]cpp -C -dI loses comments on same line as #include directives

[cvs-commit at gcc dot gnu dot org]

------- Comment #10 from cvs-commit at gcc dot gnu dot org  2005-10-04 18:06 -------
Subject: Bug 13726

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     ian@gcc.gnu.org 2005-10-04 18:06:20

Modified files:
        gcc            : ChangeLog c-ppoutput.c 
        gcc/testsuite  : ChangeLog 
        libcpp         : ChangeLog directives.c 
        libcpp/include : cpplib.h 
Added files:
        gcc/testsuite/gcc.dg/cpp: cmdlne-dI-C.c cmdlne-dI-C.h 

Log message:
        libcpp/
        PR preprocessor/13726
        * directives.c (check_eol_return_comments): New static function.
        (parse_include): Add buf parameter.  Change all callers.
        (do_include_common): If not discard comments, turn on
        save_comments.  Pass collected comments to include callback.
        * include/cpplib.h (struct cpp_callbacks): Add new parameter to
        include callback: cpp_token list.
        gcc/
        PR preprocessor/13726
        * c-ppoutput.c (cb_include): Add comments parameter, and print out
        any comments passed in.
        gcc/testsuite/
        PR preprocessor/13726
        * gcc.dg/cpp/cmdlne-dI-C.c: New test.
        * gcc.dg/cpp/cmdlne-dI-C.h: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10080&r2=2.10081
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-ppoutput.c.diff?cvsroot=gcc&r1=1.25&r2=1.26
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6133&r2=1.6134
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.77&r2=1.78
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/directives.c.diff?cvsroot=gcc&r1=1.17&r2=1.18
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/include/cpplib.h.diff?cvsroot=gcc&r1=1.14&r2=1.15
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/cmdlne-dI-C.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/cmdlne-dI-C.h.diff?cvsroot=gcc&r1=NONE&r2=1.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13726