[Bug tree-optimization/24142] New: VRP miscompiles unzip inflate.c

[Bug tree-optimization/24142] New: VRP miscompiles unzip inflate.c

[rguenth at gcc dot gnu dot org]

For the following testcase reduced from inflate.c

int bar(void);
int foobar(void);
static unsigned dbits = 6;
int foo(void)
{
  int retval;
  unsigned bd;
  unsigned nl;

  bd = dbits;
  retval = bar();
  if (retval == 1)
    retval = 0;
  if (bd == 0 && nl > 257)
    retval = 1;
  if (retval)
    return retval;

  return foobar();
}

VRP removes the call to foobar() because it thinks it can fold the
last comparison:
Folding predicate retval_2 != 0 to 1

-- 
           Summary: VRP miscompiles unzip inflate.c
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
OtherBugsDependingO 23968
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] VRP miscompiles unzip inflate.c

[rguenth at gcc dot gnu dot org]

------- Additional Comments From rguenth at gcc dot gnu dot org  2005-09-30 10:19 -------
Slightly reduced:

int bar(void);
int foobar(void);
extern unsigned bd;
int foo(void)
{
  int retval = bar();
  if (retval == 1)
    retval = 0;
  if (bd == 0)
    retval = 1;
  if (retval)
    return retval;

  return foobar();
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[belyshev at depni dot sinp dot msu dot ru]

------- Additional Comments From belyshev at depni dot sinp dot msu dot ru  2005-09-30 11:54 -------
This is really a dup of bug 24141.

*** This bug has been marked as a duplicate of 24141 ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE
            Summary|VRP miscompiles unzip       |[4.1 regression] VRP
                   |inflate.c                   |miscompiles unzip inflate.c
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[steven at gcc dot gnu dot org]

------- Additional Comments From steven at gcc dot gnu dot org  2005-09-30 13:46 -------
I'm not so sure that this is a dup.  Bug 24141 is a wrong-code problem, 
and this is an ICE.  Just the fact that the same test case triggers both 
bugs doesn't mean they are the same problem. 
 
 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[belyshev at depni dot sinp dot msu dot ru]

------- Additional Comments From belyshev at depni dot sinp dot msu dot ru  2005-10-01 15:24 -------
(In reply to comment #3)
> I'm not so sure that this is a dup.  Bug 24141 is a wrong-code problem, 
> and this is an ICE.  Just the fact that the same test case triggers both 
> bugs doesn't mean they are the same problem. 
>  
>  

You are right, this is not a dup. original testcase still fails even after bug
24141 fixed:

void abort (void);

int f (int a, int b)
{
  if (a == 1)
    a = 0;
  if (b == 0)
    a = 1;
  if (a != 0)
    return 0;
  return 1;
}

int main (void)
{
  if (f (1, 1) != 1)
    abort ();
  return 0;
}


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|DUPLICATE                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[belyshev at depni dot sinp dot msu dot ru]

------- Additional Comments From belyshev at depni dot sinp dot msu dot ru  2005-10-01 15:26 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-10-01 15:26:51
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[dnovillo at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dnovillo at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[cvs-commit at gcc dot gnu dot org]

------- Comment #6 from cvs-commit at gcc dot gnu dot org  2005-10-02 20:16 -------
Subject: Bug 24142

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     dnovillo@gcc.gnu.org    2005-10-02 20:15:55

Modified files:
        gcc            : ChangeLog tree-vrp.c 
        gcc/testsuite  : ChangeLog 
Added files:
        gcc/testsuite/gcc.c-torture/execute: pr24142.c 

Log message:
        PR 24142
        * tree-vrp.c (vrp_meet): Fix call to range_includes_zero_p in
        case of anti-ranges.

        testsuite/

        PR 24142
        * gcc.c-torture/execute/pr24142.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10067&r2=2.10068
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-vrp.c.diff?cvsroot=gcc&r1=2.60&r2=2.61
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6122&r2=1.6123
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/pr24142.c.diff?cvsroot=gcc&r1=NONE&r2=1.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142

[Bug tree-optimization/24142] [4.1 regression] VRP miscompiles unzip inflate.c

[dnovillo at gcc dot gnu dot org]

------- Comment #7 from dnovillo at gcc dot gnu dot org  2005-10-02 20:17 -------

Fixed.  http://gcc.gnu.org/ml/gcc-patches/2005-10/msg00056.html.


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24142