public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile
       [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
@ 2005-10-05 12:17 ` cvs-commit at gcc dot gnu dot org
  2005-10-05 12:18 ` bonzini at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-05 12:17 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #11 from cvs-commit at gcc dot gnu dot org  2005-10-05 12:17 -------
Subject: Bug 24146

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     bonzini@gcc.gnu.org     2005-10-05 12:17:16

Modified files:
        gcc            : ChangeLog c-typeck.c gimplify.c 
        gcc/cp         : ChangeLog semantics.c 
        gcc/testsuite  : ChangeLog 
        gcc/testsuite/gcc.dg: asm-1.c pr21419.c 
Added files:
        gcc/testsuite/g++.dg/ext: asm7.C asm8.C 
        gcc/testsuite/gcc.dg: asm-pr24146.c 

Log message:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * c-typeck.c (readonly_error): Handle USE being lv_asm.
        (build_asm_expr): Call it if outputs are read-only.
        * gimplify.c (gimplify_asm_expr): Remove former fix to PR 21419.

        cp:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * semantics.c (finish_asm_stmt): Call readonly_error if outputs are
        read-only.  Set ASM_VOLATILE_P for asms without outputs.

        testsuite:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * g++.dg/ext/asm7.C: New.
        * g++.dg/ext/asm8.C: New.
        * gcc.dg/asm-1.c: Compile on all targets.
        * gcc.dg/asm-pr24146.c: New.
        * gcc.dg/pr21419.c: Adjust error messages.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10087&r2=2.10088
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&r1=1.480&r2=1.481
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/gimplify.c.diff?cvsroot=gcc&r1=2.156&r2=2.157
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4912&r2=1.4913
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&r1=1.490&r2=1.491
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6140&r2=1.6141
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/asm7.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/asm8.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/asm-pr24146.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/asm-1.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr21419.c.diff?cvsroot=gcc&r1=1.1&r2=1.2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile
       [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
  2005-10-05 12:17 ` [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile cvs-commit at gcc dot gnu dot org
@ 2005-10-05 12:18 ` bonzini at gcc dot gnu dot org
  2005-10-05 12:19 ` [Bug middle-end/24146] [4.0 " pinskia at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2005-10-05 12:18 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #12 from bonzini at gcc dot gnu dot org  2005-10-05 12:18 -------
fix committed


-- 

bonzini at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0 Regression] ASMs with no output are not marked as volatile
       [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
  2005-10-05 12:17 ` [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile cvs-commit at gcc dot gnu dot org
  2005-10-05 12:18 ` bonzini at gcc dot gnu dot org
@ 2005-10-05 12:19 ` pinskia at gcc dot gnu dot org
  2005-10-05 13:40 ` pinskia at gcc dot gnu dot org
  2005-10-05 13:40 ` cvs-commit at gcc dot gnu dot org
  4 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-05 12:19 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #13 from pinskia at gcc dot gnu dot org  2005-10-05 12:19 -------
(In reply to comment #12)
> fix committed

Except it is latent on the 4.0 branch too.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
      Known to fail|                            |4.0.0
      Known to work|                            |3.4.0
         Resolution|FIXED                       |
            Summary|[4.0/4.1 Regression] ASMs   |[4.0 Regression] ASMs with
                   |with no output are not      |no output are not marked as
                   |marked as volatile          |volatile


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0 Regression] ASMs with no output are not marked as volatile
       [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2005-10-05 13:40 ` pinskia at gcc dot gnu dot org
@ 2005-10-05 13:40 ` cvs-commit at gcc dot gnu dot org
  4 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-05 13:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #14 from cvs-commit at gcc dot gnu dot org  2005-10-05 13:39 -------
Subject: Bug 24146

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     bonzini@gcc.gnu.org     2005-10-05 13:39:51

Modified files:
        gcc            : ChangeLog c-typeck.c gimplify.c 
        gcc/cp         : ChangeLog semantics.c 
        gcc/testsuite  : ChangeLog 
        gcc/testsuite/gcc.dg: asm-1.c pr21419.c 
Added files:
        gcc/testsuite/g++.dg/ext: asm7.C asm8.C 
        gcc/testsuite/gcc.dg: asm-pr24146.c 

Log message:
        gcc:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * c-typeck.c (readonly_error): Handle USE being lv_asm.
        (build_asm_expr): Call it if outputs are read-only.
        * gimplify.c (gimplify_asm_expr): Remove former fix to PR 21419.

        cp:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * semantics.c (finish_asm_stmt): Call readonly_error if outputs are
        read-only.  Set ASM_VOLATILE_P for asms without outputs.

        testsuite:
        2005-10-05  Paolo Bonzini  <bonzini@gnu.org>

        PR tree-optimization/21419
        PR tree-optimization/24146
        PR tree-optimization/24151

        * g++.dg/ext/asm7.C: New.
        * g++.dg/ext/asm8.C: New.
        * gcc.dg/asm-1.c: Compile on all targets.
        * gcc.dg/asm-pr24146.c: New.
        * gcc.dg/pr21419.c: Adjust error messages.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.447&r2=2.7592.2.448
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.419.2.13&r2=1.419.2.14
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/gimplify.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.113.2.13&r2=2.113.2.14
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4648.2.116&r2=1.4648.2.117
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.463.2.10&r2=1.463.2.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.428&r2=1.5084.2.429
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/asm7.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/asm8.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/asm-pr24146.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/asm-1.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1&r2=1.1.166.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr21419.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1.2.1&r2=1.1.2.2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0 Regression] ASMs with no output are not marked as volatile
       [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2005-10-05 12:19 ` [Bug middle-end/24146] [4.0 " pinskia at gcc dot gnu dot org
@ 2005-10-05 13:40 ` pinskia at gcc dot gnu dot org
  2005-10-05 13:40 ` cvs-commit at gcc dot gnu dot org
  4 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-05 13:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #15 from pinskia at gcc dot gnu dot org  2005-10-05 13:40 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile
  2005-09-30 13:42 [Bug tree-optimization/24146] New: Optimizes away FPU control word store rguenth at gcc dot gnu dot org
  2005-09-30 14:36 ` [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile pinskia at gcc dot gnu dot org
@ 2005-09-30 19:52 ` rth at gcc dot gnu dot org
  1 sibling, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu dot org @ 2005-09-30 19:52 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From rth at gcc dot gnu dot org  2005-09-30 19:52 -------
Subject: Re:  [4.0 Regression] Optimizes away FPU control word store

On Fri, Sep 30, 2005 at 02:10:48PM -0000, bonzini at gcc dot gnu dot org wrote:
> rth, should this be fixed in the front-end or in the gimplifier?

Front end.  It's a one liner in build_asm_expr.


r~


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile
  2005-09-30 13:42 [Bug tree-optimization/24146] New: Optimizes away FPU control word store rguenth at gcc dot gnu dot org
@ 2005-09-30 14:36 ` pinskia at gcc dot gnu dot org
  2005-09-30 19:52 ` rth at gcc dot gnu dot org
  1 sibling, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 14:36 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 14:35 -------
4.0 has also the latent bug.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |middle-end
            Summary|[4.0 Regression] Optimizes  |[4.0/4.1 Regression] ASMs
                   |away FPU control word store |with no output are not
                   |                            |marked as volatile
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24146


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2005-10-05 13:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-24146-10053@http.gcc.gnu.org/bugzilla/>
2005-10-05 12:17 ` [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile cvs-commit at gcc dot gnu dot org
2005-10-05 12:18 ` bonzini at gcc dot gnu dot org
2005-10-05 12:19 ` [Bug middle-end/24146] [4.0 " pinskia at gcc dot gnu dot org
2005-10-05 13:40 ` pinskia at gcc dot gnu dot org
2005-10-05 13:40 ` cvs-commit at gcc dot gnu dot org
2005-09-30 13:42 [Bug tree-optimization/24146] New: Optimizes away FPU control word store rguenth at gcc dot gnu dot org
2005-09-30 14:36 ` [Bug middle-end/24146] [4.0/4.1 Regression] ASMs with no output are not marked as volatile pinskia at gcc dot gnu dot org
2005-09-30 19:52 ` rth at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).