public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
@ 2005-10-02 18:39 ` pinskia at gcc dot gnu dot org
  2005-10-04 18:35 ` pinskia at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-02 18:39 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #22 from pinskia at gcc dot gnu dot org  2005-10-02 18:39 -------
Patch posted:
http://gcc.gnu.org/ml/gcc-patches/2005-10/msg00047.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |10/msg00047.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
  2005-10-02 18:39 ` [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc pinskia at gcc dot gnu dot org
@ 2005-10-04 18:35 ` pinskia at gcc dot gnu dot org
  2005-10-05  0:54 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-04 18:35 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #23 from pinskia at gcc dot gnu dot org  2005-10-04 18:35 -------
Created an attachment (id=9874)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9874&action=view)
New patch which takes into the suggesstion from RTH

The new patch, it is simplier and actually fixes the real bug.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #9851 is|0                           |1
           obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
  2005-10-02 18:39 ` [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc pinskia at gcc dot gnu dot org
  2005-10-04 18:35 ` pinskia at gcc dot gnu dot org
@ 2005-10-05  0:54 ` pinskia at gcc dot gnu dot org
  2005-10-05 19:50 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-05  0:54 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #24 from pinskia at gcc dot gnu dot org  2005-10-05 00:54 -------
Created an attachment (id=9887)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9887&action=view)
Patch which fixes the reduced testcase

Sorry about the name of the patch but reload is the worst code I have ever
read.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #9874 is|0                           |1
           obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2005-10-05  0:54 ` pinskia at gcc dot gnu dot org
@ 2005-10-05 19:50 ` cvs-commit at gcc dot gnu dot org
  2005-10-05 19:52 ` pinskia at gcc dot gnu dot org
  2005-10-05 19:52 ` cvs-commit at gcc dot gnu dot org
  5 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-05 19:50 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #25 from cvs-commit at gcc dot gnu dot org  2005-10-05 19:50 -------
Subject: Bug 24069

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     pinskia@gcc.gnu.org     2005-10-05 19:50:28

Modified files:
        gcc            : ChangeLog reload.c 

Log message:
        2005-10-05  Andrew Pinski  <pinskia@physics.uc.edu>

        PR middle-end/20606
        PR middle-end/24069
        * reload.c (subst_reloads): When adding a REG_LABEL to a
        jump instruction, also update JUMP_LABEL.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10094&r2=2.10095
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/reload.c.diff?cvsroot=gcc&r1=1.275&r2=1.276


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2005-10-05 19:50 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-05 19:52 ` pinskia at gcc dot gnu dot org
  2005-10-05 19:52 ` cvs-commit at gcc dot gnu dot org
  5 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-05 19:52 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #27 from pinskia at gcc dot gnu dot org  2005-10-05 19:52 -------
Fixed in both the mainline and 4.0 branch.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.1.0                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
       [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2005-10-05 19:52 ` pinskia at gcc dot gnu dot org
@ 2005-10-05 19:52 ` cvs-commit at gcc dot gnu dot org
  5 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-05 19:52 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #26 from cvs-commit at gcc dot gnu dot org  2005-10-05 19:52 -------
Subject: Bug 24069

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     pinskia@gcc.gnu.org     2005-10-05 19:52:14

Modified files:
        gcc            : ChangeLog reload.c 

Log message:
        2005-10-05  Andrew Pinski  <pinskia@physics.uc.edu>

        PR middle-end/20606
        PR middle-end/24069
        * reload.c (subst_reloads): When adding a REG_LABEL to a
        jump instruction, also update JUMP_LABEL.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.448&r2=2.7592.2.449
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/reload.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.268.2.1&r2=1.268.2.2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
                   ` (5 preceding siblings ...)
  2005-09-30 22:28 ` pinskia at gcc dot gnu dot org
@ 2005-09-30 22:41 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 22:41 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 22:41 -------
Created an attachment (id=9851)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9851&action=view)
Patch which needs testing

Could do you do a profiledbootstrap with this patch?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
                   ` (4 preceding siblings ...)
  2005-09-30 22:22 ` pinskia at gcc dot gnu dot org
@ 2005-09-30 22:28 ` pinskia at gcc dot gnu dot org
  2005-09-30 22:41 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 22:28 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 22:28 -------
This is the same problem as listed in PR 20606 which is not exposed by -freorder-blocks-and-partition 
at all.  I am looking into this further.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |20606
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
                   ` (3 preceding siblings ...)
  2005-09-30 22:21 ` pinskia at gcc dot gnu dot org
@ 2005-09-30 22:22 ` pinskia at gcc dot gnu dot org
  2005-09-30 22:28 ` pinskia at gcc dot gnu dot org
  2005-09-30 22:41 ` pinskia at gcc dot gnu dot org
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 22:22 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 22:22 -------
Note I could reproduce this with a cross crompiler from powerpc-darwin7.9 to powerpc64-linux with 
the following configure options:
Configured with: ../configure --target=powerpc64-linux-gnu --with-cpu=default32


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
                   ` (2 preceding siblings ...)
  2005-09-30 20:34 ` pinskia at gcc dot gnu dot org
@ 2005-09-30 22:21 ` pinskia at gcc dot gnu dot org
  2005-09-30 22:22 ` pinskia at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 22:21 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 22:21 -------
The jump:
(jump_insn:HI 2539 2830 2305 120 (set (pc)
        (reg:SI 66 ctr)) 482 {*indirect_jumpsi} (insn_list:REG_DEP_TRUE 2537 (insn_list:REG_DEP_TRUE 
2538 (insn_list:REG_DEP_TRUE 1498 (nil))))
    (insn_list:REG_LABEL 1504 (expr_list:REG_CROSSING_JUMP (nil)
            (nil))))

And the backtrace:
#0  fancy_abort (file=0x92cb54 "../../gcc/cfgbuild.c", line=350, function=0x8e5374 "make_edges") at 
../../gcc/diagnostic.c:590
#1  0x007db014 in make_edges (min=0x2dd87e8, max=0x2df70b0, update_p=1) at ../../gcc/
cfgbuild.c:350
#2  0x007dc378 in find_many_sub_basic_blocks (blocks=0x1b6d240) at ../../gcc/cfgbuild.c:763
#3  0x0059a7f8 in split_all_insns (upd_life=0) at ../../gcc/recog.c:2795
#4  0x003898ec in rest_of_handle_flow2 () at ../../gcc/flow.c:4624
#5  0x0069f964 in execute_one_pass (pass=0x9fdef4) at ../../gcc/passes.c:809


This makes me feel better.  Plus this is a bug really related to/exposed by -freorder-blocks-and-
partition, we are changing an direct into an indirect one but make_edges is not thinking it should get 
an indirect to a known label here or at least as far as I can tell.

Looking more into it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
  2005-09-30 17:57 ` [Bug middle-end/24069] [4.1 Regression] " pinskia at gcc dot gnu dot org
  2005-09-30 20:16 ` steinmtz at us dot ibm dot com
@ 2005-09-30 20:34 ` pinskia at gcc dot gnu dot org
  2005-09-30 22:21 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 20:34 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 20:34 -------
Actually the jump_insn and the backtrace does not make sense because it should have triggered the 
computed_jump_p part in make_edge.
Can you add a fflush(dump_file); right after the print_rtl_single.  Also can you attach all of the dumps 
for -fdump-tree-all-all because the backtrace does not make sense between that the jump_insn having 
registers allocated already.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
  2005-09-30 17:57 ` [Bug middle-end/24069] [4.1 Regression] " pinskia at gcc dot gnu dot org
@ 2005-09-30 20:16 ` steinmtz at us dot ibm dot com
  2005-09-30 20:34 ` pinskia at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: steinmtz at us dot ibm dot com @ 2005-09-30 20:16 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From steinmtz at us dot ibm dot com  2005-09-30 20:16 -------
Created an attachment (id=9849)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9849&action=view)
Dump from -fdump-rtl-expand-all

Output from -fdump-rtl-expand-all attached as requested.

Note that the jump instruction I posted was obtained by placing the following
call directly before the failing gcc_assert.

      print_rtl_single (dump_file, insn);
      gcc_assert (JUMP_LABEL (insn)); /* failing assert at cfgbuild.c line 350
*/

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc
  2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
@ 2005-09-30 17:57 ` pinskia at gcc dot gnu dot org
  2005-09-30 20:16 ` steinmtz at us dot ibm dot com
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-09-30 17:57 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 17:57 -------
(In reply to comment #14)
> Here's the offending jump:
> 
> (jump_insn:HI 2539 2830 2305 120 (set (pc)
>         (reg:SI 66 ctr [ targetm.asm_out.unwind_label ])) 504 
> {*indirect_jumpsi} (insn_list:REG_DEP_TRUE 2537 (insn_list:REG_DEP_TRUE 2538 
> (insn_list:REG_DEP_TRUE 1498 (nil))))
>     (insn_list:REG_LABEL 1504 (expr_list:REG_CROSSING_JUMP (nil)
>             (nil))))

Huh, this should be an indirect call and not a jump.
Can you attach the dumps from -fdump-rtl-expand-all?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|rtl-optimization            |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24069


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2005-10-05 19:52 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-24069-8614@http.gcc.gnu.org/bugzilla/>
2005-10-02 18:39 ` [Bug middle-end/24069] [4.1 Regression] ice during feedback stage of profiledbootstrap on powerpc pinskia at gcc dot gnu dot org
2005-10-04 18:35 ` pinskia at gcc dot gnu dot org
2005-10-05  0:54 ` pinskia at gcc dot gnu dot org
2005-10-05 19:50 ` cvs-commit at gcc dot gnu dot org
2005-10-05 19:52 ` pinskia at gcc dot gnu dot org
2005-10-05 19:52 ` cvs-commit at gcc dot gnu dot org
2005-09-26 19:49 [Bug gcov/profile/24069] New: " steinmtz at us dot ibm dot com
2005-09-30 17:57 ` [Bug middle-end/24069] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-09-30 20:16 ` steinmtz at us dot ibm dot com
2005-09-30 20:34 ` pinskia at gcc dot gnu dot org
2005-09-30 22:21 ` pinskia at gcc dot gnu dot org
2005-09-30 22:22 ` pinskia at gcc dot gnu dot org
2005-09-30 22:28 ` pinskia at gcc dot gnu dot org
2005-09-30 22:41 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).