public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "per at bothner dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug preprocessor/21250] [4.1 Regression] line number 0 for <built-in> causes GAS to complain Date: Wed, 12 Oct 2005 07:10:00 -0000 [thread overview] Message-ID: <20051012071032.21474.qmail@sourceware.org> (raw) In-Reply-To: <bug-21250-1673@http.gcc.gnu.org/bugzilla/> ------- Comment #9 from per at bothner dot com 2005-10-12 07:10 ------- Subject: Re: [4.1 Regression] line number 0 for <built-in> causes GAS to complain ppluzhnikov at charter dot net wrote: > May I repeat my question: > What is the problem of emitting '#1 <built-in>' anyway? It's certainly better than emitting '#0 <built-in>', but is there any reason for emitting either? > --- gcc/c-opts.c.orig 2005-07-19 05:09:31.000000000 -0700 > +++ gcc/c-opts.c 2005-10-11 22:57:34.000000000 -0700 > @@ -1309,7 +1309,7 @@ > > cb_file_change (parse_in, > linemap_add (&line_table, LC_RENAME, 0, > - _("<built-in>"), 0)); > + _("<built-in>"), 1)); > > cpp_init_builtins (parse_in, flag_hosted); > c_cpp_builtins (parse_in); See my rationale/discussion for the orginal patch: http://gcc.gnu.org/ml/gcc-patches/2005-04/msg02132.html There is eisting code that assumes that builtins have line number 0. Note this is *internally* - one option is to translate internal line number 0 to line number 1 on output. But I think the cleaner solution is to just supress the '#' lines for <built-in>. But people think it is important to keep the '#1 <built-in>' lines, for compatibility, I can convinced. I just think they're pointless. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21250
next prev parent reply other threads:[~2005-10-12 7:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-21250-1673@http.gcc.gnu.org/bugzilla/> 2005-10-12 0:15 ` pinskia at gcc dot gnu dot org 2005-10-12 5:13 ` per at bothner dot com 2005-10-12 6:17 ` ppluzhnikov at charter dot net 2005-10-12 7:10 ` per at bothner dot com [this message] 2005-10-12 7:20 ` per at bothner dot com 2005-10-12 16:22 ` per at bothner dot com 2005-10-12 16:45 ` bothner at gcc dot gnu dot org 2005-10-14 14:56 ` cvs-commit at gcc dot gnu dot org 2005-10-14 17:07 ` pinskia at gcc dot gnu dot org 2005-10-15 17:04 ` cvs-commit at gcc dot gnu dot org 2005-04-27 13:30 [Bug preprocessor/21250] New: " segher at kernel dot crashing dot org 2005-04-27 13:53 ` [Bug preprocessor/21250] [4.1 Regression] " pinskia at gcc dot gnu dot org 2005-04-28 5:12 ` bothner at gcc dot gnu dot org 2005-04-28 15:08 ` segher at kernel dot crashing dot org 2005-04-28 23:59 ` bothner at gcc dot gnu dot org 2005-05-17 21:55 ` pinskia at gcc dot gnu dot org 2005-09-15 23:31 ` ppluzhnikov at charter dot net
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20051012071032.21474.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).