public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
@ 2005-10-13 20:00 ` pinskia at gcc dot gnu dot org
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-13 20:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from pinskia at gcc dot gnu dot org 2005-10-13 20:00 -------
If I have time, I will look into this in the next hour or two. I just have to
look at where the types are compared.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
2005-10-13 20:00 ` [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine pinskia at gcc dot gnu dot org
@ 2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-15 18:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from pinskia at gcc dot gnu dot org 2005-10-15 18:28 -------
I have a fix.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pinskia at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
2005-10-13 20:00 ` [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine pinskia at gcc dot gnu dot org
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
@ 2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
2005-10-26 2:15 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-15 18:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2005-10-15 18:29 -------
Here is the fix which I need to test still:
Index: c-format.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/c-format.c,v
retrieving revision 1.84
diff -u -p -r1.84 c-format.c
--- c-format.c 22 Jul 2005 17:10:34 -0000 1.84
+++ c-format.c 15 Oct 2005 18:29:26 -0000
@@ -2216,7 +2216,7 @@ check_format_types (format_wanted_type *
|| cur_type == unsigned_char_type_node);
/* Check the type of the "real" argument, if there's a type we want. */
- if (wanted_type == cur_type)
+ if (lang_hooks.types_compatible_p (wanted_type, cur_type))
continue;
/* If we want 'void *', allow any pointer type.
(Anything else would already have got a warning.)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
@ 2005-10-26 2:15 ` cvs-commit at gcc dot gnu dot org
2005-10-26 2:20 ` cvs-commit at gcc dot gnu dot org
2005-10-26 2:20 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-26 2:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from cvs-commit at gcc dot gnu dot org 2005-10-26 02:15 -------
Subject: Bug 23103
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: pinskia@gcc.gnu.org 2005-10-26 02:15:03
Modified files:
gcc : ChangeLog c-format.c
Log message:
2005-10-24 Andrew Pinski <pinskia@physics.uc.edu>
PR c/23103
* c-format.c (check_format_types): Use lang_hooks.types_compatible_p
instead of pointer equality when comparing types.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10213&r2=2.10214
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-format.c.diff?cvsroot=gcc&r1=1.84&r2=1.85
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2005-10-26 2:15 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-26 2:20 ` cvs-commit at gcc dot gnu dot org
2005-10-26 2:20 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-26 2:20 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from cvs-commit at gcc dot gnu dot org 2005-10-26 02:20 -------
Subject: Bug 23103
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: pinskia@gcc.gnu.org 2005-10-26 02:20:43
Modified files:
gcc : ChangeLog c-format.c
Log message:
2005-10-24 Andrew Pinski <pinskia@physics.uc.edu>
PR c/23103
* c-format.c (check_format_types): Use
lang_hooks.types_compatible_p
instead of pointer equality when comparing types.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.477&r2=2.7592.2.478
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-format.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.68.16.1&r2=1.68.16.2
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2005-10-26 2:20 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-26 2:20 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-26 2:20 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2005-10-26 02:20 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/23103] New: gcc_diag does not work with -combine
@ 2005-07-27 22:03 pinskia at gcc dot gnu dot org
2005-08-01 16:57 ` [Bug c/23103] [4.0/4.1 Regression] " pinskia at gcc dot gnu dot org
2005-09-27 16:15 ` mmitchel at gcc dot gnu dot org
0 siblings, 2 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-07-27 22:03 UTC (permalink / raw)
To: gcc-bugs
Try compiling the following two source with -combine -Wformat and you will end of with an error
which is wrong:
--- file1.c ---
typedef long long __gcc_host_wide_int__;
typedef struct location_s
{
const char *file;
int line;
} location_t;
union tree_node;
typedef union tree_node *tree;
extern int diag (const char *, ...) __attribute__ ((__format__ (__gcc_diag__, 1, 2))) __attribute__
((__nonnull__));;
void
foo (location_t *loc)
{
diag ("%H", loc);
}
---- end ----
---- file2.c ----
typedef long long __gcc_host_wide_int__;
typedef struct location_s
{
const char *file;
int line;
} location_t;
union tree_node;
typedef union tree_node *tree;
extern int diag (const char *, ...) __attribute__ ((__format__ (__gcc_diag__, 1, 2))) __attribute__
((__nonnull__));;
void
foo1 (location_t *loc)
{
diag ("%H", loc);
}
---- end ----
--
Summary: gcc_diag does not work with -combine
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Keywords: diagnostic, build
Severity: normal
Priority: P2
Component: c
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: pinskia at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2005-10-26 2:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-23103-6528@http.gcc.gnu.org/bugzilla/>
2005-10-13 20:00 ` [Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine pinskia at gcc dot gnu dot org
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
2005-10-15 18:29 ` pinskia at gcc dot gnu dot org
2005-10-26 2:15 ` cvs-commit at gcc dot gnu dot org
2005-10-26 2:20 ` cvs-commit at gcc dot gnu dot org
2005-10-26 2:20 ` pinskia at gcc dot gnu dot org
2005-07-27 22:03 [Bug c/23103] New: " pinskia at gcc dot gnu dot org
2005-08-01 16:57 ` [Bug c/23103] [4.0/4.1 Regression] " pinskia at gcc dot gnu dot org
2005-09-27 16:15 ` mmitchel at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).