[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2005-10-13 20:00 -------
If I have time, I will look into this in the next hour or two.  I just have to
look at where the types are compared.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-10-15 18:29 -------
Here is the fix which I need to test still:
Index: c-format.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/c-format.c,v
retrieving revision 1.84
diff -u -p -r1.84 c-format.c
--- c-format.c  22 Jul 2005 17:10:34 -0000      1.84
+++ c-format.c  15 Oct 2005 18:29:26 -0000
@@ -2216,7 +2216,7 @@ check_format_types (format_wanted_type *
                          || cur_type == unsigned_char_type_node);

       /* Check the type of the "real" argument, if there's a type we want.  */
-      if (wanted_type == cur_type)
+      if (lang_hooks.types_compatible_p (wanted_type, cur_type))
        continue;
       /* If we want 'void *', allow any pointer type.
         (Anything else would already have got a warning.)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-10-15 18:28 -------
I have a fix.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[cvs-commit at gcc dot gnu dot org]

------- Comment #6 from cvs-commit at gcc dot gnu dot org  2005-10-26 02:15 -------
Subject: Bug 23103

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     pinskia@gcc.gnu.org     2005-10-26 02:15:03

Modified files:
        gcc            : ChangeLog c-format.c 

Log message:
        2005-10-24  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c/23103
        * c-format.c (check_format_types): Use lang_hooks.types_compatible_p
        instead of pointer equality when comparing types.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.10213&r2=2.10214
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-format.c.diff?cvsroot=gcc&r1=1.84&r2=1.85


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2005-10-26 02:20 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[cvs-commit at gcc dot gnu dot org]

------- Comment #8 from cvs-commit at gcc dot gnu dot org  2005-10-26 02:20 -------
Subject: Bug 23103

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     pinskia@gcc.gnu.org     2005-10-26 02:20:43

Modified files:
        gcc            : ChangeLog c-format.c 

Log message:
        2005-10-24  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c/23103
        * c-format.c (check_format_types): Use
        lang_hooks.types_compatible_p
        instead of pointer equality when comparing types.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.477&r2=2.7592.2.478
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-format.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.68.16.1&r2=1.68.16.2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103

[Bug c/23103] [4.0/4.1 Regression] gcc_diag does not work with -combine

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-01 16:57 -------
This worked with 3.4.0.

Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
      Known to fail|                            |4.0.0 4.1.0
      Known to work|                            |3.4.0
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-01 16:57:25
               date|                            |
            Summary|gcc_diag does not work with |[4.0/4.1 Regression]
                   |-combine                    |gcc_diag does not work with
                   |                            |-combine
   Target Milestone|---                         |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23103