[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[nathan at gcc dot gnu dot org]

------- Comment #12 from nathan at gcc dot gnu dot org  2005-10-17 17:36 -------
I'll take a look


-- 

nathan at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|reichelt at gcc dot gnu dot |nathan at gcc dot gnu dot
                   |org                         |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[cvs-commit at gcc dot gnu dot org]

------- Comment #13 from cvs-commit at gcc dot gnu dot org  2005-10-18 12:30 -------
Subject: Bug 22604

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     nathan@gcc.gnu.org      2005-10-18 12:30:33

Modified files:
        gcc/cp         : ChangeLog cp-tree.h class.c semantics.c 
        gcc/testsuite  : ChangeLog 
Added files:
        gcc/testsuite/g++.dg/overload: error2.C 
        gcc/testsuite/g++.dg/inherit: covariant14.C 

Log message:
        cp:
        PR c++/22604
        * class.c (update_vtable_entry_for_fn): Don't process invalid
        covariant overriders.

        PR c++/23118
        * cp-tree.h (add_method): Add return value.
        * class.c (add_method): Return success indicator.
        * semantics.c (finish_member_declaration): Don't add an invalid
        method to the method list.
        testsuite:
        PR c++/23118
        * g++.dg/overload/error2.C: New.

        PR c++/22604
        * g++.dg/inherit/covariant14.C: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4944&r2=1.4945
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&r1=1.1168&r2=1.1169
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/class.c.diff?cvsroot=gcc&r1=1.737&r2=1.738
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&r1=1.493&r2=1.494
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6207&r2=1.6208
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/overload/error2.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/inherit/covariant14.C.diff?cvsroot=gcc&r1=NONE&r2=1.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[cvs-commit at gcc dot gnu dot org]

------- Comment #14 from cvs-commit at gcc dot gnu dot org  2005-10-18 12:34 -------
Subject: Bug 22604

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     nathan@gcc.gnu.org      2005-10-18 12:34:30

Modified files:
        gcc/cp         : ChangeLog cp-tree.h class.c semantics.c 
        gcc/testsuite  : ChangeLog 
Added files:
        gcc/testsuite/g++.dg/overload: error2.C 
        gcc/testsuite/g++.dg/inherit: covariant14.C 

Log message:
        cp:
        PR c++/22604
        * class.c (update_vtable_entry_for_fn): Don't process invalid
        covariant overriders.

        PR c++/23118
        * cp-tree.h (add_method): Add return value.
        * class.c (add_method): Return success indicator.
        * semantics.c (finish_member_declaration): Don't add an invalid
        method to the method list.
        testsuite:
        PR c++/23118
        * g++.dg/overload/error2.C: New.

        PR c++/22604
        * g++.dg/inherit/covariant14.C: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4648.2.142&r2=1.4648.2.143
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1106.2.17&r2=1.1106.2.18
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/class.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.707.2.8&r2=1.707.2.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.463.2.12&r2=1.463.2.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.466&r2=1.5084.2.467
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/overload/error2.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/inherit/covariant14.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[nathan at gcc dot gnu dot org]

------- Comment #15 from nathan at gcc dot gnu dot org  2005-10-18 12:40 -------
fixed mainline and 4.0
2005-10-18  Nathan Sidwell  <nathan@codesourcery.com>

        PR c++/22604
        * class.c (update_vtable_entry_for_fn): Don't process invalid
        covariant overriders.

        PR c++/23118
        * cp-tree.h (add_method): Add return value.
        * class.c (add_method): Return success indicator.
        * semantics.c (finish_member_declaration): Don't add an invalid
        method to the method list.

wont fix 3.4


-- 

nathan at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[flash at pobox dot com]

------- Additional Comments From flash at pobox dot com  2005-08-12 01:26 -------
The patch looks good.  A checking=yes build, with patches 20161-8277, 22508-2005-08-00326, 
22600-9330, and 22604-2005-08-00334, rejected the file BBinder_segfault.ii without an ICE.  (A 
checking=all build is still building.)  A run of  'make check' didn't report any unexpected errors.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-08 18:13 -------
This worked with 20041211.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-05 15:43 -------
Testing a patch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-08-05 15:28 -------
For the record: The bug from comment #6 is tracked in PR23118.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-28 03:27 -------
(In reply to comment #6)
> Here's another segfault, originally PalmSource bug 105158, but after Delta reduction it looked 
similar:

That is a different issue, please file as a seperate bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[flash at pobox dot com]

------- Additional Comments From flash at pobox dot com  2005-07-28 03:15 -------
Here's another segfault, originally PalmSource bug 105158, but after Delta reduction it looked similar:

class nameOne : public nameTwo, public nameThree, public nameFour, public nameFive, public nameSix
{
 void nameSeven(const nameEight &name, const nameNine & icon);
 virtual void nameSeven(const nameEight& name, const nameTen &icon);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604

[Bug c++/22604] [4.0/4.1 Regression] ICE after invalid covariant return

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2005-07-25 13:11 -------
Here's an example that only contains one error:

==============================================
struct A;

struct B
{
    virtual A* foo();
};

namespace N
{
    struct A : B
    {
        virtual A* foo(); // should be ::A*
    };
}
==============================================


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
           Keywords|                            |monitored
            Summary|[4.0/4.1 Regression]        |[4.0/4.1 Regression] ICE
                   |"internal compiler error"   |after invalid covariant
                   |after invalid covariant     |return
                   |return                      |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22604