[Bug fortran/24440] New: [4.0 regression] gfortran failed to build 187.facerec

[Bug fortran/24440] New: [4.0 regression] gfortran failed to build 187.facerec

[hjl at lucon dot org]

Gcc 4.0 checked out at Tue Oct 18 19:14:50 UTC 2005 failed to build
build 187.facerec in SPEC CPU 2K. I got

Starting program: /usr/gcc-4.0/libexec/gcc/x86_64-unknown-linux-gnu/4.0.3/f951
parameterRoutines.f90 -quiet -dumpbase parameterRoutines.f90 -mtune=k8 -auxbase
parameterRoutines -O2 -version -o parameterRoutines.s
GNU F95 version 4.0.3 20051018 (prerelease) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.0.3 20051018 (prerelease).
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072

Program received signal SIGSEGV, Segmentation fault.
0x000000000043f4d1 in resolve_symbol (sym=0xa78940)
    at /net/gnu-13/export/gnu/src/gcc-4.0/gcc/gcc/fortran/resolve.c:4265
4265      if (sym->ts.type == BT_DERIVED
(gdb) list
4260            }
4261        }
4262
4263      /* An assumed-size array with INTENT(OUT) shall not be of a type for
which
4264         default initialization is defined (5.1.2.4.4).  */
4265      if (sym->ts.type == BT_DERIVED
4266            && sym->attr.dummy
4267            && sym->attr.intent == INTENT_OUT
4268            && sym->as->type == AS_ASSUMED_SIZE)
4269        {
(gdb) p sym->as
$6 = (gfc_array_spec *) 0x0

Gcc 4.0.3 20050930 is OK.


-- 
           Summary: [4.0 regression]  gfortran failed to build 187.facerec
           Product: gcc
           Version: 4.0.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0 regression] gfortran failed to build 187.facerec

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2005-10-19 00:48 -------
It is caused by

http://gcc.gnu.org/ml/gcc-patches/2005-10/msg00433.html

It doesn't check if sym->as is NULL before dereferencing it.


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-10-19 00:49 -------
Do you have a reduced testcase as most fortran developers don't have access to
SPEC.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[paulthomas2 at wanadoo dot fr]

------- Comment #3 from paulthomas2 at wanadoo dot fr  2005-10-19 02:54 -------
Subject: Re:  [4.0 regression]  gfortran failed to build
 187.facerec

hjl at lucon dot org wrote:

>------- Comment #1 from hjl at lucon dot org  2005-10-19 00:48 -------
>It is caused by
>
>http://gcc.gnu.org/ml/gcc-patches/2005-10/msg00433.html
>
>It doesn't check if sym->as is NULL before dereferencing it.
>
>
>  
>
You are absolutely correct - thanks.  I wll submit:

  if (sym->ts.type == BT_DERIVED
        && sym->attr.dummy
        && sym->attr.intent == INTENT_OUT
+       && sym->as
        && sym->as->type == AS_ASSUMED_SIZE)

 as being obvious.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[cvs-commit at gcc dot gnu dot org]

------- Comment #4 from cvs-commit at gcc dot gnu dot org  2005-10-19 03:52 -------
Subject: Bug 24440

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     pault@gcc.gnu.org       2005-10-19 03:52:28

Modified files:
        gcc/fortran    : resolve.c ChangeLog 

Log message:
        2005-10-19  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24440
        * resolve.c (resolve_symbol): Correct error in check for
        assumed size array with default initializer by testing
        for arrayspec before dereferencing it.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/resolve.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.34.2.19&r2=1.34.2.20
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.335.2.131&r2=1.335.2.132


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[cvs-commit at gcc dot gnu dot org]

------- Comment #5 from cvs-commit at gcc dot gnu dot org  2005-10-19 05:33 -------
Subject: Bug 24440

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     pault@gcc.gnu.org       2005-10-19 05:33:32

Modified files:
        gcc/fortran    : resolve.c ChangeLog 

Log message:
        2005-10-19  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24440
        * resolve.c (resolve_symbol): Correct error in check for
        assumed size array with default initializer by testing
        for arrayspec before dereferencing it.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/resolve.c.diff?cvsroot=gcc&r1=1.60&r2=1.61
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.588&r2=1.589


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2005-10-19 05:35 -------
Corrected on both head and 4.0

Note that I have not added a testcase but did check that the segfault no longer
happens.

Paul T


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[cvs-commit at gcc dot gnu dot org]

------- Comment #7 from cvs-commit at gcc dot gnu dot org  2005-10-21 04:33 -------
Subject: Bug 24440

CVSROOT:        /cvs/gcc
Module name:    gcc
Changes by:     pault@gcc.gnu.org       2005-10-21 04:33:10

Modified files:
        gcc/testsuite/gfortran.dg: assumed_size_dt_dummy.f90 
        gcc/testsuite  : ChangeLog 

Log message:
        2005-10-21  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24440
        * gfortran.dg/assumed_size_dt_dummy.f90: Add test for scalar case.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/assumed_size_dt_dummy.f90.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6223&r2=1.6224


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440

[Bug fortran/24440] [4.0/4.1 regression] gfortran failed to build 187.facerec

[cvs-commit at gcc dot gnu dot org]

------- Comment #8 from cvs-commit at gcc dot gnu dot org  2005-10-21 04:37 -------
Subject: Bug 24440

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     pault@gcc.gnu.org       2005-10-21 04:37:42

Modified files:
        gcc/testsuite/gfortran.dg: assumed_size_dt_dummy.f90 
        gcc/testsuite  : ChangeLog 

Log message:
        2005-10-21  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24440
        * gfortran.dg/assumed_size_dt_dummy.f90: Add test for scalar case.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/assumed_size_dt_dummy.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1.2.1&r2=1.1.2.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.476&r2=1.5084.2.477


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24440