public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wilson at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/24202] [3.4/4.0/4.1 Regression] Segfault with #pragma once
Date: Tue, 01 Nov 2005 23:51:00 -0000	[thread overview]
Message-ID: <20051101235147.31755.qmail@sourceware.org> (raw)
In-Reply-To: <bug-24202-5724@http.gcc.gnu.org/bugzilla/>



------- Comment #13 from wilson at gcc dot gnu dot org  2005-11-01 23:51 -------
I believe the problem originated here:
2003-07-29  Neil Booth  <neil@daikokuya.co.uk>

        PR preprocessor/11569
        PR preprocessor/11649
        * Makefile.in (LIBCPP_DEPS): Add HASHTAB_H.
        * cppfiles.c: Completely rewritten.
        ...

This added the buffer_valid field, and added code that clears buffer without
also clearing buffer_valid.  This is revision 1.178 in the gcc/cppfiles.c file.

The failure occurs only when we free a valid buffer, and then try to reuse that
buffer because we still think it is valid.  Whether this occurs depends on how
buffers are managed by cpp, and how they are used by cpp, so I don't find it
surprising that this latent bug has been disappearing and reappearing over
time.  The patch identified by Janis just makes the problem more visible
because it adds more uses of buffer_valid.

Now I'm off to test my patch.  The same patch should work for all 3 gcc
versions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24202


  parent reply	other threads:[~2005-11-01 23:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-04 21:59 [Bug preprocessor/24202] New: " debian-gcc at lists dot debian dot org
2005-10-04 21:59 ` [Bug preprocessor/24202] " debian-gcc at lists dot debian dot org
2005-10-04 23:05 ` [Bug preprocessor/24202] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-10-06 22:21 ` janis187 at us dot ibm dot com
2005-10-07 19:45 ` janis187 at us dot ibm dot com
2005-10-07 19:50 ` [Bug preprocessor/24202] [4.0/4.1 " pinskia at gcc dot gnu dot org
2005-10-08 13:37 ` pinskia at gcc dot gnu dot org
2005-10-08 22:10 ` janis at gcc dot gnu dot org
2005-10-08 22:11 ` janis at gcc dot gnu dot org
2005-10-31  6:02 ` [Bug preprocessor/24202] [3.4/4.0/4.1 " mmitchel at gcc dot gnu dot org
2005-11-01  7:19 ` wilson at gcc dot gnu dot org
2005-11-01  7:22 ` wilson at gcc dot gnu dot org
2005-11-01  7:25 ` wilson at gcc dot gnu dot org
2005-11-01 23:51 ` wilson at gcc dot gnu dot org [this message]
2005-11-04  2:10 ` wilson at gcc dot gnu dot org
2005-11-04  2:13 ` wilson at gcc dot gnu dot org
2005-11-04  4:42 ` [Bug preprocessor/24202] [3.4 " pinskia at gcc dot gnu dot org
2006-03-01 10:11 ` gdr at gcc dot gnu dot org
2006-03-01 10:11 ` gdr at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051101235147.31755.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).