* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
@ 2005-11-02 20:41 ` pinskia at gcc dot gnu dot org
2005-11-02 20:49 ` olh at suse dot de
` (25 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-02 20:41 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu dot
| |org
Component|c |middle-end
Keywords| |wrong-code
Summary|gcc-4.1 compiled ppc64 |[4.1 Regression] gcc-4.1
|kernels do not boot |compiled ppc64 kernels do
| |not boot
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
2005-11-02 20:41 ` [Bug middle-end/24644] [4.1 Regression] " pinskia at gcc dot gnu dot org
@ 2005-11-02 20:49 ` olh at suse dot de
2005-11-03 6:46 ` mmitchel at gcc dot gnu dot org
` (24 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-02 20:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from olh at suse dot de 2005-11-02 20:49 -------
Created an attachment (id=10115)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10115&action=view)
PR24644.tar.bz2
buildscripts, preprocessed files, kernel .config and debug patches, bootlog.
building with -O1 does not fix it.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
2005-11-02 20:41 ` [Bug middle-end/24644] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-11-02 20:49 ` olh at suse dot de
@ 2005-11-03 6:46 ` mmitchel at gcc dot gnu dot org
2005-11-03 8:24 ` olh at suse dot de
` (23 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2005-11-03 6:46 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from mmitchel at gcc dot gnu dot org 2005-11-03 06:46 -------
Until we have a testcase that actually shows some evidence that the toolchain
is at fault, there is nothing for us to investigate; it could equally well be
that the kernel has a bug.
--
mmitchel at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |WAITING
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (2 preceding siblings ...)
2005-11-03 6:46 ` mmitchel at gcc dot gnu dot org
@ 2005-11-03 8:24 ` olh at suse dot de
2005-11-03 12:58 ` olh at suse dot de
` (22 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 8:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from olh at suse dot de 2005-11-03 08:24 -------
copying the schedule.o from gcc41 tree to gcc40 tree doesnt help.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (3 preceding siblings ...)
2005-11-03 8:24 ` olh at suse dot de
@ 2005-11-03 12:58 ` olh at suse dot de
2005-11-03 13:05 ` olh at suse dot de
` (21 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 12:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from olh at suse dot de 2005-11-03 12:58 -------
What I have found so far with even more debugging:
<4>Processor 1 found.
<7>schedule(2883) swapper(0):c1,j4294892318 c0000000142ae100
<6>Brought up 2 CPUs
<7>_spin_lock_irq(85) swapper(0):c1,j4294892318 l c0000000142ae100 c
c0000000004db98c
<7>schedule(2996) swapper(0):c1,j4294892318 p c00000000ffd7040 n
c00000000ffd2040 r c0000000142ae100
<7>schedule(3002) swapper(0):c1,j4294892318 p c00000000ffd7040 n
c00000000ffd2040 r c0000000142ae100
<7>schedule(3029) swapper(1):c0,j4294892318 p c00000000ffd7040 n
c00000000ffd7810 r c0000000142a6100 t c0000000142a6100
<7>finish_task_switch(1539) swapper(1):c0,j4294892318 r c0000000142a6100 p
c00000000ffd7040
<7>finish_lock_switch(297) swapper(1):c0,j4294892318
<7>_spin_unlock_irq(292) migration/1(5):c1,j4294892318 l c0000000142a6100 c
c0000000004dbd24
<4>BUG: spinlock already unlocked on CPU#1, migration/1/5
schedule() line 2883 grabs the rq at c0000000142ae100 on cpu1, and calls
spinlock.
later in line 3029, it switches to cpu0 and rq becomes c0000000142a6100,
this is after context_switch(), barrier(), finish_task_switch(),
finish_lock_switch()
For some reason, the _spin_unlock_irq() call from finish_lock_switch() happens
on cpu1?
But this should be no real problem, the real thing is, why changed rq
from c0000000142ae100 to c0000000142a6100 between lines 3002 and 3029.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (4 preceding siblings ...)
2005-11-03 12:58 ` olh at suse dot de
@ 2005-11-03 13:05 ` olh at suse dot de
2005-11-03 13:32 ` olh at suse dot de
` (20 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 13:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from olh at suse dot de 2005-11-03 13:05 -------
Created an attachment (id=10123)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10123&action=view)
PR24644-2.tar.bz2
rq does change between the context switch.
<7>schedule(3025) swapper(0):c1,j4294892318 p c00000000ffd7040 n
c00000000ffd2040 r c0000000142ae100
<7>schedule(3027) swapper(1):c0,j4294892318 p c00000000ffd7040 n
c00000000ffd7810 r c0000000142a6100
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (5 preceding siblings ...)
2005-11-03 13:05 ` olh at suse dot de
@ 2005-11-03 13:32 ` olh at suse dot de
2005-11-03 21:30 ` olh at suse dot de
` (19 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 13:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from olh at suse dot de 2005-11-03 13:31 -------
c0000000142ae100 is for cpu1, while c0000000142a6100 is for cpu0.
cpu1 was never active before, so all task switches were ok.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (6 preceding siblings ...)
2005-11-03 13:32 ` olh at suse dot de
@ 2005-11-03 21:30 ` olh at suse dot de
2005-11-03 21:48 ` bergner at vnet dot ibm dot com
` (18 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 21:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from olh at suse dot de 2005-11-03 21:30 -------
Created an attachment (id=10135)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10135&action=view)
PR24644-3.tar.bz2
revision 102096 works, revision 102098 doesnt.
copying the sched.o from the 102098 tree into the 102096 tree doesnt work
either.
diff -purN gcc-mainline-music-r102096/ChangeLog
gcc-mainline-music-r102098/ChangeLog
--- gcc-mainline-music-r102096/ChangeLog 2005-07-16 02:30:53.000000000
+0000
+++ gcc-mainline-music-r102098/ChangeLog 2005-07-16 18:56:53.000000000
+0000
@@ -1,3 +1,53 @@
+2005-07-16 Danny Berlin <dberlin@dberlin.org>
+ Kenneth Zadeck <zadeck@naturalbridge.com>
+
+ * Makefile.in: Added rules for ipa-pure-const.c, ipa-reference.c,
+ ipa-reference.h, ipa-utils.c, ipa-utils.h, ipa-type-escape.c,
+ ipa-type-escape.h, tree-promote-statics.c
...
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (7 preceding siblings ...)
2005-11-03 21:30 ` olh at suse dot de
@ 2005-11-03 21:48 ` bergner at vnet dot ibm dot com
2005-11-03 22:05 ` olh at suse dot de
` (17 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: bergner at vnet dot ibm dot com @ 2005-11-03 21:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from bergner at vnet dot ibm dot com 2005-11-03 21:48 -------
Adding myself to the CC list.
--
bergner at vnet dot ibm dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bergner at vnet dot ibm dot
| |com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (8 preceding siblings ...)
2005-11-03 21:48 ` bergner at vnet dot ibm dot com
@ 2005-11-03 22:05 ` olh at suse dot de
2005-11-04 5:48 ` ian at airs dot com
` (16 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-03 22:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from olh at suse dot de 2005-11-03 22:05 -------
Created an attachment (id=10136)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10136&action=view)
PR24644-4.tar.bz2
object files and extracted asm functions for easier comparsion
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (9 preceding siblings ...)
2005-11-03 22:05 ` olh at suse dot de
@ 2005-11-04 5:48 ` ian at airs dot com
2005-11-04 5:52 ` bergner at vnet dot ibm dot com
` (15 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: ian at airs dot com @ 2005-11-04 5:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from ian at airs dot com 2005-11-04 05:48 -------
>From IRC, the problem seems to be that gcc is copying the value out of a global
register variable, which it was not doing before. This is not acceptable, as
the global register may be changed on any context switch, and it is important
to always use the current value each time it is dereferenced.
Declaring the global register variable as volatile may fix the problem,
although one then gets an annoying unconditional warning every time you run the
compiler ("volatile register variables don't work as you might wish"). The
volatile qualifier is recorded at the tree level, but it is not recorded at the
RTL level. At the RTL level global registers are sometimes treated as volatile
(e.g., hash_rtx in cse.c) and sometimes not (e.g., they are not noticed by
volatile_refs_p, and thus are permitted in the input instructions in combine).
So some fixes that come to mind are, in order of increasing difficulty:
1) Change the source code to declare the variable volatile, and provide an
option to disable the warning.
2) Change global registers to be volatile by default in the C/C++ frontends,
and move the warning to there.
3) Change the source code to declare the variable volatile, and fix the RTL
level to handle volatile register variables correctly.
--
ian at airs dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ian at airs dot com
Status|WAITING |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2005-11-04 05:48:27
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (10 preceding siblings ...)
2005-11-04 5:48 ` ian at airs dot com
@ 2005-11-04 5:52 ` bergner at vnet dot ibm dot com
2005-11-04 7:18 ` olh at suse dot de
` (14 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: bergner at vnet dot ibm dot com @ 2005-11-04 5:52 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from bergner at vnet dot ibm dot com 2005-11-04 05:52 -------
I've determined why we're dying, but not sure who is at fault yet. While
scanning through Olaf's assembly diff's, I noticed some code that normally
wouldn't be a problem in user code, but is problamatic in PPC64 kernel code:
New code:
mr r24, r13
[snip]
ld r9,360(r24)
Old code:
[snip]
ld r9, 360(r13)
The problem here is that r13 is a reserved register for the kernel (local_paca
pointer) and can change values on a context switch if we migrate to another
processor. so copying the value out of r13 is a no no. Given what Olaf was
seeing, this seems to be the case here.
The problamatic source line is from linux-2.6.X/include/asm-ppc64/paca.h:
register struct paca_struct *local_paca asm ("r13");
Changing this to:
register struct paca_struct * volatile local_paca asm ("r13");
gave this warning message:
warning: volatile register variables don't work as you might wish
It's only a warning and looking at the disassembly, the code looks good. Olaf,
can you add the volatile above an try booting again? Talking with Paulus, he
isn't too trilled about the warning message which will occur for every file
that uses current (lots!) so we're still not sure if there is a different
kernel fix/tweek for this to whether gcc needs to change or both.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (11 preceding siblings ...)
2005-11-04 5:52 ` bergner at vnet dot ibm dot com
@ 2005-11-04 7:18 ` olh at suse dot de
2005-11-04 7:46 ` olh at suse dot de
` (13 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-04 7:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from olh at suse dot de 2005-11-04 07:18 -------
Yes, adding the volatile fixes it for me.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (12 preceding siblings ...)
2005-11-04 7:18 ` olh at suse dot de
@ 2005-11-04 7:46 ` olh at suse dot de
2005-11-04 16:09 ` ian at airs dot com
` (12 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-04 7:46 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from olh at suse dot de 2005-11-04 07:45 -------
Why does gcc make copies of r13 anyway, when it could just use it where needed?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (13 preceding siblings ...)
2005-11-04 7:46 ` olh at suse dot de
@ 2005-11-04 16:09 ` ian at airs dot com
2005-11-04 17:38 ` bergner at vnet dot ibm dot com
` (11 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: ian at airs dot com @ 2005-11-04 16:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from ian at airs dot com 2005-11-04 16:09 -------
gcc is free to copy non-volatile variables. It does this in many places and
for many reasons, particularly in the new SSA optimizers in 4.0 and later. I
don't know the details of where it decided to copy the register in this test
case, but presumably it seemed profitable to some heuristic. I expect that it
could happen if the usage is in a loop, or used on both branches of an if
conditional, etc.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (14 preceding siblings ...)
2005-11-04 16:09 ` ian at airs dot com
@ 2005-11-04 17:38 ` bergner at vnet dot ibm dot com
2005-11-04 18:00 ` pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: bergner at vnet dot ibm dot com @ 2005-11-04 17:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from bergner at vnet dot ibm dot com 2005-11-04 17:38 -------
For completeness, here is a minimal test case that shows the problem we are
having:
bergner@vervain:~/olaf/PR24644-4> cat bar.c
register struct paca_struct * local_paca asm("r13");
struct paca_struct { volatile long state; };
extern void foo(void);
int migration_thread(void)
{
local_paca->state = 1;
foo();
local_paca->state = 0;
return 0;
}
bergner@vervain:~/olaf/PR24644-4> ~/gcc/dataflow-base/bin/gcc -m64 -O1 -S bar.c
The code we get looks like:
.migration_thread:
mflr 0
std 29,-24(1)
std 0,16(1)
stdu 1,-144(1)
mr 29,13
li 0,1
std 0,0(13)
bl .foo
nop
li 0,0
std 0,0(29)
li 3,0
addi 1,1,144
ld 0,16(1)
mtlr 0
ld 29,-24(1)
blr
This looks like gcc thinks r13 will be trashed by the call to foo() so it
copies it to a non volatile register for use after the call. Strange that this
didn't happen before the patch found by Olaf.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (15 preceding siblings ...)
2005-11-04 17:38 ` bergner at vnet dot ibm dot com
@ 2005-11-04 18:00 ` pinskia at gcc dot gnu dot org
2005-11-04 18:06 ` pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 18:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #16 from pinskia at gcc dot gnu dot org 2005-11-04 18:00 -------
(In reply to comment #15)
> This looks like gcc thinks r13 will be trashed by the call to foo() so it
> copies it to a non volatile register for use after the call. Strange that this
> didn't happen before the patch found by Olaf.
Actually it is the opposite way. GCC thinks that r13 will not trash (clobber)
it, so it copies it. I wonder why this happens as I think it should be marked
as call clobber.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug middle-end/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (16 preceding siblings ...)
2005-11-04 18:00 ` pinskia at gcc dot gnu dot org
@ 2005-11-04 18:06 ` pinskia at gcc dot gnu dot org
2005-11-04 18:07 ` [Bug tree-optimization/24644] " pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 18:06 UTC (permalink / raw)
To: gcc-bugs
------- Comment #17 from pinskia at gcc dot gnu dot org 2005-11-04 18:06 -------
Variable: local_paca, UID 1270, struct paca_struct *, is global, call
clobbered, default def: local_paca_1
But we get:
# TMT.6_8 = V_MAY_DEF <TMT.6_7>;
# VUSE <local_paca_1>;
foo ();
I don't understand why because to me r13 should be able to change in foo so we
should get V_MAY_DEF there.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |alias
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug tree-optimization/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (17 preceding siblings ...)
2005-11-04 18:06 ` pinskia at gcc dot gnu dot org
@ 2005-11-04 18:07 ` pinskia at gcc dot gnu dot org
2005-11-04 18:21 ` pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 18:07 UTC (permalink / raw)
To: gcc-bugs
------- Comment #18 from pinskia at gcc dot gnu dot org 2005-11-04 18:07 -------
That testcase shows that we have a big problem, as local_paca (aka r13) should
be marked as call clobbered.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |critical
Component|middle-end |tree-optimization
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug tree-optimization/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (18 preceding siblings ...)
2005-11-04 18:07 ` [Bug tree-optimization/24644] " pinskia at gcc dot gnu dot org
@ 2005-11-04 18:21 ` pinskia at gcc dot gnu dot org
2005-11-04 18:33 ` pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 18:21 UTC (permalink / raw)
To: gcc-bugs
------- Comment #19 from pinskia at gcc dot gnu dot org 2005-11-04 18:21 -------
The problem is that ipa-static is looking at the variable because the front-end
marked it as a static variable. Daniel Berlin has sugggested a fix, and I will
test it with the reduced test case and then if you could test it with the full
kernel that would be nice.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug tree-optimization/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (19 preceding siblings ...)
2005-11-04 18:21 ` pinskia at gcc dot gnu dot org
@ 2005-11-04 18:33 ` pinskia at gcc dot gnu dot org
2005-11-04 19:15 ` olh at suse dot de
` (5 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 18:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #20 from pinskia at gcc dot gnu dot org 2005-11-04 18:33 -------
Created an attachment (id=10147)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10147&action=view)
Patch to try
This patch should fix the issue in the reduced testcase but I don't know if it
fixes it fully, Can one of you two test it with the kernel?
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pinskia at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug tree-optimization/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (20 preceding siblings ...)
2005-11-04 18:33 ` pinskia at gcc dot gnu dot org
@ 2005-11-04 19:15 ` olh at suse dot de
2005-11-04 21:21 ` [Bug c/24644] " pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-04 19:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #21 from olh at suse dot de 2005-11-04 19:15 -------
yes, this patch helps. tested with r106499.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug c/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (21 preceding siblings ...)
2005-11-04 19:15 ` olh at suse dot de
@ 2005-11-04 21:21 ` pinskia at gcc dot gnu dot org
2005-11-05 20:31 ` olh at suse dot de
` (3 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-04 21:21 UTC (permalink / raw)
To: gcc-bugs
------- Comment #22 from pinskia at gcc dot gnu dot org 2005-11-04 21:21 -------
Hmm, my patch is not fully correct but the C++ front-end gets this correct.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|tree-optimization |c
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug c/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (22 preceding siblings ...)
2005-11-04 21:21 ` [Bug c/24644] " pinskia at gcc dot gnu dot org
@ 2005-11-05 20:31 ` olh at suse dot de
2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
26 siblings, 0 replies; 28+ messages in thread
From: olh at suse dot de @ 2005-11-05 20:31 UTC (permalink / raw)
To: gcc-bugs
------- Comment #23 from olh at suse dot de 2005-11-05 20:31 -------
this patch works, tested with r106530
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug c/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (23 preceding siblings ...)
2005-11-05 20:31 ` olh at suse dot de
@ 2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
2005-11-11 18:00 ` dje at gcc dot gnu dot org
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-09 12:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #24 from pinskia at gcc dot gnu dot org 2005-11-09 12:34 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug c/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (24 preceding siblings ...)
2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
@ 2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
2005-11-11 18:00 ` dje at gcc dot gnu dot org
26 siblings, 0 replies; 28+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-09 12:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #24 from pinskia at gcc dot gnu dot org 2005-11-09 12:34 -------
Fixed.
------- Comment #25 from pinskia at gcc dot gnu dot org 2005-11-09 12:34 -------
Subject: Bug 24644
Author: pinskia
Date: Wed Nov 9 12:33:59 2005
New Revision: 106693
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106693
Log:
2005-11-09 Andrew Pinski <pinskia@physics.uc.edu>
PR c/24644
* dwarf2-out.c (add_name_and_src_coords_attributes): Don't add
a linkage name for a variable if it a register variable.
* c-decl.c (grokdeclarator): Global register variables
should be set as PUBLIC.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c-decl.c
trunk/gcc/dwarf2out.c
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread* [Bug c/24644] [4.1 Regression] gcc-4.1 compiled ppc64 kernels do not boot
2005-11-02 20:40 [Bug c/24644] New: gcc-4.1 compiled ppc64 kernels do not boot olh at suse dot de
` (25 preceding siblings ...)
2005-11-09 12:34 ` pinskia at gcc dot gnu dot org
@ 2005-11-11 18:00 ` dje at gcc dot gnu dot org
26 siblings, 0 replies; 28+ messages in thread
From: dje at gcc dot gnu dot org @ 2005-11-11 18:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #26 from dje at gcc dot gnu dot org 2005-11-11 17:59 -------
Subject: Bug 24644
Author: dje
Date: Fri Nov 11 17:59:54 2005
New Revision: 106791
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106791
Log:
PR 24644
* common.opt (Wvolatile-register-var): New.
* varasm.c (make_decl_rtl): Only emit warning when option
specified. Clarify warning message.
* doc/invoke.texi (Wvolatile-register-var): Document new option.
* doc/md.texi (copysign): Document standard named pattern.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/common.opt
trunk/gcc/doc/invoke.texi
trunk/gcc/doc/md.texi
trunk/gcc/varasm.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24644
^ permalink raw reply [flat|nested] 28+ messages in thread