[Bug fortran/24409] New: ICE on module name vs dummy argument name

[Bug fortran/24409] New: ICE on module name vs dummy argument name

[sfilippone at uniroma2 dot it]

If a dummy argument name is the same as the name of the module containing the
interface an ICE (or other errors, according to the test case) results.


-- 
           Summary: ICE on module name vs dummy argument name
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: sfilippone at uniroma2 dot it
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[sfilippone at uniroma2 dot it]

------- Comment #1 from sfilippone at uniroma2 dot it  2005-10-17 15:47 -------
Created an attachment (id=10007)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10007&action=view)
test case

[sfilippo@localhost sfilippo]$ gfortran -v -c micro_test.f90 
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../gcc-4.1-20051015/configure --prefix=/usr/local/gfortran
Thread model: posix
gcc version 4.1.0 20051015 (experimental)
 /home/local/gfortran/bin/../libexec/gcc/i686-pc-linux-gnu/4.1.0/f951
micro_test.f90 -quiet -dumpbase micro_test.f90 -mtune=pentiumpro -auxbase
micro_test -version -o /tmp/ccz55LK0.s
GNU F95 version 4.1.0 20051015 (experimental) (i686-pc-linux-gnu)
        compiled by GNU C version 4.1.0 20051015 (experimental).
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
micro_test.f90: In function 'MAIN__':
micro_test.f90:16: internal compiler error: in gfc_get_symbol_decl, at
fortran/trans-decl.c:732
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-10-17 16:42 -------
Confirmed, reduced testcase:
module string
  interface tolower
    function  tolowerc(string )
      character(len=*), intent(in)  :: string
      character(len=len(string ))    :: tolowerc
    end function tolowerc
  end interface
end module string
module serial
  use string
end module serial
  use serial
  print *, tolower ("Have a Nice DAY")
end


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2005-10-17 16:42:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2005-10-17 20:58 -------
Thank you Salvatore and Andrew.

The proposed patch is about to be posted on the fortran and gcc-patches list. 
I just have a couple more minutes of testing other, completely off-the-wall
cases before submitting.

Paul T


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[tobi at gcc dot gnu dot org]

------- Comment #4 from tobi at gcc dot gnu dot org  2005-11-07 13:07 -------
(In reply to comment #3)
> Thank you Salvatore and Andrew.
> 
> The proposed patch is about to be posted on the fortran and gcc-patches list. 
> I just have a couple more minutes of testing other, completely off-the-wall
> cases before submitting.

Did this patch ever get posted?


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org,
                   |                            |pault at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2005-11-07 20:14 -------
> Did this patch ever get posted?

Tobi, that's a coincidence; I just found it whilst working on dot_product!

I'll submit in the next 24 hours.  I've found another patch that I just forgot
about too....


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[paulthomas2 at wanadoo dot fr]

------- Comment #6 from paulthomas2 at wanadoo dot fr  2005-11-08 18:56 -------
Subject: Re:  ICE on module name vs dummy argument name

tobi,

>------- Comment #4 from tobi at gcc dot gnu dot org  2005-11-07 13:07 -------
>(In reply to comment #3)
>  
>
>>Thank you Salvatore and Andrew.
>>
>>The proposed patch is about to be posted on the fortran and gcc-patches list. 
>>I just have a couple more minutes of testing other, completely off-the-wall
>>cases before submitting.
>>    
>>
>
>Did this patch ever get posted?
>  
>
What about it?

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2005-11-10 22:24 -------
Subject: Bug 24409

Author: pault
Date: Thu Nov 10 22:24:28 2005
New Revision: 106756

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106756
Log:
2005-11-10  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24655
        PR fortran/24755
        * match.c (recursive_stmt_fcn): Add checks that symtree exists
        for the expression to weed out inline intrinsic functions and
        parameters.

        PR fortran/24409
        * module.c (mio_symtree_ref): Correct the patch of 0923 so that
        a symbol is not substituted for by a the symbol for the module
        itself and to prevent the promotion of a formal argument.

2005-11-10  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24655
        PR fortran/24755
        * gfortran.dg/recursive_statement_functions.f90: Add statement 
        functions using inline intrinsic functions and parameters to test
        that they no longer seg-fault.

        PR fortran/24409
        gfortran.dg/nested_modules_4.f90: New test.
        gfortran.dg/nested_modules_5.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/nested_modules_4.f90
    trunk/gcc/testsuite/gfortran.dg/nested_modules_5.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/recursive_statement_functions.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pault at gcc dot gnu dot org]

------- Comment #8 from pault at gcc dot gnu dot org  2005-11-11 05:37 -------
Subject: Bug 24409

Author: pault
Date: Fri Nov 11 05:37:40 2005
New Revision: 106779

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106779
Log:
2005-11-11  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24655
        PR fortran/24755
        * match.c (recursive_stmt_fcn): Add checks that symtree exists
        for the expression to weed out inline intrinsic functions and
        parameters.

        PR fortran/24409
        PR fortran/16861
        * module.c (mio_component_ref): Return if the symbol is NULL
        and wait for another iteration during module reads.
        (mio_symtree_ref): Suppress the writing of contained symbols,
        when a symbol is available in the main namespace. Take care that
        a symbol is not substituted for by a the symbol for the module
        itself and prevent the promotion of a formal argument.
        (read_module): Give symbols for variables from contained module
        procedures different true_name entries to those from the module
        proper.


2005-11-11  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24655
        PR fortran/24755
        * gfortran.dg/recursive_statement_functions.f90: Add statement 
        functions using inline intrinsic functions and parameters to test
        that they no longer seg-fault.

        PR fortran/24409
        * gfortran.dg/nested_modules_4.f90: New test.
        * gfortran.dg/nested_modules_5.f90: New test.

        PR fortran/16861
        * gfortran.dg/nested_modules_3.f90: New test.
        * gfortran.dg/nested_modules_2.f90: New test.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/nested_modules_2.f90
    branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/nested_modules_3.f90
    branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/nested_modules_4.f90
    branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/nested_modules_5.f90
Modified:
    branches/gcc-4_0-branch/gcc/fortran/ChangeLog
    branches/gcc-4_0-branch/gcc/fortran/match.c
    branches/gcc-4_0-branch/gcc/fortran/module.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/nested_modules_1.f90
   
branches/gcc-4_0-branch/gcc/testsuite/gfortran.dg/recursive_statement_functions.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pault at gcc dot gnu dot org]

------- Comment #9 from pault at gcc dot gnu dot org  2005-11-11 05:40 -------
Fixed on mainline and 4.0


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409

[Bug fortran/24409] ICE on module name vs dummy argument name

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|                            |.
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24409