[Bug middle-end/24989] New: boolvar != 1 is not converted to !boolvar

[Bug middle-end/24989] New: boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

The following two function should be the same:
_Bool f(_Bool a)
{
  return a!=1;
}
_Bool f1(_Bool a)
{
  _Bool b = !a;
  return b;
}

Right now f1 is the most optimal.


-- 
           Summary: boolvar != 1 is not converted to !boolvar
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
OtherBugsDependingO 18908,19987
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-11-22 19:41 -------
I am working on a patch to fix this.  This should also fix f3 in PR 18908.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-22 19:41:49
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-11-23 04:04 -------
This actually has a xfail testcase associated with it (I think I forgot to file
the bug when I added the testcase).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |xfail


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2005-11-24 06:14 -------
XPASS: gcc.dg/tree-ssa/bool-7.c scan-tree-dump-times != 1 0


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-11-24 21:19 -------
Patch posted:
http://gcc.gnu.org/ml/gcc-patches/2005-11/msg01780.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |11/msg01780.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-11-25 05:05 -------
Subject: Bug 24989

Author: pinskia
Date: Fri Nov 25 05:05:26 2005
New Revision: 107488

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107488
Log:
2005-11-25  Andrew Pinski  <pinskia@physics.uc.edu>

        PR middle-end/24989
        * fold-const.c (fold_build): Convert bool_var != 1 and
        bool_var == 0 to !bool_var.

2005-11-24  Andrew Pinski  <pinskia@physics.uc.edu>

        PR middle-end/24989
        * gcc.dg/tree-ssa/bool-10.c: New test.
        * gcc.dg/tree-ssa/bool-11.c: New test.
        * gcc.dg/tree-ssa/bool-7.c: Un-xfail.


Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/bool-10.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/bool-11.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fold-const.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/bool-7.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989

[Bug middle-end/24989] boolvar != 1 is not converted to !boolvar

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2005-11-25 05:05 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24989