* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
@ 2005-10-23 19:58 ` pinskia at gcc dot gnu dot org
2005-11-26 9:22 ` gdr at gcc dot gnu dot org
` (13 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-23 19:58 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
2005-10-23 19:58 ` [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements pinskia at gcc dot gnu dot org
@ 2005-11-26 9:22 ` gdr at gcc dot gnu dot org
2006-03-11 3:17 ` mmitchel at gcc dot gnu dot org
` (12 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: gdr at gcc dot gnu dot org @ 2005-11-26 9:22 UTC (permalink / raw)
To: gcc-bugs
--
gdr at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |gdr at gcc dot gnu dot org
|dot org |
Status|NEW |ASSIGNED
Last reconfirmed|2005-07-01 22:13:53 |2005-11-26 09:22:12
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
2005-10-23 19:58 ` [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements pinskia at gcc dot gnu dot org
2005-11-26 9:22 ` gdr at gcc dot gnu dot org
@ 2006-03-11 3:17 ` mmitchel at gcc dot gnu dot org
2006-08-15 18:32 ` pinskia at gcc dot gnu dot org
` (11 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2006-03-11 3:17 UTC (permalink / raw)
To: gcc-bugs
--
mmitchel at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.3 |4.0.4
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2006-03-11 3:17 ` mmitchel at gcc dot gnu dot org
@ 2006-08-15 18:32 ` pinskia at gcc dot gnu dot org
2006-11-21 17:56 ` pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-15 18:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pinskia at gcc dot gnu dot org 2006-08-15 18:31 -------
Any news on this one?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2006-08-15 18:32 ` pinskia at gcc dot gnu dot org
@ 2006-11-21 17:56 ` pinskia at gcc dot gnu dot org
2006-11-26 1:44 ` [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-21 17:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from pinskia at gcc dot gnu dot org 2006-11-21 17:55 -------
*** Bug 29933 has been marked as a duplicate of this bug. ***
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tsarkov at cs dot man dot ac
| |dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2006-11-21 17:56 ` pinskia at gcc dot gnu dot org
@ 2006-11-26 1:44 ` pinskia at gcc dot gnu dot org
2006-11-26 18:25 ` pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-26 1:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from pinskia at gcc dot gnu dot org 2006-11-26 01:44 -------
I am going to test RTH's patch and fix all the fall outs.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|gdr at gcc dot gnu dot org |pinskia at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2006-11-26 1:44 ` [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized pinskia at gcc dot gnu dot org
@ 2006-11-26 18:25 ` pinskia at gcc dot gnu dot org
2006-11-27 5:47 ` pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-26 18:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from pinskia at gcc dot gnu dot org 2006-11-26 18:25 -------
The problem with RTH's patch was the use of t which shadowed the variable in
the function which is used for setting the locus. I am testing the corrected
patch now.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2006-11-26 18:25 ` pinskia at gcc dot gnu dot org
@ 2006-11-27 5:47 ` pinskia at gcc dot gnu dot org
2006-11-27 5:50 ` Andrew Pinski
2006-11-27 5:51 ` pinskia at gmail dot com
` (6 subsequent siblings)
14 siblings, 1 reply; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-27 5:47 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from pinskia at gcc dot gnu dot org 2006-11-27 05:46 -------
(In reply to comment #14)
> The problem with RTH's patch was the use of t which shadowed the variable in
> the function which is used for setting the locus. I am testing the corrected
> patch now.
That fixed most of the failures but there are still some ICEs that need to be
fixed.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2006-11-27 5:47 ` pinskia at gcc dot gnu dot org
@ 2006-11-27 5:51 ` pinskia at gmail dot com
2006-11-27 6:41 ` pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gmail dot com @ 2006-11-27 5:51 UTC (permalink / raw)
To: gcc-bugs
------- Comment #16 from pinskia at gmail dot com 2006-11-27 05:51 -------
Subject: Re: [tree-ssa] badly formatted warnings for SRA
replacements used uninitialized
On Mon, 2006-11-27 at 05:46 +0000, pinskia at gcc dot gnu dot org wrote:
> That fixed most of the failures but there are still some ICEs that need to be
> fixed.
I have a fix for those ICEs, it is just checking for DECL_P.
-- Pinski
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2006-11-27 5:51 ` pinskia at gmail dot com
@ 2006-11-27 6:41 ` pinskia at gcc dot gnu dot org
2006-12-04 2:25 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-27 6:41 UTC (permalink / raw)
To: gcc-bugs
------- Comment #17 from pinskia at gcc dot gnu dot org 2006-11-27 06:41 -------
Here is the patch which passes the C++ testsuite, I have to do a full
bootstrap/testsuite run still but I am happy with it currrently which is why I
am pasting it here:
Index: error.c
===================================================================
--- error.c (revision 119217)
+++ error.c (working copy)
@@ -2337,7 +2337,22 @@ cp_printer (pretty_printer *pp, text_inf
{
case 'A': result = args_to_string (next_tree, verbose); break;
case 'C': result = code_to_string (next_tcode); break;
- case 'D': result = decl_to_string (next_tree, verbose); break;
+ case 'D':
+ {
+ tree temp = next_tree;
+ if (DECL_P (temp)
+ && DECL_DEBUG_EXPR_IS_FROM (temp) && DECL_DEBUG_EXPR (temp))
+ {
+ temp = DECL_DEBUG_EXPR (temp);
+ if (!DECL_P (temp))
+ {
+ result = expr_to_string (temp);
+ break;
+ }
+ }
+ result = decl_to_string (temp, verbose);
+ }
+ break;
case 'E': result = expr_to_string (next_tree); break;
case 'F': result = fndecl_to_string (next_tree, verbose); break;
case 'L': result = language_to_string (next_lang); break;
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2006-11-27 6:41 ` pinskia at gcc dot gnu dot org
@ 2006-12-04 2:25 ` pinskia at gcc dot gnu dot org
2006-12-04 2:26 ` [Bug c++/14329] [4.1/4.2 only] " pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-12-04 2:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #18 from pinskia at gcc dot gnu dot org 2006-12-04 02:24 -------
Subject: Bug 14329
Author: pinskia
Date: Mon Dec 4 02:24:42 2006
New Revision: 119478
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119478
Log:
2006-12-03 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* error.c (cp_printer) <'D'>: Handle DECL_DEBUG_EXPR.
2006-12-03 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* g++.dg/warn/unit-1.C: New test.
Added:
trunk/gcc/testsuite/g++.dg/warn/unit-1.C
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/error.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [4.1/4.2 only] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2006-12-04 2:25 ` pinskia at gcc dot gnu dot org
@ 2006-12-04 2:26 ` pinskia at gcc dot gnu dot org
2006-12-04 18:32 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-12-04 2:26 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |4.1.1
Known to work| |4.3.0
Summary|[tree-ssa] badly formatted |[4.1/4.2 only] badly
|warnings for SRA |formatted warnings for SRA
|replacements used |replacements used
|uninitialized |uninitialized
Target Milestone|4.0.4 |4.1.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [4.1/4.2 only] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2006-12-04 2:26 ` [Bug c++/14329] [4.1/4.2 only] " pinskia at gcc dot gnu dot org
@ 2006-12-04 18:32 ` pinskia at gcc dot gnu dot org
2006-12-05 18:05 ` [Bug c++/14329] [4.1 " pinskia at gcc dot gnu dot org
2006-12-05 18:05 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-12-04 18:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #19 from pinskia at gcc dot gnu dot org 2006-12-04 18:32 -------
Subject: Bug 14329
Author: pinskia
Date: Mon Dec 4 18:31:40 2006
New Revision: 119501
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119501
Log:
2006-12-04 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* error.c (cp_printer) <'D'>: Handle DECL_DEBUG_EXPR.
2006-12-04 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* g++.dg/warn/unit-1.C: New test.
Added:
branches/gcc-4_2-branch/gcc/testsuite/g++.dg/warn/unit-1.C
- copied unchanged from r119478, trunk/gcc/testsuite/g++.dg/warn/unit-1.C
Modified:
branches/gcc-4_2-branch/gcc/cp/ChangeLog
branches/gcc-4_2-branch/gcc/cp/error.c
branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [4.1 only] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2006-12-04 18:32 ` pinskia at gcc dot gnu dot org
@ 2006-12-05 18:05 ` pinskia at gcc dot gnu dot org
2006-12-05 18:05 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-12-05 18:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #20 from pinskia at gcc dot gnu dot org 2006-12-05 18:05 -------
Fixed.
------- Comment #21 from pinskia at gcc dot gnu dot org 2006-12-05 18:05 -------
Subject: Bug 14329
Author: pinskia
Date: Tue Dec 5 18:04:44 2006
New Revision: 119548
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119548
Log:
2006-12-05 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* error.c (cp_printer) <'D'>: Handle DECL_DEBUG_EXPR.
2006-12-05 Richard Henderson <rth@redhat.com>
Andrew Pinski <pinskia@gmail.com>
PR C++/14329
* g++.dg/warn/unit-1.C: New test.
Added:
branches/gcc-4_1-branch/gcc/testsuite/g++.dg/warn/unit-1.C
- copied unchanged from r119478, trunk/gcc/testsuite/g++.dg/warn/unit-1.C
Modified:
branches/gcc-4_1-branch/gcc/cp/ChangeLog
branches/gcc-4_1-branch/gcc/cp/error.c
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug c++/14329] [4.1 only] badly formatted warnings for SRA replacements used uninitialized
[not found] <bug-14329-2744@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2006-12-05 18:05 ` [Bug c++/14329] [4.1 " pinskia at gcc dot gnu dot org
@ 2006-12-05 18:05 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 23+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-12-05 18:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #20 from pinskia at gcc dot gnu dot org 2006-12-05 18:05 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329
^ permalink raw reply [flat|nested] 23+ messages in thread