public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/25106] New: better diagnostic needed
@ 2005-11-26 18:10 jv244 at cam dot ac dot uk
2005-11-27 5:49 ` [Bug fortran/25106] statement label is zero kargl at gcc dot gnu dot org
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: jv244 at cam dot ac dot uk @ 2005-11-26 18:10 UTC (permalink / raw)
To: gcc-bugs
using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease) with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:
0 CONTINUE
END
--
Summary: better diagnostic needed
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jv244 at cam dot ac dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
@ 2005-11-27 5:49 ` kargl at gcc dot gnu dot org
2005-11-28 5:08 ` pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-11-27 5:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from kargl at gcc dot gnu dot org 2005-11-27 05:49 -------
I have a tentative patch for this.
--
kargl at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |kargl at gcc dot gnu dot org
|dot org |
Summary|better diagnostic needed |statement label is zero
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 5:49 ` [Bug fortran/25106] statement label is zero kargl at gcc dot gnu dot org
@ 2005-11-28 5:08 ` pinskia at gcc dot gnu dot org
2005-12-03 15:32 ` fxcoudert at gcc dot gnu dot org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-28 5:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2005-11-28 05:08 -------
Confirmed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2005-11-28 05:08:48
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 5:49 ` [Bug fortran/25106] statement label is zero kargl at gcc dot gnu dot org
2005-11-28 5:08 ` pinskia at gcc dot gnu dot org
@ 2005-12-03 15:32 ` fxcoudert at gcc dot gnu dot org
2005-12-03 15:33 ` [Bug fortran/25106] [4.0/4.1] " fxcoudert at gcc dot gnu dot org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-12-03 15:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from fxcoudert at gcc dot gnu dot org 2005-12-03 15:32 -------
Subject: Bug 25106
Author: fxcoudert
Date: Sat Dec 3 15:32:04 2005
New Revision: 107999
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107999
Log:
PR fortran/25106
* parse.c (next_free): Use new prototype for gfc_match_st_label.
Correctly emit hard error if a label is zero.
* match.c (gfc_match_st_label): Never allow zero as a valid
label.
(gfc_match, gfc_match_do, gfc_match_goto): Use new prototype for
gfc_match_st_label.
* primary.c (): Use new prototype for gfc_match_st_label.
* io.c (): Likewise.
* match.h: Likewise.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/io.c
trunk/gcc/fortran/match.c
trunk/gcc/fortran/match.h
trunk/gcc/fortran/parse.c
trunk/gcc/fortran/primary.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (2 preceding siblings ...)
2005-12-03 15:32 ` fxcoudert at gcc dot gnu dot org
@ 2005-12-03 15:33 ` fxcoudert at gcc dot gnu dot org
2005-12-11 16:47 ` kargl at gcc dot gnu dot org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-12-03 15:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from fxcoudert at gcc dot gnu dot org 2005-12-03 15:33 -------
Patch commited to mainline, waiting some time before commiting to 4.1.
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fxcoudert at gcc dot gnu dot
| |org
Keywords| |patch
Known to work| |4.2.0
Summary|statement label is zero |[4.0/4.1] statement label is
| |zero
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (3 preceding siblings ...)
2005-12-03 15:33 ` [Bug fortran/25106] [4.0/4.1] " fxcoudert at gcc dot gnu dot org
@ 2005-12-11 16:47 ` kargl at gcc dot gnu dot org
2005-12-16 23:32 ` kargl at gcc dot gnu dot org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-12-11 16:47 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from kargl at gcc dot gnu dot org 2005-12-11 16:47 -------
http://gcc.gnu.org/ml/fortran/2005-12/msg00215.html
This patch changes the handling of labels to catch
problems with too many digits from laeding zeros.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (4 preceding siblings ...)
2005-12-11 16:47 ` kargl at gcc dot gnu dot org
@ 2005-12-16 23:32 ` kargl at gcc dot gnu dot org
2005-12-30 19:32 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-12-16 23:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from kargl at gcc dot gnu dot org 2005-12-16 23:32 -------
Subject: Bug 25106
Author: kargl
Date: Fri Dec 16 23:32:29 2005
New Revision: 108692
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108692
Log:
2005-12-10 Steven G. Kargl <kargls@comcast.net>
PR fortran/25106
PR fortran/25055
* match.c (gfc_match_small_literal_int): Add cnt argument;
(gfc_match_st_label,gfc_match_stopcode): Account for cnt argument.
* match.h (gfc_match_small_literal_int): Update prototype.
* decl.c (match_char_length,gfc_match_old_kind_spec): Account for cnt.
* parse.c (next_free): Ditto.
* primary.c (match_kind_param): Ditto.
gfortran.dg/label_1.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/label_1.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/match.c
trunk/gcc/fortran/match.h
trunk/gcc/fortran/parse.c
trunk/gcc/fortran/primary.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (5 preceding siblings ...)
2005-12-16 23:32 ` kargl at gcc dot gnu dot org
@ 2005-12-30 19:32 ` pinskia at gcc dot gnu dot org
2005-12-31 18:55 ` kargl at gcc dot gnu dot org
2005-12-31 19:05 ` kargl at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-12-30 19:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2005-12-30 19:32 -------
*** Bug 20855 has been marked as a duplicate of this bug. ***
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (6 preceding siblings ...)
2005-12-30 19:32 ` pinskia at gcc dot gnu dot org
@ 2005-12-31 18:55 ` kargl at gcc dot gnu dot org
2005-12-31 19:05 ` kargl at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-12-31 18:55 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from kargl at gcc dot gnu dot org 2005-12-31 18:55 -------
Subject: Bug 25106
Author: kargl
Date: Sat Dec 31 18:55:30 2005
New Revision: 109199
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109199
Log:
2005-12-31 Steven G. Kargl <kargls@comcast.net>
PR fortran/25106
PR fortran/25055
* io.c (match_dt_format): Remove second arg in gfc_match_st_label.
* match.c (gfc_match_small_literal_int): Add cnt argument;
(gfc_match_st_label,gfc_match_stopcode): Account for cnt argument.
(gfc_match_st_label): Remove allow_zero (second argument), and use
cnt for errors.
(gfc_match_do,gfc_match_goto): Remove second arg in gfc_match_st_label
* match.h (gfc_match_small_literal_int,gfc_match_st_label):
Update prototypes.
* decl.c (match_char_length,gfc_match_old_kind_spec): Account for cnt.
* parse.c (next_free): Account for cnt; Remove second arg in
gfc_match_st_label
* primary.c (match_kind_param): Ditto.
PR fortran/25106
PR fortran/25055
* gfortran.dg/label_1.f90: New test.
Added:
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/label_1.f90
Modified:
branches/gcc-4_1-branch/gcc/fortran/ChangeLog
branches/gcc-4_1-branch/gcc/fortran/decl.c
branches/gcc-4_1-branch/gcc/fortran/io.c
branches/gcc-4_1-branch/gcc/fortran/match.c
branches/gcc-4_1-branch/gcc/fortran/match.h
branches/gcc-4_1-branch/gcc/fortran/parse.c
branches/gcc-4_1-branch/gcc/fortran/primary.c
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25106] [4.0/4.1] statement label is zero
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
` (7 preceding siblings ...)
2005-12-31 18:55 ` kargl at gcc dot gnu dot org
@ 2005-12-31 19:05 ` kargl at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-12-31 19:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from kargl at gcc dot gnu dot org 2005-12-31 19:05 -------
Fixed in 4.1 and trunk. This will not be fixed (by me)
in 4.0.
--
kargl at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25106
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2005-12-31 19:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-26 18:10 [Bug fortran/25106] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 5:49 ` [Bug fortran/25106] statement label is zero kargl at gcc dot gnu dot org
2005-11-28 5:08 ` pinskia at gcc dot gnu dot org
2005-12-03 15:32 ` fxcoudert at gcc dot gnu dot org
2005-12-03 15:33 ` [Bug fortran/25106] [4.0/4.1] " fxcoudert at gcc dot gnu dot org
2005-12-11 16:47 ` kargl at gcc dot gnu dot org
2005-12-16 23:32 ` kargl at gcc dot gnu dot org
2005-12-30 19:32 ` pinskia at gcc dot gnu dot org
2005-12-31 18:55 ` kargl at gcc dot gnu dot org
2005-12-31 19:05 ` kargl at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).