[Bug libfortran/25116] New: [regression wrt g77] A namelist read from an unnamed file should read from fort.n

[Bug libfortran/25116] New: [regression wrt g77] A namelist read from an unnamed file should read from fort.n

[toon at moene dot indiv dot nluug dot nl]

Gfortran should read a namelist from a file that has not
been given a name on an open statement from the fort.n
where n is the unit number in the read statement.
(this a defacto standard way to do it on Unix systems).
Hmm, in lynx I do not see the attach file option, so here goes:
      namelist /nlist/ i, a
      read(9,nlist)
      write(6,nlist)
      end
with the following contents of fort.9:
 &nlist i=1, a=3.5 /
should print the namelist to stdout, not give "end of file".
It works if you add "open(9,file='fort.9')" before the read.
Blocks: HIRLAM.


-- 
           Summary: [regression wrt g77] A namelist read from an unnamed
                    file should read from fort.n
           Product: gcc
           Version: 4.0.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: toon at moene dot indiv dot nluug dot nl


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] [regression wrt g77] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #1 from fxcoudert at gcc dot gnu dot org  2005-11-27 11:38 -------
Confirmed on mainline. Interesting, because the Access time of the fort.9 file
is indeed modified, and the error message is:

At line 2 of file nml.f
Fortran runtime error: End of file


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
OtherBugsDependingO|                            |19292
              nThis|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-27 11:38:52
               date|                            |
            Summary|[regression wrt g77] A      |[regression wrt g77]
                   |namelist read from an       |namelist read from non-
                   |unnamed file should read    |opened file
                   |from fort.n                 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] [regression wrt g77] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #2 from fxcoudert at gcc dot gnu dot org  2005-11-27 23:14 -------
(In reply to comment #1)
> At line 2 of file nml.f
> Fortran runtime error: End of file

Debugging shows that the bytes_left field of the stream is not set correctly
(2338621003140048416 instead of 9223372036854775807). It is set in transfer.c,
line 1143.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2005-11-27 11:38:52         |2005-11-27 23:14:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

Re: [Bug libfortran/25116] [regression wrt g77] namelist read from non-opened file

[Jerry DeLisle]

fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #2 from fxcoudert at gcc dot gnu dot org  2005-11-27 23:14 -------
> (In reply to comment #1)
> 
>>At line 2 of file nml.f
>>Fortran runtime error: End of file
> 
> 
> Debugging shows that the bytes_left field of the stream is not set correctly
> (2338621003140048416 instead of 9223372036854775807). It is set in transfer.c,
> line 1143.
> 
> 
If you mean this:


   memcpy (&i, p, sizeof (gfc_offset));
   dtp->u.p.current_unit->bytes_left = i;

Maybe it should be a -=

Jerry

[Bug libfortran/25116] [regression wrt g77] namelist read from non-opened file

[jvdelisle at verizon dot net]

------- Comment #3 from jvdelisle at verizon dot net  2005-11-28 01:40 -------
Subject: Re:  [regression wrt g77] namelist read from
 non-opened file

fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #2 from fxcoudert at gcc dot gnu dot org  2005-11-27 23:14 -------
> (In reply to comment #1)
> 
>>At line 2 of file nml.f
>>Fortran runtime error: End of file
> 
> 
> Debugging shows that the bytes_left field of the stream is not set correctly
> (2338621003140048416 instead of 9223372036854775807). It is set in transfer.c,
> line 1143.
> 
> 
If you mean this:


   memcpy (&i, p, sizeof (gfc_offset));
   dtp->u.p.current_unit->bytes_left = i;

Maybe it should be a -=

Jerry


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2005-11-28 07:08 -------
No, it's in fact easier than that. We shouldn't come into us_read for this
file, which is formatted! Probably a bad default flag is set.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2005-11-27 23:14:43         |2005-11-28 07:08:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[jvdelisle at verizon dot net]

------- Comment #5 from jvdelisle at verizon dot net  2005-11-28 08:09 -------
Subject: Re:  namelist read from non-opened file

fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #4 from fxcoudert at gcc dot gnu dot org  2005-11-28 07:08 -------
> No, it's in fact easier than that. We shouldn't come into us_read for this
> file, which is formatted! Probably a bad default flag is set.
> 
> 
I think you are right.  I have been putting in debug statements all over and 
find that we are asking the wrong length of reads, 8 characters, instead of 1
in 
the failing case.  I will get back to this in a day or so.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

Re: [Bug libfortran/25116] namelist read from non-opened file

[Jerry DeLisle]

fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #4 from fxcoudert at gcc dot gnu dot org  2005-11-28 07:08 -------
> No, it's in fact easier than that. We shouldn't come into us_read for this
> file, which is formatted! Probably a bad default flag is set.
> 
> 
I think you are right.  I have been putting in debug statements all over and 
find that we are asking the wrong length of reads, 8 characters, instead of 1 in 
the failing case.  I will get back to this in a day or so.

[Bug libfortran/25116] namelist read from non-opened file

[toon at moene dot indiv dot nluug dot nl]

------- Comment #6 from toon at moene dot indiv dot nluug dot nl  2005-11-28 15:36 -------
> I think you are right.  I have been putting in debug statements all over and 
> find that we are asking the wrong length of reads, 8 characters, instead of 1
> in the failing case.  I will get back to this in a day or so.

Isn't this a sign that we are treating the read as UNFORMATTED ?  Which would
be wrong as namelist reads are always FORMATTED (note: the file isn't opened,
so that cannot discern between FORMATTED and UNFORMATTED.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #7 from fxcoudert at gcc dot gnu dot org  2005-11-28 15:59 -------
I think the following patch (no time yet to regtest it, and won't have time
soon, please feel free to test it) fixes it:

Index: transfer.c
===================================================================
--- transfer.c  (revision 107563)
+++ transfer.c  (working copy)
@@ -1239,11 +1239,14 @@
      memset (&u_flags, '\0', sizeof (u_flags));
      u_flags.access = ACCESS_SEQUENTIAL;
      u_flags.action = ACTION_READWRITE;
+
      /* Is it unformatted?  */
-     if (!(cf & (IOPARM_DT_HAS_FORMAT | IOPARM_DT_LIST_FORMAT)))
+     if (!(cf & (IOPARM_DT_HAS_FORMAT | IOPARM_DT_LIST_FORMAT
+                | IOPARM_DT_IONML_SET)))
        u_flags.form = FORM_UNFORMATTED;
      else
        u_flags.form = FORM_UNSPECIFIED;
+
      u_flags.delim = DELIM_UNSPECIFIED;
      u_flags.blank = BLANK_UNSPECIFIED;
      u_flags.pad = PAD_UNSPECIFIED;


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[jvdelisle at verizon dot net]

------- Comment #8 from jvdelisle at verizon dot net  2005-11-28 21:07 -------
Subject: Re:  namelist read from non-opened file

fxcoudert at gcc dot gnu dot org wrote:
> +
>       /* Is it unformatted?  */
> -     if (!(cf & (IOPARM_DT_HAS_FORMAT | IOPARM_DT_LIST_FORMAT)))
> +     if (!(cf & (IOPARM_DT_HAS_FORMAT | IOPARM_DT_LIST_FORMAT
> +                | IOPARM_DT_IONML_SET)))

Yes, I think this is the exact spot I was looking at last night.  I was just 
going to go find the right namelist define to use.  I assume you tested this
and 
it works, of course.
  :)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[toon at moene dot indiv dot nluug dot nl]

------- Comment #9 from toon at moene dot indiv dot nluug dot nl  2005-11-29 19:20 -------
FX,

Your patch solved the problem for me.
AFAICS, this patch is indeed the correct fix for this problem.
Please apply it to (at least) 4.1 and trunk.
It might be appropriate for the 4.0 branch, too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #10 from fxcoudert at gcc dot gnu dot org  2005-12-02 16:46 -------
Subject: Bug 25116

Author: fxcoudert
Date: Fri Dec  2 16:46:49 2005
New Revision: 107900

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107900
Log:
        PR libfortran/25116
        * io/transfer.c (data_transfer_init): Don't set the default for
        namelist I/O on preconnected files to UNFORMATTED.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] [4.0/4.1] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #11 from fxcoudert at gcc dot gnu dot org  2005-12-02 18:08 -------
Commited to mainline, waiting a bit before committing to 4.1.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-11-28 07:08:02         |2005-12-02 18:08:49
               date|                            |
            Summary|namelist read from non-     |[4.0/4.1] namelist read from
                   |opened file                 |non-opened file
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] [4.0/4.1] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #12 from fxcoudert at gcc dot gnu dot org  2005-12-09 18:50 -------
Subject: Bug 25116

Author: fxcoudert
Date: Fri Dec  9 18:50:48 2005
New Revision: 108314

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108314
Log:
        PR libfortran/25116
        * io/transfer.c (data_transfer_init): Don't set the default for
        namelist I/O on preconnected files to UNFORMATTED.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116

[Bug libfortran/25116] [4.0] namelist read from non-opened file

[fxcoudert at gcc dot gnu dot org]

------- Comment #13 from fxcoudert at gcc dot gnu dot org  2005-12-09 18:52 -------
Committed to 4.1


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.0.3
      Known to work|                            |4.2.0 4.1.0
         Resolution|                            |FIXED
            Summary|[4.0/4.1] namelist read from|[4.0] namelist read from
                   |non-opened file             |non-opened file


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25116