public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/20839] do-loop with do-construct-name needs needs end do
       [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
@ 2005-11-11 17:58 ` steven at gcc dot gnu dot org
  2005-11-13 12:24 ` steven at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-11-11 17:58 UTC (permalink / raw)
  To: gcc-bugs



-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |steven at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-09-18 06:02:13         |2005-11-11 17:58:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20839


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug fortran/20839] do-loop with do-construct-name needs needs end do
       [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
  2005-11-11 17:58 ` [Bug fortran/20839] do-loop with do-construct-name needs needs end do steven at gcc dot gnu dot org
@ 2005-11-13 12:24 ` steven at gcc dot gnu dot org
  2005-11-13 13:56 ` steven at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-11-13 12:24 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from steven at gcc dot gnu dot org  2005-11-13 12:24 -------
*** Bug 24806 has been marked as a duplicate of this bug. ***


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uttamp at us dot ibm dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20839


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug fortran/20839] do-loop with do-construct-name needs needs end do
       [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
  2005-11-11 17:58 ` [Bug fortran/20839] do-loop with do-construct-name needs needs end do steven at gcc dot gnu dot org
  2005-11-13 12:24 ` steven at gcc dot gnu dot org
@ 2005-11-13 13:56 ` steven at gcc dot gnu dot org
  2005-12-09 21:40 ` uttamp at us dot ibm dot com
  2006-06-05 10:27 ` pault at gcc dot gnu dot org
  4 siblings, 0 replies; 5+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-11-13 13:56 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from steven at gcc dot gnu dot org  2005-11-13 13:56 -------
Created an attachment (id=10230)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10230&action=view)
patch

I can't think of better wording for the diagnostic.  Some help there would be
appreciated.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20839


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug fortran/20839] do-loop with do-construct-name needs needs end do
       [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2005-11-13 13:56 ` steven at gcc dot gnu dot org
@ 2005-12-09 21:40 ` uttamp at us dot ibm dot com
  2006-06-05 10:27 ` pault at gcc dot gnu dot org
  4 siblings, 0 replies; 5+ messages in thread
From: uttamp at us dot ibm dot com @ 2005-12-09 21:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from uttamp at us dot ibm dot com  2005-12-09 21:40 -------
I did build and completed the regression test. The patch in comment #3 fixes
this problem (when compiled with -pedantic option) but gfortran still fails to
report this as an error with -std=f95 without -pedantic.

I've created a new patch where I took the Steven's patch and added GFC_STD_F95
along with pedantic check.

About the error message, how about,
"Construct name on END DO at %L does not match the Named DO construct", sounds?

Below, I'm listing the patch for completeness. Can somebody look at it pease?

Thansks,
Uttam

--- gcc_org/gcc/gcc/fortran/parse.c     2005-11-30 09:56:16.000000000 -0800
+++ gcc/gcc/fortran/parse.c     2005-12-09 13:33:32.000000000 -0800
@@ -23,6 +23,7 @@ Software Foundation, 51 Franklin Street,

 #include "config.h"
 #include "system.h"
+#include "flags.h"
 #include <setjmp.h>
 #include "gfortran.h"
 #include "match.h"
@@ -2057,6 +2058,10 @@ loop:
       break;

     case ST_IMPLIED_ENDDO:
+      if ((pedantic || GFC_STD_F95) && gfc_current_block () != NULL)
+           gfc_error_now
+              ("Construct name on END DO at %L does not match the Named DO
construct",
+                   &gfc_current_block()->declared_at);
       break;

     default:


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20839


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug fortran/20839] do-loop with do-construct-name needs needs end do
       [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2005-12-09 21:40 ` uttamp at us dot ibm dot com
@ 2006-06-05 10:27 ` pault at gcc dot gnu dot org
  4 siblings, 0 replies; 5+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-06-05 10:27 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from pault at gcc dot gnu dot org  2006-06-05 10:25 -------
Fixed on trunk and 4.1

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20839


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-06-05 10:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-20839-6642@http.gcc.gnu.org/bugzilla/>
2005-11-11 17:58 ` [Bug fortran/20839] do-loop with do-construct-name needs needs end do steven at gcc dot gnu dot org
2005-11-13 12:24 ` steven at gcc dot gnu dot org
2005-11-13 13:56 ` steven at gcc dot gnu dot org
2005-12-09 21:40 ` uttamp at us dot ibm dot com
2006-06-05 10:27 ` pault at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).