[Bug middle-end/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[Bug middle-end/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug middle-end/25023] New: [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rguenth at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

We fail to build the linux kernel on i686 with debugging enabled.

drivers/usb/media/w9968cf.c:

/usr/lib/gcc/i586-suse-linux/4.1.0/cc1 -fpreprocessed w9968cf.i -quiet
-dumpbase w9968cf.i -m32 -msoft-float -mpreferred-stack-boundary=2 -march=i586
-mregparm=3 -auxbase-strip drivers/usb/media/.tmp_w9968cf.o -g -O2 -Wall
-Wundef -Wstrict-prototypes -Wno-trigraphs
-Werror-implicit-function-declaration -Wdeclaration-after-statement
-Wno-pointer-sign -version -fno-strict-aliasing -fno-common -ffreestanding
-fomit-frame-pointer -fno-unit-at-a-time -o /tmp/ccaO9lCn.s
drivers/usb/media/w9968cf.c: In function ‘w9968cf_set_picture’:
drivers/usb/media/w9968cf.c:1827: internal compiler error: in def_cfa_1, at
dwarf2out.c:792
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://www.suse.de/feedback> for instructions.

(reducing)


-- 
           Summary: [4.1/4.2 Regression] ICE in def_cfa_1, at
                    dwarf2out.c:792
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: critical
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug middle-end/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2005-11-24 16:56 -------
The candidate which likely broke it is

2005-11-17  Richard Henderson  <rth@redhat.com> 

        * dwarf2out.c (dw_cfi_oprnd_struct): Reduce dw_cfi_reg_num to int.
        (lookup_cfa_1): Apply data alignment to DW_CFA_def_cfa_offset_sf
        and DW_CFA_def_cfa_sf.
        (def_cfa_1): Use DW_CFA_def_cfa_offset_sf with negative values.
        (dbx_reg_number): Don't assert particular registers here.
        (based_loc_descr): ... do it here instead.  Fold in ...
        (eliminate_reg_to_offset): ... this function.
        (compute_frame_pointer_to_cfa_displacement): Fold in the effects
        of eliminate_reg_to_offset; use FRAME_POINTER_CFA_OFFSET.
        * unwind-dw2.c (execute_cfa_program): Apply data align factor
        to DW_CFA_def_cfa_offset_sf and DW_CFA_def_cfa_sf.
        * function.c (instantiate_new_reg): Use FRAME_POINTER_CFA_OFFSET.
        (instantiate_virtual_regs): Likewise.
        * var-tracking.c (adjust_stack_reference): Likewise.
        * doc/tm.texi (FRAME_POINTER_CFA_OFFSET): New.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug middle-end/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2005-11-24 16:58 -------
Created an attachment (id=10334)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10334&action=view)
testcase (unreduced)

testacse


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug middle-end/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2005-11-24 17:04 -------
Created an attachment (id=10335)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10335&action=view)
testcase

reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-11-24 17:11 -------
-O2 -m32 -msoft-float -mpreferred-stack-boundary=2 -march=i586 -mregparm=3
-fno-strict-aliasing -fno-common -ffreestanding -fomit-frame-pointer
-fno-unit-at-a-time -g


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-11-24 20:03 -------
Confirmed, the inline-asm is required (this testcase does not reduce any
further really).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-24 20:03:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2005-11-24 20:42 -------
Here is a reduced testcase as far as I can get it:
struct device_driver {
   const char * name;
};
struct video_picture {
   unsigned  short a,b,c,d,e;
};
struct w9968cf_device {
   struct device_driver *driver;
   int vpp_flag;
};
int debug = 2;
int specific_debug = 0;
int w9968cf_set_picture(struct w9968cf_device* cam, struct video_picture pict)
{
   short fmt, reg_v = 0x0000;
   int err = 0;
   long esi, edi;
   switch (fmt)  {
    case 13:
    reg_v |= 0x0002;
   case 4:
   case 5:
     cam->vpp_flag = 8;
   }
   if (err = w9968cf_write_reg(cam, reg_v, 0x16))
     if (err = w9968cf_sensor_update_picture(cam, pict))
        __asm__ __volatile__("movsw"   
:"=&D"(edi),"=&S"(esi):"0"(edi),"1"(esi):"memory");
  if (((specific_debug) && (debug == (1))) || ((!specific_debug) && (debug >=
(1))))
    printk("<4>" "%s %s: " "Failed to change picture settings" "\n" , 
cam->driver->name );
   return err;
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2005-12-07 14:09 -------
*** Bug 25293 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2005-12-07 18:12 -------
I believe negative CFA offsets that aren't a multiple of 4 aren't representable
in DWARF 3, so either we'd have to lie in the unwind info, or we shouldn't
be misaligning the stack pointer ever.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rth at gcc dot gnu dot org]

------- Comment #9 from rth at gcc dot gnu dot org  2005-12-07 18:21 -------
Indeed we shouldn't be mis-aligning the stack pointer.  And if you look at
the actual assembly, we aren't.  Therefore the problem is bogus debug info.

I had been looking at this PR for a while, but got sidetracked.  I seem to
recall thinking that there was some sort of memory corruption going on.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #10 from jakub at gcc dot gnu dot org  2005-12-07 18:27 -------
The stack is misaligned, though not at any call insn:
        subl    $2, %esp
        movl    40(%esp), %eax
        pushl   %eax
        movl    40(%esp), %eax
        pushl   %eax
        movl    40(%esp), %eax
        pushl   %eax
        movw    42(%esp), %di
        pushw   %di
        call    f2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #11 from jakub at gcc dot gnu dot org  2005-12-08 13:11 -------
Created an attachment (id=10439)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10439&action=view)
gcc41-pr25293.patch

This patch disallows 16-bit pushes (similarly how x86_64 disallows
16-bit and 32-bit pushes).  I don't have an i586 to verify how slow pushw
is, but it would surprise me if it was fast.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rth at gcc dot gnu dot org]

------- Comment #12 from rth at gcc dot gnu dot org  2005-12-08 19:12 -------
This patch is ok.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[rguenth at gcc dot gnu dot org]

------- Comment #13 from rguenth at gcc dot gnu dot org  2005-12-09 12:50 -------
The patch breaks bootstrap on i686 linux:

/usr/src/packages/BUILD/gcc-4.1.0-20051209/obj-i586-suse-linux/./gcc/xgcc
-B/usr/src/packages/BUILD/gcc-4.1.0-20051209/obj-i586-suse-linux/./gcc/
-B/usr/i586-suse-linux/bin/ -B/usr/i586-suse-linux/lib/ -isystem
/usr/i586-suse-linux/include -isystem /usr/i586-suse-linux/sys-include
-DHAVE_CONFIG_H -I. -I../../../libmudflap -I. -Wall -ffunction-sections
-fdata-sections -O2 -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall
-D_FORTIFY_SOURCE=2 -g -U_FORTIFY_SOURCE -MT mf-runtime.lo -MD -MP -MF
.deps/mf-runtime.Tpo -c ../../../libmudflap/mf-runtime.c  -fPIC -DPIC -o
.libs/mf-runtime.o
../../../libmudflap/mf-runtime.c: In function '__mfu_check':
../../../libmudflap/mf-runtime.c:1032: error: unrecognizable insn:
(insn 1384 1383 1385 31 ../../../libmudflap/mf-runtime.c:1457 (set (mem:HI
(pre_dec:SI (reg/f:SI 7 sp)) [0 S2 A8])
        (reg:HI 0 ax [orig:182 __mf_lc_shift ] [182])) -1 (nil)
    (nil))
../../../libmudflap/mf-runtime.c:1032: internal compiler error: in
extract_insn, at recog.c:2084
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://www.suse.de/feedback> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #14 from jakub at gcc dot gnu dot org  2005-12-09 20:13 -------
Created an attachment (id=10446)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10446&action=view)
gcc41-pr25023.patch

A new version of the patch.  While this bootstraps (at least on i386 I tried),
I'm getting some regressions though, particularly:
FAIL: gcc.dg/compat/scalar-by-value-4 c_compat_x_tst.o compile
FAIL: gcc.dg/compat/scalar-by-value-4 c_compat_y_tst.o compile
FAIL: gcc.dg/compat/scalar-return-4 c_compat_x_tst.o compile
FAIL: gcc.dg/compat/scalar-return-4 c_compat_y_tst.o compile
FAIL: gcc.dg/compat/struct-by-value-11 c_compat_x_tst.o compile
FAIL: gcc.dg/compat/struct-by-value-11 c_compat_y_tst.o compile

All seem to be ICEs in emit_move_resolve_push (CQI, [
(mem/i:CQI (pre_modify:SI (reg/f:SI 7 sp)
        (plus:SI (reg/f:SI 7 sp)
            (const_int -4 [0xfffffffc]))) [0 S2 A8])
]), where that function only handles PRE_{INC,DEC} and POST_{INC,DEC}, but
not PRE_MODIFY.  Will see if just handling {PRE,POST}_MODIFY is the right thing
there or if something different is wrong.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #15 from jakub at gcc dot gnu dot org  2005-12-13 08:08 -------
Subject: Bug 25023

Author: jakub
Date: Tue Dec 13 08:08:46 2005
New Revision: 108463

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108463
Log:
        PR debug/25023
        PR target/25293
        * expr.c (emit_move_resolve_push): Handle PRE_MODIFY
        and POST_MODIFY with CONST_INT adjustment equal to PUSH_ROUNDING.
        Fix POST_INC/POST_DEC handling if PUSH_ROUNDING is not identity.
        * config/i386/i386.md (pushhi2, pushqi2): Use pushl instead of pushw.
        Set mode to SI, adjust constraints.
        (pushhi2_rex64, pushqi2_rex64): Set mode to DI.
        * config/i386/i386.h (PUSH_ROUNDING): Round up to 4 instead of 2 for
        32-bit code.

        * gcc.target/i386/pr25293.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr25293.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.h
    trunk/gcc/config/i386/i386.md
    trunk/gcc/expr.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #16 from jakub at gcc dot gnu dot org  2005-12-13 08:17 -------
Subject: Bug 25023

Author: jakub
Date: Tue Dec 13 08:17:18 2005
New Revision: 108468

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108468
Log:
        PR debug/25023
        PR target/25293
        * expr.c (emit_move_resolve_push): Handle PRE_MODIFY
        and POST_MODIFY with CONST_INT adjustment equal to PUSH_ROUNDING.
        Fix POST_INC/POST_DEC handling if PUSH_ROUNDING is not identity.
        * config/i386/i386.md (pushhi2, pushqi2): Use pushl instead of pushw.
        Set mode to SI, adjust constraints.
        (pushhi2_rex64, pushqi2_rex64): Set mode to DI.
        * config/i386/i386.h (PUSH_ROUNDING): Round up to 4 instead of 2 for
        32-bit code.

        * gcc.target/i386/pr25293.c: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.target/i386/pr25293.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/config/i386/i386.h
    branches/gcc-4_1-branch/gcc/config/i386/i386.md
    branches/gcc-4_1-branch/gcc/expr.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #17 from jakub at gcc dot gnu dot org  2005-12-13 13:14 -------
Should be fixed in CVS.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[pinskia at gcc dot gnu dot org]

------- Comment #18 from pinskia at gcc dot gnu dot org  2005-12-13 20:16 -------
This is causing a bootstrap failure, the same as in comment #13 in fact.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #19 from jakub at gcc dot gnu dot org  2005-12-14 20:30 -------
Subject: Bug 25023

Author: jakub
Date: Wed Dec 14 20:30:46 2005
New Revision: 108537

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108537
Log:
        PR debug/25023
        * config/i386/i386.c (ix86_force_to_memory): Always use
        SImode push for HImode in -m32.
        (ix86_free_from_memory): Likewise.

        * gcc.dg/pr25023.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr25023.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023

[Bug debug/25023] [4.1/4.2 Regression] ICE in def_cfa_1, at dwarf2out.c:792

[jakub at gcc dot gnu dot org]

------- Comment #20 from jakub at gcc dot gnu dot org  2005-12-14 20:38 -------
Subject: Bug 25023

Author: jakub
Date: Wed Dec 14 20:38:31 2005
New Revision: 108539

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108539
Log:
        PR debug/25023
        * config/i386/i386.c (ix86_force_to_memory): Always use
        SImode push for HImode in -m32.
        (ix86_free_from_memory): Likewise.

        * gcc.dg/pr25023.c: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/pr25023.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/config/i386/i386.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25023