public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "steven at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/23837] [4.0/4.1/4.2 regression] Wrong code with REG_NO_CONFLICT notes (caused by combine) Date: Thu, 15 Dec 2005 00:52:00 -0000 [thread overview] Message-ID: <20051215005228.28735.qmail@sourceware.org> (raw) In-Reply-To: <bug-23837-5724@http.gcc.gnu.org/bugzilla/> ------- Comment #25 from steven at gcc dot gnu dot org 2005-12-15 00:52 ------- Smarter folks than me (iant ;-) suggest that "a multi-word rotate will normally need all the input bits when setting any of the output bits", so the entire no-conflict thing doesn't make sense here. So, let's not do that: --- optabs.c 2005-12-15 01:49:23.000000000 +0100 +++ optabs.c.jj 2005-12-15 01:49:55.000000000 +0100 @@ -1525,7 +1525,14 @@ expand_binop (enum machine_mode mode, op else equiv_value = 0; - emit_insn (insns); + /* We can't make this a no conflict block if this is a word swap, + because the word swap case fails if the input and output values + are in the same register. */ + if (shift_count != BITS_PER_WORD) + emit_no_conflict_block (insns, target, op0, op1, equiv_value); + else + emit_insn (insns); + return target; } -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23837
next prev parent reply other threads:[~2005-12-15 0:52 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-23837-5724@http.gcc.gnu.org/bugzilla/> 2005-10-10 4:29 ` [Bug rtl-optimization/23837] [4.0/4.1 regression] Wrong code with -fschedule-insns pinskia at gcc dot gnu dot org 2005-10-21 11:21 ` steven at gcc dot gnu dot org 2005-10-22 21:40 ` pinskia at gcc dot gnu dot org 2005-10-22 21:57 ` pinskia at gcc dot gnu dot org 2005-10-30 23:32 ` pinskia at gcc dot gnu dot org 2005-11-06 11:50 ` steven at gcc dot gnu dot org 2005-11-06 17:32 ` danglin at gcc dot gnu dot org 2005-11-06 17:47 ` steven at gcc dot gnu dot org 2005-11-19 1:28 ` pinskia at gcc dot gnu dot org 2005-12-12 20:19 ` [Bug rtl-optimization/23837] [4.0/4.1/4.2 " steven at gcc dot gnu dot org 2005-12-12 20:28 ` amylaar at gcc dot gnu dot org 2005-12-12 21:38 ` steven at gcc dot gnu dot org 2005-12-12 21:38 ` steven at gcc dot gnu dot org 2005-12-12 22:03 ` steven at gcc dot gnu dot org 2005-12-12 22:14 ` steven at gcc dot gnu dot org 2005-12-13 13:16 ` amylaar at gcc dot gnu dot org 2005-12-13 13:41 ` amylaar at gcc dot gnu dot org 2005-12-15 0:00 ` steven at gcc dot gnu dot org 2005-12-15 0:09 ` [Bug rtl-optimization/23837] [4.0/4.1/4.2 regression] Wrong code with REG_NO_CONFLICT notes (caused by combine) steven at gcc dot gnu dot org 2005-12-15 0:52 ` steven at gcc dot gnu dot org [this message] 2005-12-15 0:54 ` steven at gcc dot gnu dot org 2005-12-15 6:42 ` steven at gcc dot gnu dot org 2005-12-16 14:37 ` amylaar at gcc dot gnu dot org 2005-12-16 22:19 ` steven at gcc dot gnu dot org 2005-12-16 22:25 ` [Bug rtl-optimization/23837] [4.0/4.1 " steven at gcc dot gnu dot org 2005-12-17 17:27 ` danglin at gcc dot gnu dot org 2005-12-17 17:30 ` [Bug rtl-optimization/23837] [4.0 " pinskia at gcc dot gnu dot org 2005-12-17 17:30 ` [Bug rtl-optimization/23837] [4.0/4.1 " danglin at gcc dot gnu dot org 2005-12-17 17:31 ` [Bug rtl-optimization/23837] [4.0 " pinskia at gcc dot gnu dot org 2005-12-17 17:32 ` danglin at gcc dot gnu dot org 2005-12-19 12:01 ` amylaar at gcc dot gnu dot org 2005-12-19 12:36 ` steven at gcc dot gnu dot org 2005-12-19 13:34 ` joern dot rennecke at st dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20051215005228.28735.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).