From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10613 invoked by alias); 20 Dec 2005 15:58:35 -0000 Received: (qmail 10604 invoked by uid 48); 20 Dec 2005 15:58:33 -0000 Date: Tue, 20 Dec 2005 15:58:00 -0000 Message-ID: <20051220155833.10603.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug rtl-optimization/25196] [4.0/4.1 Regression] i386: wrong arguments passed In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "steven at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2005-12/txt/msg02123.txt.bz2 List-Id: ------- Comment #8 from steven at gcc dot gnu dot org 2005-12-20 15:58 ------- Gross. According to a comment in postreload.c:move2add_note_store(), we can have pushes without REG_INC notes: /* Some targets do argument pushes without adding REG_INC notes. */ So we need to go look for those {pre,post}{decrements,increments} ourselves. With this patch, we just do what postreload.c does. Index: postreload-gcse.c =================================================================== --- postreload-gcse.c (revision 108853) +++ postreload-gcse.c (working copy) @@ -676,6 +676,17 @@ record_last_set_info (rtx dest, rtx sett /* Ignore pushes, they clobber nothing. */ && ! push_operand (dest, GET_MODE (dest))) record_last_mem_set_info (last_set_insn); + + /* ??? Some targets do argument pushes without adding REG_INC notes. + See e.g. PR25196, where a pushsi2 on i386 doesn't have REG_INC + notes. */ + if (MEM_P (dest)) + { + dest = XEXP (dest, 0); + if (GET_CODE (dest) == PRE_INC || GET_CODE (dest) == POST_INC + || GET_CODE (dest) == PRE_DEC || GET_CODE (dest) == POST_DEC) + record_last_reg_set_info (last_set_insn, REGNO (XEXP (dest, 0))); + } } -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25196