* [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
@ 2005-10-30 23:21 ` pinskia at gcc dot gnu dot org
2005-11-15 15:15 ` pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-30 23:21 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P5
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
2005-10-30 23:21 ` [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure pinskia at gcc dot gnu dot org
@ 2005-11-15 15:15 ` pinskia at gcc dot gnu dot org
2005-11-20 13:26 ` rep dot nop at aon dot at
` (4 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-15 15:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2005-11-15 15:15 -------
*** Bug 24870 has been marked as a duplicate of this bug. ***
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aj at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
2005-10-30 23:21 ` [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure pinskia at gcc dot gnu dot org
2005-11-15 15:15 ` pinskia at gcc dot gnu dot org
@ 2005-11-20 13:26 ` rep dot nop at aon dot at
2005-11-20 17:56 ` bauhaus at futureapps dot de
` (3 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: rep dot nop at aon dot at @ 2005-11-20 13:26 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from rep dot nop at aon dot at 2005-11-20 13:26 -------
Created an attachment (id=10300)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10300&action=view)
Add newline to replacement fixup for string.h
I wouldn't generally add a newline in the replace command but adjust the fixups
which expect the newline to contain a newline in the replacement text.
The following patch gcc.gfortran-pr23400-00.diff adds a newline to the string
replacement which fixes the fixincludes failiure for me on i686-linux-gnu on
debian unstable.
gcc.gfortran-pr23400-00.diff
2005-11-20 Bernhard Fischer <rep.nop@aon.at>
PR 23400
* inclhack.def: Add newline to the replace text for string.h.
* fixincl.x: Regenerate.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2005-11-20 13:26 ` rep dot nop at aon dot at
@ 2005-11-20 17:56 ` bauhaus at futureapps dot de
2005-11-25 7:25 ` [Bug testsuite/23400] [4.1/4.2 " bkorb at gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: bauhaus at futureapps dot de @ 2005-11-20 17:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from bauhaus at futureapps dot de 2005-11-20 17:56 -------
> PR 23400
> * inclhack.def: Add newline to the replace text for string.h.
> * fixincl.x: Regenerate.
Similarly, removing \n from last line of the string.h
in the fixincludes source directory works for me (seemingly,
make check is running).
(-rw-r--r-- 1 georg staff 328 2005-11-20 16:42
../src/gcc/fixincludes/tests/base/string.h)
Why is there an Ultrix fix in string.h in the first place?
Does it just happen to be there because that is how
fixinclude had finished writing headers at some point?
--
bauhaus at futureapps dot de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bauhaus at futureapps dot de
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1/4.2 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2005-11-20 17:56 ` bauhaus at futureapps dot de
@ 2005-11-25 7:25 ` bkorb at gnu dot org
2005-12-30 7:28 ` pinskia at gcc dot gnu dot org
2006-03-11 16:51 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 7+ messages in thread
From: bkorb at gnu dot org @ 2005-11-25 7:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from bkorb at gnu dot org 2005-11-25 07:25 -------
A couple of issues:
1. Replacement fixes should not be checked, so it is interesting that
the failure shows up.
2. fixincl should not create files without terminating new lines anyway.
I've just applied a patch to fixfixes.c to fix this problem.
I'll look into the former issue when my bootstrap finishes....:)
I'd assign this thing to myself, but I guess I'm not powerful enough....
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1/4.2 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2005-11-25 7:25 ` [Bug testsuite/23400] [4.1/4.2 " bkorb at gnu dot org
@ 2005-12-30 7:28 ` pinskia at gcc dot gnu dot org
2006-03-11 16:51 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-12-30 7:28 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pinskia at gcc dot gnu dot org 2005-12-30 07:28 -------
Fixed by (on both the mainline and the 4.1 branch):
2005-11-24 Bruce Korb <bkorb@gnu.org>
* fixincl.c(write_replacement) "here strings" in AutoGen
often/generally
don't have a terminating newline. Check the last byte for '\n'.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug testsuite/23400] [4.1/4.2 Regression] "make check" fixinclude failure
[not found] <bug-23400-9876@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2005-12-30 7:28 ` pinskia at gcc dot gnu dot org
@ 2006-03-11 16:51 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-11 16:51 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from pinskia at gcc dot gnu dot org 2006-03-11 16:51 -------
*** Bug 26646 has been marked as a duplicate of this bug. ***
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomdkat at comcast dot net
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400
^ permalink raw reply [flat|nested] 7+ messages in thread